From: Cixi Geng <gengcixi@gmail.com>
To: jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
orsonzhai@gmail.com, baolin.wang7@gmail.com,
zhang.lyra@gmail.com
Cc: yuming.zhu1@unisoc.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/7] iio: adc: sc27xx: fix read big scale voltage not right
Date: Thu, 7 Apr 2022 16:21:43 +0800 [thread overview]
Message-ID: <20220407082148.571442-3-gengcixi@gmail.com> (raw)
In-Reply-To: <20220407082148.571442-1-gengcixi@gmail.com>
From: Cixi Geng <cixi.geng1@unisoc.com>
Fix wrong configuration value of SC27XX_ADC_SCALE_MASK and
SC27XX_ADC_SCALE_SHIFT by spec documetation.
Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
---
drivers/iio/adc/sc27xx_adc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c
index 00098caf6d9e..aee076c8e2b1 100644
--- a/drivers/iio/adc/sc27xx_adc.c
+++ b/drivers/iio/adc/sc27xx_adc.c
@@ -36,8 +36,8 @@
/* Bits and mask definition for SC27XX_ADC_CH_CFG register */
#define SC27XX_ADC_CHN_ID_MASK GENMASK(4, 0)
-#define SC27XX_ADC_SCALE_MASK GENMASK(10, 8)
-#define SC27XX_ADC_SCALE_SHIFT 8
+#define SC27XX_ADC_SCALE_MASK GENMASK(10, 9)
+#define SC27XX_ADC_SCALE_SHIFT 9
/* Bits definitions for SC27XX_ADC_INT_EN registers */
#define SC27XX_ADC_IRQ_EN BIT(0)
--
2.25.1
next prev parent reply other threads:[~2022-04-07 8:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 8:21 [PATCH V3 0/7] iio: adc: sc27xx: adjust structure and add PMIC's support Cixi Geng
2022-04-07 8:21 ` [PATCH V3 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dt-binding Cixi Geng
2022-04-13 19:12 ` Rob Herring
2022-04-18 6:26 ` Cixi Geng
2022-04-20 19:40 ` Rob Herring
2022-04-07 8:21 ` Cixi Geng [this message]
2022-04-10 16:10 ` [PATCH V3 2/7] iio: adc: sc27xx: fix read big scale voltage not right Jonathan Cameron
2022-04-11 12:50 ` Cixi Geng
2022-04-07 8:21 ` [PATCH V3 3/7] iio: adc: sc27xx: structure adjuststment and optimization Cixi Geng
2022-04-10 16:16 ` Jonathan Cameron
2022-04-07 8:21 ` [PATCH V3 4/7] iio: adc: refactor some functions for support more PMiCs Cixi Geng
2022-04-10 16:20 ` Jonathan Cameron
2022-04-07 8:21 ` [PATCH V3 5/7] iio: adc: sc27xx: add support for PMIC sc2720 and sc2721 Cixi Geng
2022-04-10 16:31 ` Jonathan Cameron
2022-04-07 8:21 ` [PATCH V3 6/7] iio: adc: sc27xx: add support for PMIC sc2730 Cixi Geng
2022-04-10 16:33 ` Jonathan Cameron
2022-04-07 8:21 ` [PATCH V3 7/7] iio: adc: sc27xx: add support for PMIC ump9620 Cixi Geng
2022-04-10 16:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407082148.571442-3-gengcixi@gmail.com \
--to=gengcixi@gmail.com \
--cc=baolin.wang7@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yuming.zhu1@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).