From: Rob Herring <robh@kernel.org>
To: Cixi Geng <gengcixi@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, orsonzhai@gmail.com,
baolin.wang7@gmail.com, zhang.lyra@gmail.com,
yuming.zhu1@unisoc.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dt-binding
Date: Wed, 13 Apr 2022 14:12:52 -0500 [thread overview]
Message-ID: <YlcgtLmXwc2s2+oJ@robh.at.kernel.org> (raw)
In-Reply-To: <20220407082148.571442-2-gengcixi@gmail.com>
On Thu, Apr 07, 2022 at 04:21:42PM +0800, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> sprd,ump9620-adc is one variant of sc27xx series, add ump9620
> description and sample in dt-bindings.
>
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
> .../bindings/iio/adc/sprd,sc2720-adc.yaml | 57 +++++++++++++++++--
> 1 file changed, 53 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
> index caa3ee0b4b8c..0d0f317b75c5 100644
> --- a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
> @@ -20,6 +20,7 @@ properties:
> - sprd,sc2723-adc
> - sprd,sc2730-adc
> - sprd,sc2731-adc
> + - sprd,ump9620-adc
>
> reg:
> maxItems: 1
> @@ -34,12 +35,39 @@ properties:
> maxItems: 1
>
> nvmem-cells:
> - maxItems: 2
> + description: nvmem-cells.
>
> nvmem-cell-names:
> - items:
> - - const: big_scale_calib
> - - const: small_scale_calib
> + description: Names for each nvmem-cells specified.
These descriptions of common properties are redundant. Just use 'true'
for the property values.
> +
> +if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - sprd,ump9620-adc
Use 'const'
> +then:
> + properties:
> + nvmem-cells:
> + maxItems: 2
> + nvmem-cell-names:
> + items:
> + - const: big_scale_calib
> + - const: small_scale_calib
> +
> +else:
> + properties:
> + nvmem-cells:
> + maxItems: 6
> + nvmem-cell-names:
> + items:
> + - const: big_scale_calib1
> + - const: big_scale_calib2
> + - const: small_scale_calib1
> + - const: small_scale_calib2
> + - const: vbat_det_cal1
> + - const: vbat_det_cal2
>
> required:
> - compatible
> @@ -69,4 +97,25 @@ examples:
> nvmem-cell-names = "big_scale_calib", "small_scale_calib";
> };
> };
> +
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + pmic {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + adc@504 {
> + compatible = "sprd,ump9620-adc";
> + reg = <0x504>;
> + interrupt-parent = <&ump9620_pmic>;
> + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> + #io-channel-cells = <1>;
> + hwlocks = <&hwlock 4>;
> + nvmem-cells = <&adc_bcal1>, <&adc_bcal2>,
> + <&adc_scal1>, <&adc_scal2>,
> + <&vbat_det_cal1>, <&vbat_det_cal2>;
> + nvmem-cell-names = "big_scale_calib1", "big_scale_calib2",
> + "small_scale_calib1", "small_scale_calib2",
> + "vbat_det_cal1", "vbat_det_cal2";
> + };
> + };
> ...
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-04-13 19:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 8:21 [PATCH V3 0/7] iio: adc: sc27xx: adjust structure and add PMIC's support Cixi Geng
2022-04-07 8:21 ` [PATCH V3 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dt-binding Cixi Geng
2022-04-13 19:12 ` Rob Herring [this message]
2022-04-18 6:26 ` Cixi Geng
2022-04-20 19:40 ` Rob Herring
2022-04-07 8:21 ` [PATCH V3 2/7] iio: adc: sc27xx: fix read big scale voltage not right Cixi Geng
2022-04-10 16:10 ` Jonathan Cameron
2022-04-11 12:50 ` Cixi Geng
2022-04-07 8:21 ` [PATCH V3 3/7] iio: adc: sc27xx: structure adjuststment and optimization Cixi Geng
2022-04-10 16:16 ` Jonathan Cameron
2022-04-07 8:21 ` [PATCH V3 4/7] iio: adc: refactor some functions for support more PMiCs Cixi Geng
2022-04-10 16:20 ` Jonathan Cameron
2022-04-07 8:21 ` [PATCH V3 5/7] iio: adc: sc27xx: add support for PMIC sc2720 and sc2721 Cixi Geng
2022-04-10 16:31 ` Jonathan Cameron
2022-04-07 8:21 ` [PATCH V3 6/7] iio: adc: sc27xx: add support for PMIC sc2730 Cixi Geng
2022-04-10 16:33 ` Jonathan Cameron
2022-04-07 8:21 ` [PATCH V3 7/7] iio: adc: sc27xx: add support for PMIC ump9620 Cixi Geng
2022-04-10 16:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlcgtLmXwc2s2+oJ@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=baolin.wang7@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gengcixi@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=yuming.zhu1@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).