From: Alexander Usyskin <alexander.usyskin@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Tomas Winkler <tomas.winkler@intel.com>,
Alexander Usyskin <alexander.usyskin@intel.com>,
Vitaly Lubart <vitaly.lubart@intel.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH 04/20] mei: gsc: add runtime pm handlers
Date: Thu, 7 Apr 2022 15:58:23 +0300 [thread overview]
Message-ID: <20220407125839.1479249-5-alexander.usyskin@intel.com> (raw)
In-Reply-To: <20220407125839.1479249-1-alexander.usyskin@intel.com>
From: Tomas Winkler <tomas.winkler@intel.com>
Implement runtime handlers for mei-gsc, to track
idle state of the device properly.
CC: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/misc/mei/gsc-me.c | 67 ++++++++++++++++++++++++++++++++++++++-
1 file changed, 66 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c
index 58e39c00f150..32ea75f5e7aa 100644
--- a/drivers/misc/mei/gsc-me.c
+++ b/drivers/misc/mei/gsc-me.c
@@ -159,7 +159,72 @@ static int __maybe_unused mei_gsc_pm_resume(struct device *device)
return 0;
}
-static SIMPLE_DEV_PM_OPS(mei_gsc_pm_ops, mei_gsc_pm_suspend, mei_gsc_pm_resume);
+static int __maybe_unused mei_gsc_pm_runtime_idle(struct device *device)
+{
+ struct mei_device *dev = dev_get_drvdata(device);
+
+ if (!dev)
+ return -ENODEV;
+ if (mei_write_is_idle(dev))
+ pm_runtime_autosuspend(device);
+
+ return -EBUSY;
+}
+
+static int __maybe_unused mei_gsc_pm_runtime_suspend(struct device *device)
+{
+ struct mei_device *dev = dev_get_drvdata(device);
+ struct mei_me_hw *hw;
+ int ret;
+
+ if (!dev)
+ return -ENODEV;
+
+ mutex_lock(&dev->device_lock);
+
+ if (mei_write_is_idle(dev)) {
+ hw = to_me_hw(dev);
+ hw->pg_state = MEI_PG_ON;
+ ret = 0;
+ } else {
+ ret = -EAGAIN;
+ }
+
+ mutex_unlock(&dev->device_lock);
+
+ return ret;
+}
+
+static int __maybe_unused mei_gsc_pm_runtime_resume(struct device *device)
+{
+ struct mei_device *dev = dev_get_drvdata(device);
+ struct mei_me_hw *hw;
+ irqreturn_t irq_ret;
+
+ if (!dev)
+ return -ENODEV;
+
+ mutex_lock(&dev->device_lock);
+
+ hw = to_me_hw(dev);
+ hw->pg_state = MEI_PG_OFF;
+
+ mutex_unlock(&dev->device_lock);
+
+ irq_ret = mei_me_irq_thread_handler(1, dev);
+ if (irq_ret != IRQ_HANDLED)
+ dev_err(dev->dev, "thread handler fail %d\n", irq_ret);
+
+ return 0;
+}
+
+static const struct dev_pm_ops mei_gsc_pm_ops = {
+ SET_SYSTEM_SLEEP_PM_OPS(mei_gsc_pm_suspend,
+ mei_gsc_pm_resume)
+ SET_RUNTIME_PM_OPS(mei_gsc_pm_runtime_suspend,
+ mei_gsc_pm_runtime_resume,
+ mei_gsc_pm_runtime_idle)
+};
static const struct auxiliary_device_id mei_gsc_id_table[] = {
{
--
2.32.0
next prev parent reply other threads:[~2022-04-07 12:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 12:58 [PATCH 00/20] GSC support for XeHP SDV and DG2 platforms Alexander Usyskin
2022-04-07 12:58 ` [PATCH 01/20] drm/i915/gsc: add gsc as a mei auxiliary device Alexander Usyskin
2022-04-07 12:58 ` [PATCH 02/20] mei: add support for graphics system controller (gsc) devices Alexander Usyskin
2022-04-07 12:58 ` [PATCH 03/20] mei: gsc: setup char driver alive in spite of firmware handshake failure Alexander Usyskin
2022-04-07 12:58 ` Alexander Usyskin [this message]
2022-04-07 12:58 ` [PATCH 05/20] mei: gsc: retrieve the firmware version Alexander Usyskin
2022-04-07 12:58 ` [PATCH 06/20] HAX: drm/i915: force INTEL_MEI_GSC on for CI Alexander Usyskin
2022-04-07 12:58 ` [PATCH 07/20] drm/i915/gsc: skip irq initialization if using polling Alexander Usyskin
2022-04-11 21:30 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [PATCH 08/20] drm/i915/gsc: add slow_fw flag to the mei auxiliary device Alexander Usyskin
2022-04-11 21:34 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [PATCH 09/20] drm/i915/gsc: add slow_fw flag to the gsc device definition Alexander Usyskin
2022-04-11 21:36 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [PATCH 10/20] drm/i915/gsc: add GSC XeHP SDV platform definition Alexander Usyskin
2022-04-07 12:58 ` [PATCH 11/20] mei: gsc: use polling instead of interrupts Alexander Usyskin
2022-04-07 12:58 ` [PATCH 12/20] mei: gsc: wait for reset thread on stop Alexander Usyskin
2022-04-07 12:58 ` [PATCH 13/20] mei: extend timeouts on slow devices Alexander Usyskin
2022-04-07 12:58 ` [PATCH 14/20] drm/i915/dg2: add gsc with special gsc bar offsets Alexander Usyskin
2022-04-13 19:12 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [PATCH 15/20] mei: bus: export common mkhi definitions into a separate header Alexander Usyskin
2022-04-07 12:58 ` [PATCH 16/20] mei: mkhi: add memory ready command Alexander Usyskin
2022-04-07 12:58 ` [PATCH 17/20] mei: gsc: setup gsc extended operational memory Alexander Usyskin
2022-04-07 12:58 ` [PATCH 18/20] mei: gsc: add transition to PXP mode in resume flow Alexander Usyskin
2022-04-07 12:58 ` [PATCH 19/20] mei: debugfs: add pxp mode to devstate in debugfs Alexander Usyskin
2022-04-07 12:58 ` [PATCH 20/20] drm/i915/gsc: allocate extended operational memory in LMEM Alexander Usyskin
2022-04-08 10:54 ` [Intel-gfx] " Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407125839.1479249-5-alexander.usyskin@intel.com \
--to=alexander.usyskin@intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tomas.winkler@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=vitaly.lubart@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).