From: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
To: Alexander Usyskin <alexander.usyskin@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>,
Tomas Winkler <tomas.winkler@intel.com>,
Vitaly Lubart <vitaly.lubart@intel.com>,
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 08/20] drm/i915/gsc: add slow_fw flag to the mei auxiliary device
Date: Mon, 11 Apr 2022 14:34:06 -0700 [thread overview]
Message-ID: <d0591904-d6dc-1f9a-f710-ee4e64d9a738@intel.com> (raw)
In-Reply-To: <20220407125839.1479249-9-alexander.usyskin@intel.com>
On 4/7/2022 5:58 AM, Alexander Usyskin wrote:
> Add slow_fw flag to the mei auxiliary device info
> to inform the mei driver about slow underlying firmware.
> Such firmware will require to use larger operation timeouts.
>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Might be worth squashing this in one of the patches that makes use of
it, but I can see the benefit of having the interface added in a patch
that's neither mei nor i915.
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> ---
> include/linux/mei_aux.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mei_aux.h b/include/linux/mei_aux.h
> index 587f25128848..a29f4064b9c0 100644
> --- a/include/linux/mei_aux.h
> +++ b/include/linux/mei_aux.h
> @@ -11,6 +11,7 @@ struct mei_aux_device {
> struct auxiliary_device aux_dev;
> int irq;
> struct resource bar;
> + bool slow_fw;
> };
>
> #define auxiliary_dev_to_mei_aux_dev(auxiliary_dev) \
next prev parent reply other threads:[~2022-04-11 21:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 12:58 [PATCH 00/20] GSC support for XeHP SDV and DG2 platforms Alexander Usyskin
2022-04-07 12:58 ` [PATCH 01/20] drm/i915/gsc: add gsc as a mei auxiliary device Alexander Usyskin
2022-04-07 12:58 ` [PATCH 02/20] mei: add support for graphics system controller (gsc) devices Alexander Usyskin
2022-04-07 12:58 ` [PATCH 03/20] mei: gsc: setup char driver alive in spite of firmware handshake failure Alexander Usyskin
2022-04-07 12:58 ` [PATCH 04/20] mei: gsc: add runtime pm handlers Alexander Usyskin
2022-04-07 12:58 ` [PATCH 05/20] mei: gsc: retrieve the firmware version Alexander Usyskin
2022-04-07 12:58 ` [PATCH 06/20] HAX: drm/i915: force INTEL_MEI_GSC on for CI Alexander Usyskin
2022-04-07 12:58 ` [PATCH 07/20] drm/i915/gsc: skip irq initialization if using polling Alexander Usyskin
2022-04-11 21:30 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [PATCH 08/20] drm/i915/gsc: add slow_fw flag to the mei auxiliary device Alexander Usyskin
2022-04-11 21:34 ` Ceraolo Spurio, Daniele [this message]
2022-04-07 12:58 ` [PATCH 09/20] drm/i915/gsc: add slow_fw flag to the gsc device definition Alexander Usyskin
2022-04-11 21:36 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [PATCH 10/20] drm/i915/gsc: add GSC XeHP SDV platform definition Alexander Usyskin
2022-04-07 12:58 ` [PATCH 11/20] mei: gsc: use polling instead of interrupts Alexander Usyskin
2022-04-07 12:58 ` [PATCH 12/20] mei: gsc: wait for reset thread on stop Alexander Usyskin
2022-04-07 12:58 ` [PATCH 13/20] mei: extend timeouts on slow devices Alexander Usyskin
2022-04-07 12:58 ` [PATCH 14/20] drm/i915/dg2: add gsc with special gsc bar offsets Alexander Usyskin
2022-04-13 19:12 ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [PATCH 15/20] mei: bus: export common mkhi definitions into a separate header Alexander Usyskin
2022-04-07 12:58 ` [PATCH 16/20] mei: mkhi: add memory ready command Alexander Usyskin
2022-04-07 12:58 ` [PATCH 17/20] mei: gsc: setup gsc extended operational memory Alexander Usyskin
2022-04-07 12:58 ` [PATCH 18/20] mei: gsc: add transition to PXP mode in resume flow Alexander Usyskin
2022-04-07 12:58 ` [PATCH 19/20] mei: debugfs: add pxp mode to devstate in debugfs Alexander Usyskin
2022-04-07 12:58 ` [PATCH 20/20] drm/i915/gsc: allocate extended operational memory in LMEM Alexander Usyskin
2022-04-08 10:54 ` [Intel-gfx] " Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0591904-d6dc-1f9a-f710-ee4e64d9a738@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=airlied@linux.ie \
--cc=alexander.usyskin@intel.com \
--cc=daniel@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tomas.winkler@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=vitaly.lubart@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).