linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Roger Quadros <rogerq@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Cai Huoqing <cai.huoqing@linux.dev>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Colin Ian King <colin.king@intel.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Paul Cercueil <paul@crapouillou.net>,
	Pratyush Yadav <p.yadav@ti.com>, Yu Kuai <yukuai3@huawei.com>,
	devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
	FLATTENED DEVICE TREE BINDINGS),
	linux-arm-kernel@lists.infradead.org (moderated
	list:ARM/Mediatek SoC support),
	linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
	SoC support), linux-kernel@vger.kernel.org (open list),
	linux-mtd@lists.infradead.org (open list:NAND FLASH SUBSYSTEM)
Subject: Re: [PATCH v4 1/5] mtd: nand: make mtk_ecc.c a separated module
Date: Fri, 8 Apr 2022 08:32:14 +0200	[thread overview]
Message-ID: <20220408083214.1473e88a@xps13> (raw)
In-Reply-To: <20220407150652.21885-2-gch981213@gmail.com>

Hi Chuanhong,

gch981213@gmail.com wrote on Thu,  7 Apr 2022 23:06:48 +0800:

> this code will be used in mediatek snfi spi-mem controller with
> pipelined ECC engine.
> 
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> ---
> 
> Change since v1:
>   actually make it a module instead of a part of nandcore.o
>     (ECC_MXIC probablly needs a similar fix.)

Please do not hesitate to propose something about it.

Otherwise on the MTD side the series looks good (besides the two
comments you already received).

I don't know if something changed regarding the comments style in the
spi subsystem, but using // everywhere looks strange, it's usually
reserved for the SPDX tag, but I'll let Mark comment on it.

Otherwise, MTD patches 1 and 3 look fine.

Thanks,
Miquèl

  reply	other threads:[~2022-04-08  6:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 15:06 [PATCH v4 0/5] spi: add support for Mediatek SPI-NAND controller Chuanhong Guo
2022-04-07 15:06 ` [PATCH v4 1/5] mtd: nand: make mtk_ecc.c a separated module Chuanhong Guo
2022-04-08  6:32   ` Miquel Raynal [this message]
2022-04-08 12:27     ` Mark Brown
2022-04-09 11:08       ` Chuanhong Guo
2022-04-11  7:17         ` Miquel Raynal
2022-04-07 15:06 ` [PATCH v4 2/5] spi: add driver for MTK SPI NAND Flash Interface Chuanhong Guo
2022-04-07 15:06 ` [PATCH v4 3/5] mtd: nand: mtk-ecc: also parse nand-ecc-engine if available Chuanhong Guo
2022-04-07 15:06 ` [PATCH v4 4/5] dt-bindings: spi: add binding doc for spi-mtk-snfi Chuanhong Guo
2022-04-07 15:21   ` Krzysztof Kozlowski
2022-04-07 15:06 ` [PATCH v4 5/5] arm64: dts: mediatek: add mtk-snfi for mt7622 Chuanhong Guo
2022-04-07 18:41 ` [PATCH v4 0/5] spi: add support for Mediatek SPI-NAND controller Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220408083214.1473e88a@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=cai.huoqing@linux.dev \
    --cc=colin.king@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gch981213@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.yadav@ti.com \
    --cc=paul@crapouillou.net \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=vigneshr@ti.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).