From: Mark Brown <broonie@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Chuanhong Guo <gch981213@gmail.com>,
linux-spi@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Cai Huoqing <cai.huoqing@linux.dev>,
Florian Fainelli <f.fainelli@gmail.com>,
Colin Ian King <colin.king@intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Paul Cercueil <paul@crapouillou.net>,
Pratyush Yadav <p.yadav@ti.com>, Yu Kuai <yukuai3@huawei.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:NAND FLASH SUBSYSTEM" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v4 1/5] mtd: nand: make mtk_ecc.c a separated module
Date: Fri, 8 Apr 2022 13:27:53 +0100 [thread overview]
Message-ID: <YlAqSQ5w3y39aOy+@sirena.org.uk> (raw)
In-Reply-To: <20220408083214.1473e88a@xps13>
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On Fri, Apr 08, 2022 at 08:32:14AM +0200, Miquel Raynal wrote:
> Otherwise on the MTD side the series looks good (besides the two
> comments you already received).
What's the plan for merging then?
> I don't know if something changed regarding the comments style in the
> spi subsystem, but using // everywhere looks strange, it's usually
> reserved for the SPDX tag, but I'll let Mark comment on it.
I generally request that, it looks messy if the comment block at the top
mixes styles.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-08 12:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 15:06 [PATCH v4 0/5] spi: add support for Mediatek SPI-NAND controller Chuanhong Guo
2022-04-07 15:06 ` [PATCH v4 1/5] mtd: nand: make mtk_ecc.c a separated module Chuanhong Guo
2022-04-08 6:32 ` Miquel Raynal
2022-04-08 12:27 ` Mark Brown [this message]
2022-04-09 11:08 ` Chuanhong Guo
2022-04-11 7:17 ` Miquel Raynal
2022-04-07 15:06 ` [PATCH v4 2/5] spi: add driver for MTK SPI NAND Flash Interface Chuanhong Guo
2022-04-07 15:06 ` [PATCH v4 3/5] mtd: nand: mtk-ecc: also parse nand-ecc-engine if available Chuanhong Guo
2022-04-07 15:06 ` [PATCH v4 4/5] dt-bindings: spi: add binding doc for spi-mtk-snfi Chuanhong Guo
2022-04-07 15:21 ` Krzysztof Kozlowski
2022-04-07 15:06 ` [PATCH v4 5/5] arm64: dts: mediatek: add mtk-snfi for mt7622 Chuanhong Guo
2022-04-07 18:41 ` [PATCH v4 0/5] spi: add support for Mediatek SPI-NAND controller Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlAqSQ5w3y39aOy+@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cai.huoqing@linux.dev \
--cc=colin.king@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gch981213@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=vigneshr@ti.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).