* [PATCH v3] staging: rtl8723bs: tidy up error handling
@ 2022-04-08 14:44 Yihao Han
2022-04-08 14:58 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Yihao Han @ 2022-04-08 14:44 UTC (permalink / raw)
To: Greg Kroah-Hartman, Fabio Aiuto, Fabio M. De Francesco,
Xiangyang Zhang, Yihao Han, Lee Jones, Bryan Brattlof,
linux-staging, linux-kernel
Cc: kernel
The check for if rtw_skb_alloc() fails is done twice and is written
in a confusing way. Move the "if (!recvbuf->pskb)" right after
the allocation. The "if (recvbuf->pskb)" check can now be deleted
and the code pulled in one tab.
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
v2: more extensive cleanup
v3: edit commit message
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index a545832a468e..107f427ee4aa 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -811,17 +811,14 @@ static struct recv_buf *sd_recv_rxfifo(struct adapter *adapter, u32 size)
SIZE_PTR alignment = 0;
recvbuf->pskb = rtw_skb_alloc(MAX_RECVBUF_SZ + RECVBUFF_ALIGN_SZ);
-
- if (recvbuf->pskb) {
- recvbuf->pskb->dev = adapter->pnetdev;
-
- tmpaddr = (SIZE_PTR)recvbuf->pskb->data;
- alignment = tmpaddr & (RECVBUFF_ALIGN_SZ - 1);
- skb_reserve(recvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
- }
-
if (!recvbuf->pskb)
return NULL;
+
+ recvbuf->pskb->dev = adapter->pnetdev;
+
+ tmpaddr = (SIZE_PTR)recvbuf->pskb->data;
+ alignment = tmpaddr & (RECVBUFF_ALIGN_SZ - 1);
+ skb_reserve(recvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
}
/* 3 3. read data from rxfifo */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] staging: rtl8723bs: tidy up error handling
2022-04-08 14:44 [PATCH v3] staging: rtl8723bs: tidy up error handling Yihao Han
@ 2022-04-08 14:58 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2022-04-08 14:58 UTC (permalink / raw)
To: Yihao Han
Cc: Greg Kroah-Hartman, Fabio Aiuto, Fabio M. De Francesco,
Xiangyang Zhang, Lee Jones, Bryan Brattlof, linux-staging,
linux-kernel, kernel
On Fri, Apr 08, 2022 at 07:44:40AM -0700, Yihao Han wrote:
> The check for if rtw_skb_alloc() fails is done twice and is written
> in a confusing way. Move the "if (!recvbuf->pskb)" right after
> the allocation. The "if (recvbuf->pskb)" check can now be deleted
> and the code pulled in one tab.
>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
> v2: more extensive cleanup
> v3: edit commit message
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-08 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-08 14:44 [PATCH v3] staging: rtl8723bs: tidy up error handling Yihao Han
2022-04-08 14:58 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).