[PATCH 2/4] mm/migration: remove unneeded lock page and PageMovable check

From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <mike.kravetz@oracle.com>, <shy828301@gmail.com>,
	<willy@infradead.org>, <ying.huang@intel.com>, <ziy@nvidia.com>,
	<minchan@kernel.org>, <apopple@nvidia.com>,
	<dave.hansen@linux.intel.com>, <o451686892@gmail.com>,
	<jhubbard@nvidia.com>, <peterx@redhat.com>,
	<naoya.horiguchi@nec.com>, <mhocko@suse.com>, <riel@redhat.com>,
	<osalvador@suse.de>, <david@redhat.com>, <sfr@canb.auug.org.au>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<linmiaohe@huawei.com>
Subject: [PATCH 2/4] mm/migration: remove unneeded lock page and PageMovable check
Date: Sat, 9 Apr 2022 15:38:44 +0800	[thread overview]
Message-ID: <20220409073846.22286-3-linmiaohe@huawei.com> (raw)
In-Reply-To: <20220409073846.22286-1-linmiaohe@huawei.com>

When non-lru movable page was freed from under us, __ClearPageMovable must
have been done. Even if it's not done, ClearPageIsolated here won't hurt
as page will be freed anyway. So we can thus remove unneeded lock page and
PageMovable check here.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/migrate.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index d8aae6c75990..381963231a62 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1098,12 +1098,8 @@ static int unmap_and_move(new_page_t get_new_page,
 		/* page was freed from under us. So we are done. */
 		ClearPageActive(page);
 		ClearPageUnevictable(page);
-		if (unlikely(__PageMovable(page))) {
-			lock_page(page);
-			if (!PageMovable(page))
-				ClearPageIsolated(page);
-			unlock_page(page);
-		}
+		if (unlikely(__PageMovable(page)))
+			ClearPageIsolated(page);
 		goto out;
 	}
 
-- 
2.23.0

