From: Miaohe Lin <linmiaohe@huawei.com>
To: "ying.huang@intel.com" <ying.huang@intel.com>
Cc: <mike.kravetz@oracle.com>, <shy828301@gmail.com>,
<willy@infradead.org>, <ziy@nvidia.com>, <minchan@kernel.org>,
<apopple@nvidia.com>, <dave.hansen@linux.intel.com>,
<o451686892@gmail.com>, <jhubbard@nvidia.com>,
<peterx@redhat.com>, <naoya.horiguchi@nec.com>, <mhocko@suse.com>,
<riel@redhat.com>, <osalvador@suse.de>, <david@redhat.com>,
<sfr@canb.auug.org.au>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/4] A few cleanup and fixup patches for migration
Date: Tue, 12 Apr 2022 11:29:31 +0800 [thread overview]
Message-ID: <880376f0-f480-979b-261f-72cf9475474c@huawei.com> (raw)
In-Reply-To: <e268117b314817ecd4c07ac48b0a6dcaf680ed69.camel@intel.com>
On 2022/4/12 10:25, ying.huang@intel.com wrote:
> On Sat, 2022-04-09 at 15:38 +0800, Miaohe Lin wrote:
>> Hi everyone,
>> This series contains a few patches to remove unneeded lock page and
>> PageMovable check, reduce the rcu lock duration. Also we fix potential
>> pte_unmap on an not mapped pte. More details can be found in the
>> respective changelogs. Thanks!
>
> It appears that you ignored my comments for the previous version. Can
> you check it?
I do remember [1] and I tried to make isolate_huge_page consistent with isolate_lru_page.
But their return value conventions are different. isolate_huge_page return 0 when
success while isolate_huge_page returns true in this case. So make them consistent
would lead to many code change. I should have added this in my changelog.
Thanks.
[1] https://lore.kernel.org/linux-mm/8735jsgctq.fsf@yhuang6-desk2.ccr.corp.intel.com/
>
> Best Regards,
> Huang, Ying
>
>> ---
>> v1:
>> rebase [1] on mainline.
>>
>> [1] https://lore.kernel.org/lkml/20220304093409.25829-2-linmiaohe@huawei.com/T/
>> ---
>> Miaohe Lin (4):
>> mm/migration: reduce the rcu lock duration
>> mm/migration: remove unneeded lock page and PageMovable check
>> mm/migration: return errno when isolate_huge_page failed
>> mm/migration: fix potential pte_unmap on an not mapped pte
>>
>> include/linux/migrate.h | 2 +-
>> include/linux/swapops.h | 4 ++--
>> mm/filemap.c | 10 +++++-----
>> mm/hugetlb.c | 2 +-
>> mm/migrate.c | 31 +++++++++++++------------------
>> 5 files changed, 22 insertions(+), 27 deletions(-)
>>
>
>
>
> .
>
next prev parent reply other threads:[~2022-04-12 3:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 7:38 [PATCH 0/4] A few cleanup and fixup patches for migration Miaohe Lin
2022-04-09 7:38 ` [PATCH 1/4] mm/migration: reduce the rcu lock duration Miaohe Lin
2022-04-11 14:09 ` Christoph Hellwig
2022-04-12 2:07 ` ying.huang
2022-04-12 3:21 ` Miaohe Lin
2022-04-09 7:38 ` [PATCH 2/4] mm/migration: remove unneeded lock page and PageMovable check Miaohe Lin
2022-04-11 14:09 ` Christoph Hellwig
2022-04-09 7:38 ` [PATCH 3/4] mm/migration: return errno when isolate_huge_page failed Miaohe Lin
2022-04-11 14:10 ` Christoph Hellwig
2022-04-12 3:13 ` Miaohe Lin
2022-04-09 7:38 ` [PATCH 4/4] mm/migration: fix potential pte_unmap on an not mapped pte Miaohe Lin
2022-04-09 11:38 ` kernel test robot
2022-04-11 1:54 ` Miaohe Lin
2022-04-11 11:41 ` David Hildenbrand
2022-04-12 2:55 ` Miaohe Lin
2022-04-12 2:25 ` [PATCH 0/4] A few cleanup and fixup patches for migration ying.huang
2022-04-12 3:29 ` Miaohe Lin [this message]
2022-04-12 6:33 ` ying.huang
2022-04-12 8:59 ` Miaohe Lin
2022-04-12 7:00 ` ying.huang
2022-04-12 9:06 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=880376f0-f480-979b-261f-72cf9475474c@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=minchan@kernel.org \
--cc=naoya.horiguchi@nec.com \
--cc=o451686892@gmail.com \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
--cc=riel@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).