From: Lukas Wunner <lukas@wunner.de>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
=robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
stefanb@linux.ibm.com, p.rosenberger@kunbus.com
Subject: Re: [PATCH 5/5] tpm: tpm_tis_spi_slb_9670: implement set_reset and unset_reset functions
Date: Sun, 10 Apr 2022 19:18:26 +0200 [thread overview]
Message-ID: <20220410171826.GB24453@wunner.de> (raw)
In-Reply-To: <20220407111849.5676-6-LinoSanfilippo@gmx.de>
On Thu, Apr 07, 2022 at 01:18:49PM +0200, Lino Sanfilippo wrote:
> --- /dev/null
> +++ b/drivers/char/tpm/tpm_tis_spi_slb9670.c
[...]
> +int slb9670_spi_unset_reset(struct tpm_tis_data *data)
[...]
> +int slb9670_spi_set_reset(struct tpm_tis_data *data)
[...]
> +static const struct tpm_tis_phy_ops slb9670_spi_phy_ops = {
> + .read_bytes = tpm_tis_spi_read_bytes,
> + .write_bytes = tpm_tis_spi_write_bytes,
> + .read16 = tpm_tis_spi_read16,
> + .read32 = tpm_tis_spi_read32,
> + .write32 = tpm_tis_spi_write32,
> + .set_reset = slb9670_spi_set_reset,
> + .unset_reset = slb9670_spi_unset_reset,
> +};
0-day is complaining that slb9670_spi_set_reset() / slb9670_spi_unset_reset()
are not declared static:
https://lore.kernel.org/all/202204081357.8SfjQosI-lkp@intel.com/
Thanks,
Lukas
next prev parent reply other threads:[~2022-04-10 17:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 11:18 [PATCH 0/5] Support TPM Reset GPIO Lino Sanfilippo
2022-04-07 11:18 ` [PATCH 1/5] tpm: add functions to set and unset the tpm chips reset state Lino Sanfilippo
2022-04-07 14:25 ` Jason Gunthorpe
2022-04-10 9:03 ` Lino Sanfilippo
2022-04-10 17:11 ` Lukas Wunner
2022-04-11 11:47 ` Jason Gunthorpe
2022-04-14 12:13 ` Jarkko Sakkinen
2022-04-07 11:18 ` [PATCH 2/5] dt-bindings: tpm: document reset gpio property Lino Sanfilippo
2022-04-07 11:18 ` [PATCH 3/5] tpm: tpm_tis: get optionally defined reset gpio Lino Sanfilippo
2022-04-07 11:18 ` [PATCH 4/5] tpm: tpm_tis: make functions available for external linkage Lino Sanfilippo
2022-04-07 11:18 ` [PATCH 5/5] tpm: tpm_tis_spi_slb_9670: implement set_reset and unset_reset functions Lino Sanfilippo
2022-04-10 17:18 ` Lukas Wunner [this message]
2022-04-10 19:44 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220410171826.GB24453@wunner.de \
--to=lukas@wunner.de \
--cc==robh+dt@kernel.org \
--cc=LinoSanfilippo@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.rosenberger@kunbus.com \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).