* [PATCH V4 2/3] arm64: dts: imx8mn: Enable HS400-ES
2022-04-10 19:35 [PATCH V4 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Adam Ford
@ 2022-04-10 19:35 ` Adam Ford
2022-04-11 6:42 ` Krzysztof Kozlowski
2022-04-18 8:08 ` Shawn Guo
2022-04-10 19:35 ` [PATCH V4 3/3] arm64: dts: imx8mp: " Adam Ford
` (2 subsequent siblings)
3 siblings, 2 replies; 10+ messages in thread
From: Adam Ford @ 2022-04-10 19:35 UTC (permalink / raw)
To: linux-mmc
Cc: aford, Adam Ford, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel
The SDHC controller in the imx8mn has the same controller
as the imx8mm which supports HS400-ES. Change the compatible
fallback to imx8mm to enable it, but keep the imx7d-usdhc
to prevent breaking backwards compatibility.
Signed-off-by: Adam Ford <aford173@gmail.com>
---
V4: No Change
V3: No change
V2: Keep fallback to fsl,imx7d-usdhc to prevent breakage
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 99f0f5026674..13c51363cc06 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -933,7 +933,7 @@ mu: mailbox@30aa0000 {
};
usdhc1: mmc@30b40000 {
- compatible = "fsl,imx8mn-usdhc", "fsl,imx7d-usdhc";
+ compatible = "fsl,imx8mn-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
reg = <0x30b40000 0x10000>;
interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MN_CLK_IPG_ROOT>,
@@ -947,7 +947,7 @@ usdhc1: mmc@30b40000 {
};
usdhc2: mmc@30b50000 {
- compatible = "fsl,imx8mn-usdhc", "fsl,imx7d-usdhc";
+ compatible = "fsl,imx8mn-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
reg = <0x30b50000 0x10000>;
interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MN_CLK_IPG_ROOT>,
@@ -961,7 +961,7 @@ usdhc2: mmc@30b50000 {
};
usdhc3: mmc@30b60000 {
- compatible = "fsl,imx8mn-usdhc", "fsl,imx7d-usdhc";
+ compatible = "fsl,imx8mn-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
reg = <0x30b60000 0x10000>;
interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MN_CLK_IPG_ROOT>,
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH V4 2/3] arm64: dts: imx8mn: Enable HS400-ES
2022-04-10 19:35 ` [PATCH V4 2/3] arm64: dts: imx8mn: Enable HS400-ES Adam Ford
@ 2022-04-11 6:42 ` Krzysztof Kozlowski
2022-04-18 8:08 ` Shawn Guo
1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-11 6:42 UTC (permalink / raw)
To: Adam Ford, linux-mmc
Cc: aford, Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel
On 10/04/2022 21:35, Adam Ford wrote:
> The SDHC controller in the imx8mn has the same controller
> as the imx8mm which supports HS400-ES. Change the compatible
> fallback to imx8mm to enable it, but keep the imx7d-usdhc
> to prevent breaking backwards compatibility.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V4 2/3] arm64: dts: imx8mn: Enable HS400-ES
2022-04-10 19:35 ` [PATCH V4 2/3] arm64: dts: imx8mn: Enable HS400-ES Adam Ford
2022-04-11 6:42 ` Krzysztof Kozlowski
@ 2022-04-18 8:08 ` Shawn Guo
1 sibling, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2022-04-18 8:08 UTC (permalink / raw)
To: Adam Ford
Cc: linux-mmc, aford, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel
On Sun, Apr 10, 2022 at 02:35:42PM -0500, Adam Ford wrote:
> The SDHC controller in the imx8mn has the same controller
> as the imx8mm which supports HS400-ES. Change the compatible
> fallback to imx8mm to enable it, but keep the imx7d-usdhc
> to prevent breaking backwards compatibility.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Applied #2 and #3, thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V4 3/3] arm64: dts: imx8mp: Enable HS400-ES
2022-04-10 19:35 [PATCH V4 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Adam Ford
2022-04-10 19:35 ` [PATCH V4 2/3] arm64: dts: imx8mn: Enable HS400-ES Adam Ford
@ 2022-04-10 19:35 ` Adam Ford
2022-04-11 6:43 ` Krzysztof Kozlowski
2022-04-12 14:12 ` Ahmad Fatoum
2022-04-11 6:42 ` [PATCH V4 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Krzysztof Kozlowski
2022-04-12 12:09 ` Ulf Hansson
3 siblings, 2 replies; 10+ messages in thread
From: Adam Ford @ 2022-04-10 19:35 UTC (permalink / raw)
To: linux-mmc
Cc: aford, Adam Ford, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel
The SDHC controller in the imx8mp has the same controller
as the imx8mm which supports HS400-ES. Change the compatible
fallback to imx8mm to enable it, but keep the imx7d-usdhc
to prevent breaking backwards compatibility.
Signed-off-by: Adam Ford <aford173@gmail.com>
---
V4: No Change
V3: No change
V2: Keep fallback to fsl,imx7d-usdhc to prevent breakage
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 794d75173cf5..8578ff1062e6 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -769,7 +769,7 @@ i2c6: i2c@30ae0000 {
};
usdhc1: mmc@30b40000 {
- compatible = "fsl,imx8mp-usdhc", "fsl,imx7d-usdhc";
+ compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
reg = <0x30b40000 0x10000>;
interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MP_CLK_DUMMY>,
@@ -783,7 +783,7 @@ usdhc1: mmc@30b40000 {
};
usdhc2: mmc@30b50000 {
- compatible = "fsl,imx8mp-usdhc", "fsl,imx7d-usdhc";
+ compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
reg = <0x30b50000 0x10000>;
interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MP_CLK_DUMMY>,
@@ -797,7 +797,7 @@ usdhc2: mmc@30b50000 {
};
usdhc3: mmc@30b60000 {
- compatible = "fsl,imx8mp-usdhc", "fsl,imx7d-usdhc";
+ compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
reg = <0x30b60000 0x10000>;
interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MP_CLK_DUMMY>,
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH V4 3/3] arm64: dts: imx8mp: Enable HS400-ES
2022-04-10 19:35 ` [PATCH V4 3/3] arm64: dts: imx8mp: " Adam Ford
@ 2022-04-11 6:43 ` Krzysztof Kozlowski
2022-04-12 14:12 ` Ahmad Fatoum
1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-11 6:43 UTC (permalink / raw)
To: Adam Ford, linux-mmc
Cc: aford, Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel
On 10/04/2022 21:35, Adam Ford wrote:
> The SDHC controller in the imx8mp has the same controller
> as the imx8mm which supports HS400-ES. Change the compatible
> fallback to imx8mm to enable it, but keep the imx7d-usdhc
> to prevent breaking backwards compatibility.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V4 3/3] arm64: dts: imx8mp: Enable HS400-ES
2022-04-10 19:35 ` [PATCH V4 3/3] arm64: dts: imx8mp: " Adam Ford
2022-04-11 6:43 ` Krzysztof Kozlowski
@ 2022-04-12 14:12 ` Ahmad Fatoum
1 sibling, 0 replies; 10+ messages in thread
From: Ahmad Fatoum @ 2022-04-12 14:12 UTC (permalink / raw)
To: Adam Ford, linux-mmc
Cc: devicetree, Ulf Hansson, Fabio Estevam, Pengutronix Kernel Team,
Sascha Hauer, aford, linux-kernel, Rob Herring, NXP Linux Team,
Krzysztof Kozlowski, Shawn Guo, linux-arm-kernel
On 10.04.22 21:35, Adam Ford wrote:
> The SDHC controller in the imx8mp has the same controller
> as the imx8mm which supports HS400-ES. Change the compatible
> fallback to imx8mm to enable it, but keep the imx7d-usdhc
> to prevent breaking backwards compatibility.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Thanks,
Ahmad
> ---
> V4: No Change
> V3: No change
> V2: Keep fallback to fsl,imx7d-usdhc to prevent breakage
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 794d75173cf5..8578ff1062e6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -769,7 +769,7 @@ i2c6: i2c@30ae0000 {
> };
>
> usdhc1: mmc@30b40000 {
> - compatible = "fsl,imx8mp-usdhc", "fsl,imx7d-usdhc";
> + compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
> reg = <0x30b40000 0x10000>;
> interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk IMX8MP_CLK_DUMMY>,
> @@ -783,7 +783,7 @@ usdhc1: mmc@30b40000 {
> };
>
> usdhc2: mmc@30b50000 {
> - compatible = "fsl,imx8mp-usdhc", "fsl,imx7d-usdhc";
> + compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
> reg = <0x30b50000 0x10000>;
> interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk IMX8MP_CLK_DUMMY>,
> @@ -797,7 +797,7 @@ usdhc2: mmc@30b50000 {
> };
>
> usdhc3: mmc@30b60000 {
> - compatible = "fsl,imx8mp-usdhc", "fsl,imx7d-usdhc";
> + compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
> reg = <0x30b60000 0x10000>;
> interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk IMX8MP_CLK_DUMMY>,
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V4 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks
2022-04-10 19:35 [PATCH V4 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Adam Ford
2022-04-10 19:35 ` [PATCH V4 2/3] arm64: dts: imx8mn: Enable HS400-ES Adam Ford
2022-04-10 19:35 ` [PATCH V4 3/3] arm64: dts: imx8mp: " Adam Ford
@ 2022-04-11 6:42 ` Krzysztof Kozlowski
2022-04-11 15:18 ` Adam Ford
2022-04-12 12:09 ` Ulf Hansson
3 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-11 6:42 UTC (permalink / raw)
To: Adam Ford, linux-mmc
Cc: aford, haibo.chen, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel
On 10/04/2022 21:35, Adam Ford wrote:
> The SDHC controller in the imx8mn and imx8mp have the same controller
> as the imx8mm which is slightly different than that of the imx7d.
>
> Using the fallback of the imx8mm enables the controllers to support
> HS400-ES which is not available on the imx7d. After discussion with NXP,
> it turns out that the imx8qm should fall back to the imx8qxp, because
> those have some additional flags not present in the imx8mm.
>
> Mark the current state of the fallbacks as deprecated, and add the
> proper fallbacks so in the future, the deprecated combination can be
> removed and prevent any future devices from using the wrong fallback.
>
> Suggested-by: haibo.chen@nxp.com
> Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V4 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks
2022-04-11 6:42 ` [PATCH V4 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Krzysztof Kozlowski
@ 2022-04-11 15:18 ` Adam Ford
0 siblings, 0 replies; 10+ messages in thread
From: Adam Ford @ 2022-04-11 15:18 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-mmc, Adam Ford-BE, Haibo Chen, Ulf Hansson, Rob Herring,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
devicetree, arm-soc, Linux Kernel Mailing List
On Mon, Apr 11, 2022 at 1:42 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 10/04/2022 21:35, Adam Ford wrote:
> > The SDHC controller in the imx8mn and imx8mp have the same controller
> > as the imx8mm which is slightly different than that of the imx7d.
> >
> > Using the fallback of the imx8mm enables the controllers to support
> > HS400-ES which is not available on the imx7d. After discussion with NXP,
> > it turns out that the imx8qm should fall back to the imx8qxp, because
> > those have some additional flags not present in the imx8mm.
> >
> > Mark the current state of the fallbacks as deprecated, and add the
> > proper fallbacks so in the future, the deprecated combination can be
> > removed and prevent any future devices from using the wrong fallback.
> >
> > Suggested-by: haibo.chen@nxp.com
> > Signed-off-by: Adam Ford <aford173@gmail.com>
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Thanks for the help and guidance. I always seem to struggle with the
YAML syntax.
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V4 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks
2022-04-10 19:35 [PATCH V4 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Adam Ford
` (2 preceding siblings ...)
2022-04-11 6:42 ` [PATCH V4 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Krzysztof Kozlowski
@ 2022-04-12 12:09 ` Ulf Hansson
3 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2022-04-12 12:09 UTC (permalink / raw)
To: Adam Ford
Cc: linux-mmc, aford, haibo.chen, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel
On Sun, 10 Apr 2022 at 21:35, Adam Ford <aford173@gmail.com> wrote:
>
> The SDHC controller in the imx8mn and imx8mp have the same controller
> as the imx8mm which is slightly different than that of the imx7d.
>
> Using the fallback of the imx8mm enables the controllers to support
> HS400-ES which is not available on the imx7d. After discussion with NXP,
> it turns out that the imx8qm should fall back to the imx8qxp, because
> those have some additional flags not present in the imx8mm.
>
> Mark the current state of the fallbacks as deprecated, and add the
> proper fallbacks so in the future, the deprecated combination can be
> removed and prevent any future devices from using the wrong fallback.
>
> Suggested-by: haibo.chen@nxp.com
> Signed-off-by: Adam Ford <aford173@gmail.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> V4: Mark deprecated items with "deprecated: true" instead of a comment
> V3: Add support for the interim fallback on imx8mn and imx8mp where
> they both fallback to imx8mm, but keep the imx7d to prevent any
> breakage.
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index 7dbbcae9485c..58447095f000 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -34,22 +34,46 @@ properties:
> - fsl,imx6ull-usdhc
> - fsl,imx7d-usdhc
> - fsl,imx7ulp-usdhc
> + - fsl,imx8mm-usdhc
> - fsl,imxrt1050-usdhc
> - nxp,s32g2-usdhc
> + - items:
> + - enum:
> + - fsl,imx8mq-usdhc
> + - const: fsl,imx7d-usdhc
> + - items:
> + - enum:
> + - fsl,imx8mn-usdhc
> + - fsl,imx8mp-usdhc
> + - fsl,imx93-usdhc
> + - fsl,imx8ulp-usdhc
> + - const: fsl,imx8mm-usdhc
> + - items:
> + - enum:
> + - fsl,imx8qm-usdhc
> + - const: fsl,imx8qxp-usdhc
> - items:
> - enum:
> - fsl,imx8mm-usdhc
> - fsl,imx8mn-usdhc
> - fsl,imx8mp-usdhc
> - - fsl,imx8mq-usdhc
> - fsl,imx8qm-usdhc
> - fsl,imx8qxp-usdhc
> - const: fsl,imx7d-usdhc
> + deprecated: true
> - items:
> - enum:
> - - fsl,imx93-usdhc
> - - fsl,imx8ulp-usdhc
> + - fsl,imx8mn-usdhc
> + - fsl,imx8mp-usdhc
> - const: fsl,imx8mm-usdhc
> + - const: fsl,imx7d-usdhc
> + deprecated: true
> + - items:
> + - enum:
> + - fsl,imx8qm-usdhc
> + - const: fsl,imx8qxp-usdhc
> + - const: fsl,imx7d-usdhc
> + deprecated: true
>
> reg:
> maxItems: 1
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread