linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wil6210: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
@ 2022-04-11  1:36 cgel.zte
  2022-04-23  9:31 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-11  1:36 UTC (permalink / raw)
  To: merez
  Cc: kvalo, davem, kuba, linux-wireless, wil6210, netdev,
	linux-kernel, Minghao Chi, Zeal Robot

From: Minghao Chi <chi.minghao@zte.com.cn>

Using pm_runtime_resume_and_get is more appropriate
for simplifing code

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 drivers/net/wireless/ath/wil6210/pm.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/wil6210/pm.c b/drivers/net/wireless/ath/wil6210/pm.c
index ed4df561e5c5..f521af575e9b 100644
--- a/drivers/net/wireless/ath/wil6210/pm.c
+++ b/drivers/net/wireless/ath/wil6210/pm.c
@@ -445,10 +445,9 @@ int wil_pm_runtime_get(struct wil6210_priv *wil)
 	int rc;
 	struct device *dev = wil_to_dev(wil);
 
-	rc = pm_runtime_get_sync(dev);
+	rc = pm_runtime_resume_and_get(dev);
 	if (rc < 0) {
-		wil_err(wil, "pm_runtime_get_sync() failed, rc = %d\n", rc);
-		pm_runtime_put_noidle(dev);
+		wil_err(wil, "pm_runtime_resume_and_get() failed, rc = %d\n", rc);
 		return rc;
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] wil6210: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
  2022-04-11  1:36 [PATCH] wil6210: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
@ 2022-04-23  9:31 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-04-23  9:31 UTC (permalink / raw)
  To: cgel.zte
  Cc: merez, davem, kuba, linux-wireless, wil6210, netdev,
	linux-kernel, Minghao Chi, Zeal Robot

cgel.zte@gmail.com wrote:

> Using pm_runtime_resume_and_get() is more appropriate
> for simplifing code.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

45286070e9e7 wil6210: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220411013602.2517086-1-chi.minghao@zte.com.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-23  9:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11  1:36 [PATCH] wil6210: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
2022-04-23  9:31 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).