linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] remoteproc: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
@ 2022-04-11  1:36 cgel.zte
  2022-07-18 22:59 ` (subset) " Bjorn Andersson
  0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-11  1:36 UTC (permalink / raw)
  To: bjorn.andersson
  Cc: mathieu.poirier, linux-remoteproc, linux-kernel, Minghao Chi, Zeal Robot

From: Minghao Chi <chi.minghao@zte.com.cn>

Using pm_runtime_resume_and_get is more appropriate
for simplifing code

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 drivers/remoteproc/keystone_remoteproc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
index 54781f553f4e..594a9b43b7ae 100644
--- a/drivers/remoteproc/keystone_remoteproc.c
+++ b/drivers/remoteproc/keystone_remoteproc.c
@@ -410,10 +410,9 @@ static int keystone_rproc_probe(struct platform_device *pdev)
 
 	/* enable clock for accessing DSP internal memories */
 	pm_runtime_enable(dev);
-	ret = pm_runtime_get_sync(dev);
+	ret = pm_runtime_resume_and_get(dev);
 	if (ret < 0) {
 		dev_err(dev, "failed to enable clock, status = %d\n", ret);
-		pm_runtime_put_noidle(dev);
 		goto disable_rpm;
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: (subset) [PATCH] remoteproc: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
  2022-04-11  1:36 [PATCH] remoteproc: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
@ 2022-07-18 22:59 ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2022-07-18 22:59 UTC (permalink / raw)
  To: cgel.zte
  Cc: chi.minghao, linux-kernel, zealci, mathieu.poirier, linux-remoteproc

On Mon, 11 Apr 2022 01:36:56 +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
> 
> 

Applied, thanks!

[1/1] remoteproc: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
      commit: 3ebebb9a2d9a5c2d2b866739b50838dc152727fc

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-18 22:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11  1:36 [PATCH] remoteproc: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
2022-07-18 22:59 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).