* [PATCH v2] ext4: remove unnecessary conditional
@ 2022-04-11 3:23 cgel.zte
2022-05-13 21:15 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-11 3:23 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: linux-ext4, linux-kernel, Lv Ruyi, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
iput() has already handled null and non-null parameter, so it is no
need to use if().
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
v2: change subject from "remove redundant judgment" to
"remove unnecessary conditional"
---
fs/ext4/fast_commit.c | 3 +--
fs/ext4/namei.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 3d72565ec6e8..e85d351a1a31 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -1659,8 +1659,7 @@ static int ext4_fc_replay_create(struct super_block *sb, struct ext4_fc_tl *tl,
set_nlink(inode, 1);
ext4_mark_inode_dirty(NULL, inode);
out:
- if (inode)
- iput(inode);
+ iput(inode);
return ret;
}
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index e37da8d5cd0c..2fd3b24a21cd 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -3363,8 +3363,7 @@ static int ext4_symlink(struct user_namespace *mnt_userns, struct inode *dir,
err = ext4_add_nondir(handle, dentry, &inode);
if (handle)
ext4_journal_stop(handle);
- if (inode)
- iput(inode);
+ iput(inode);
goto out_free_encrypted_link;
err_drop_inode:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ext4: remove unnecessary conditional
2022-04-11 3:23 [PATCH v2] ext4: remove unnecessary conditional cgel.zte
@ 2022-05-13 21:15 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2022-05-13 21:15 UTC (permalink / raw)
To: cgel.zte, adilger.kernel
Cc: Theodore Ts'o, linux-kernel, Lv Ruyi, linux-ext4, Zeal Robot
On Mon, 11 Apr 2022 03:23:37 +0000, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> iput() has already handled null and non-null parameter, so it is no
> need to use if().
>
>
Applied, thanks!
[1/1] ext4: remove unnecessary conditional
commit: 784a09951c1d8383498c0df091a37db612bebfc7
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-13 21:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 3:23 [PATCH v2] ext4: remove unnecessary conditional cgel.zte
2022-05-13 21:15 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).