* [PATCH] perf tools: Fix misleading add event pmu debug message
@ 2022-04-11 6:17 Adrian Hunter
2022-04-11 17:59 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Hunter @ 2022-04-11 6:17 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: Jiri Olsa, Ian Rogers, linux-kernel
Fix incorrect debug message:
Attempting to add event pmu 'intel_pt' with '' that may result in
non-fatal errors
which always appears with perf record -vv and intel_pt e.g.
perf record -vv -e intel_pt//u uname
The message is incorrect because there will never be non-fatal errors.
Suppress the message if the pmu is 'selectable' i.e. meant to be selected
directly as an event.
Fixes: 4ac22b484d4c79 ("perf parse-events: Make add PMU verbose output clearer")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/util/parse-events.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 24997925ae00..dd84fed698a3 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -1523,7 +1523,9 @@ int parse_events_add_pmu(struct parse_events_state *parse_state,
bool use_uncore_alias;
LIST_HEAD(config_terms);
- if (verbose > 1) {
+ pmu = parse_state->fake_pmu ?: perf_pmu__find(name);
+
+ if (verbose > 1 && !(pmu && pmu->selectable)) {
fprintf(stderr, "Attempting to add event pmu '%s' with '",
name);
if (head_config) {
@@ -1536,7 +1538,6 @@ int parse_events_add_pmu(struct parse_events_state *parse_state,
fprintf(stderr, "' that may result in non-fatal errors\n");
}
- pmu = parse_state->fake_pmu ?: perf_pmu__find(name);
if (!pmu) {
char *err_str;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf tools: Fix misleading add event pmu debug message
2022-04-11 6:17 [PATCH] perf tools: Fix misleading add event pmu debug message Adrian Hunter
@ 2022-04-11 17:59 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-04-11 17:59 UTC (permalink / raw)
To: Adrian Hunter; +Cc: Jiri Olsa, Ian Rogers, linux-kernel
Em Mon, Apr 11, 2022 at 09:17:58AM +0300, Adrian Hunter escreveu:
> Fix incorrect debug message:
>
> Attempting to add event pmu 'intel_pt' with '' that may result in
> non-fatal errors
>
> which always appears with perf record -vv and intel_pt e.g.
>
> perf record -vv -e intel_pt//u uname
>
> The message is incorrect because there will never be non-fatal errors.
>
> Suppress the message if the pmu is 'selectable' i.e. meant to be selected
> directly as an event.
Thanks, applied.
- Arnaldo
> Fixes: 4ac22b484d4c79 ("perf parse-events: Make add PMU verbose output clearer")
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/util/parse-events.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 24997925ae00..dd84fed698a3 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1523,7 +1523,9 @@ int parse_events_add_pmu(struct parse_events_state *parse_state,
> bool use_uncore_alias;
> LIST_HEAD(config_terms);
>
> - if (verbose > 1) {
> + pmu = parse_state->fake_pmu ?: perf_pmu__find(name);
> +
> + if (verbose > 1 && !(pmu && pmu->selectable)) {
> fprintf(stderr, "Attempting to add event pmu '%s' with '",
> name);
> if (head_config) {
> @@ -1536,7 +1538,6 @@ int parse_events_add_pmu(struct parse_events_state *parse_state,
> fprintf(stderr, "' that may result in non-fatal errors\n");
> }
>
> - pmu = parse_state->fake_pmu ?: perf_pmu__find(name);
> if (!pmu) {
> char *err_str;
>
> --
> 2.25.1
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-11 17:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 6:17 [PATCH] perf tools: Fix misleading add event pmu debug message Adrian Hunter
2022-04-11 17:59 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).