* [PATCH] dt-bindings: media: amphion: use hyphen in node name of vpu core
@ 2022-04-11 7:48 Ming Qian
2022-11-24 8:48 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Ming Qian @ 2022-04-11 7:48 UTC (permalink / raw)
To: mchehab, shawnguo
Cc: hverkuil-cisco, robh+dt, s.hauer, kernel, festevam, linux-imx,
aisheng.dong, linux-media, linux-kernel, linux-arm-kernel
Hyphen is recommended in node name than underscore.
So change the node name from "vpu_core" to "vpu-core"
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
Documentation/devicetree/bindings/media/amphion,vpu.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/amphion,vpu.yaml b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
index a9d80eaeeeb6..c0d83d755239 100644
--- a/Documentation/devicetree/bindings/media/amphion,vpu.yaml
+++ b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
@@ -47,7 +47,7 @@ patternProperties:
$ref: ../mailbox/fsl,mu.yaml#
- "^vpu_core@[0-9a-f]+$":
+ "^vpu-core@[0-9a-f]+$":
description:
Each core correspond a decoder or encoder, need to configure them
separately. NXP i.MX8QM SoC has one decoder and two encoder, i.MX8QXP SoC
@@ -143,7 +143,7 @@ examples:
power-domains = <&pd IMX_SC_R_VPU_MU_2>;
};
- vpu_core0: vpu_core@2d080000 {
+ vpu_core0: vpu-core@2d080000 {
compatible = "nxp,imx8q-vpu-decoder";
reg = <0x2d080000 0x10000>;
power-domains = <&pd IMX_SC_R_VPU_DEC_0>;
@@ -154,7 +154,7 @@ examples:
memory-region = <&decoder_boot>, <&decoder_rpc>;
};
- vpu_core1: vpu_core@2d090000 {
+ vpu_core1: vpu-core@2d090000 {
compatible = "nxp,imx8q-vpu-encoder";
reg = <0x2d090000 0x10000>;
power-domains = <&pd IMX_SC_R_VPU_ENC_0>;
@@ -165,7 +165,7 @@ examples:
memory-region = <&encoder1_boot>, <&encoder1_rpc>;
};
- vpu_core2: vpu_core@2d0a0000 {
+ vpu_core2: vpu-core@2d0a0000 {
reg = <0x2d0a0000 0x10000>;
compatible = "nxp,imx8q-vpu-encoder";
power-domains = <&pd IMX_SC_R_VPU_ENC_1>;
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: amphion: use hyphen in node name of vpu core
2022-04-11 7:48 [PATCH] dt-bindings: media: amphion: use hyphen in node name of vpu core Ming Qian
@ 2022-11-24 8:48 ` Hans Verkuil
2023-03-13 13:26 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2022-11-24 8:48 UTC (permalink / raw)
To: Ming Qian, mchehab, shawnguo
Cc: robh+dt, s.hauer, kernel, festevam, linux-imx, aisheng.dong,
linux-media, linux-kernel, linux-arm-kernel, linux-devicetree
Rob, can you Ack (or nack) this old patch? It looks like it was
missed, most likely because the devicetree ML wasn't CCed.
Regards,
Hans
On 11/04/2022 09:48, Ming Qian wrote:
> Hyphen is recommended in node name than underscore.
> So change the node name from "vpu_core" to "vpu-core"
>
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
> ---
> Documentation/devicetree/bindings/media/amphion,vpu.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/amphion,vpu.yaml b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
> index a9d80eaeeeb6..c0d83d755239 100644
> --- a/Documentation/devicetree/bindings/media/amphion,vpu.yaml
> +++ b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
> @@ -47,7 +47,7 @@ patternProperties:
> $ref: ../mailbox/fsl,mu.yaml#
>
>
> - "^vpu_core@[0-9a-f]+$":
> + "^vpu-core@[0-9a-f]+$":
> description:
> Each core correspond a decoder or encoder, need to configure them
> separately. NXP i.MX8QM SoC has one decoder and two encoder, i.MX8QXP SoC
> @@ -143,7 +143,7 @@ examples:
> power-domains = <&pd IMX_SC_R_VPU_MU_2>;
> };
>
> - vpu_core0: vpu_core@2d080000 {
> + vpu_core0: vpu-core@2d080000 {
> compatible = "nxp,imx8q-vpu-decoder";
> reg = <0x2d080000 0x10000>;
> power-domains = <&pd IMX_SC_R_VPU_DEC_0>;
> @@ -154,7 +154,7 @@ examples:
> memory-region = <&decoder_boot>, <&decoder_rpc>;
> };
>
> - vpu_core1: vpu_core@2d090000 {
> + vpu_core1: vpu-core@2d090000 {
> compatible = "nxp,imx8q-vpu-encoder";
> reg = <0x2d090000 0x10000>;
> power-domains = <&pd IMX_SC_R_VPU_ENC_0>;
> @@ -165,7 +165,7 @@ examples:
> memory-region = <&encoder1_boot>, <&encoder1_rpc>;
> };
>
> - vpu_core2: vpu_core@2d0a0000 {
> + vpu_core2: vpu-core@2d0a0000 {
> reg = <0x2d0a0000 0x10000>;
> compatible = "nxp,imx8q-vpu-encoder";
> power-domains = <&pd IMX_SC_R_VPU_ENC_1>;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: amphion: use hyphen in node name of vpu core
2022-11-24 8:48 ` Hans Verkuil
@ 2023-03-13 13:26 ` Hans Verkuil
2023-03-14 1:05 ` [EXT] " Ming Qian
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2023-03-13 13:26 UTC (permalink / raw)
To: Ming Qian, mchehab, shawnguo
Cc: robh+dt, s.hauer, kernel, festevam, linux-imx, aisheng.dong,
linux-media, linux-kernel, linux-arm-kernel, linux-devicetree
Ming,
I recommend reposting this patch if you still want it.
Regards,
Hans
On 24/11/2022 09:48, Hans Verkuil wrote:
> Rob, can you Ack (or nack) this old patch? It looks like it was
> missed, most likely because the devicetree ML wasn't CCed.
>
> Regards,
>
> Hans
>
> On 11/04/2022 09:48, Ming Qian wrote:
>> Hyphen is recommended in node name than underscore.
>> So change the node name from "vpu_core" to "vpu-core"
>>
>> Signed-off-by: Ming Qian <ming.qian@nxp.com>
>> ---
>> Documentation/devicetree/bindings/media/amphion,vpu.yaml | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/amphion,vpu.yaml b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
>> index a9d80eaeeeb6..c0d83d755239 100644
>> --- a/Documentation/devicetree/bindings/media/amphion,vpu.yaml
>> +++ b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
>> @@ -47,7 +47,7 @@ patternProperties:
>> $ref: ../mailbox/fsl,mu.yaml#
>>
>>
>> - "^vpu_core@[0-9a-f]+$":
>> + "^vpu-core@[0-9a-f]+$":
>> description:
>> Each core correspond a decoder or encoder, need to configure them
>> separately. NXP i.MX8QM SoC has one decoder and two encoder, i.MX8QXP SoC
>> @@ -143,7 +143,7 @@ examples:
>> power-domains = <&pd IMX_SC_R_VPU_MU_2>;
>> };
>>
>> - vpu_core0: vpu_core@2d080000 {
>> + vpu_core0: vpu-core@2d080000 {
>> compatible = "nxp,imx8q-vpu-decoder";
>> reg = <0x2d080000 0x10000>;
>> power-domains = <&pd IMX_SC_R_VPU_DEC_0>;
>> @@ -154,7 +154,7 @@ examples:
>> memory-region = <&decoder_boot>, <&decoder_rpc>;
>> };
>>
>> - vpu_core1: vpu_core@2d090000 {
>> + vpu_core1: vpu-core@2d090000 {
>> compatible = "nxp,imx8q-vpu-encoder";
>> reg = <0x2d090000 0x10000>;
>> power-domains = <&pd IMX_SC_R_VPU_ENC_0>;
>> @@ -165,7 +165,7 @@ examples:
>> memory-region = <&encoder1_boot>, <&encoder1_rpc>;
>> };
>>
>> - vpu_core2: vpu_core@2d0a0000 {
>> + vpu_core2: vpu-core@2d0a0000 {
>> reg = <0x2d0a0000 0x10000>;
>> compatible = "nxp,imx8q-vpu-encoder";
>> power-domains = <&pd IMX_SC_R_VPU_ENC_1>;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: [PATCH] dt-bindings: media: amphion: use hyphen in node name of vpu core
2023-03-13 13:26 ` Hans Verkuil
@ 2023-03-14 1:05 ` Ming Qian
0 siblings, 0 replies; 4+ messages in thread
From: Ming Qian @ 2023-03-14 1:05 UTC (permalink / raw)
To: Hans Verkuil, mchehab, shawnguo
Cc: robh+dt, s.hauer, kernel, festevam, dl-linux-imx, Aisheng Dong,
linux-media, linux-kernel, linux-arm-kernel, linux-devicetree
Hi Hans,
Thank you for reminding me, I think it's OK to drop it.
Ming
>Ming,
>
>I recommend reposting this patch if you still want it.
>
>Regards,
>
> Hans
>
>On 24/11/2022 09:48, Hans Verkuil wrote:
>> Rob, can you Ack (or nack) this old patch? It looks like it was
>> missed, most likely because the devicetree ML wasn't CCed.
>>
>> Regards,
>>
>> Hans
>>
>> On 11/04/2022 09:48, Ming Qian wrote:
>>> Hyphen is recommended in node name than underscore.
>>> So change the node name from "vpu_core" to "vpu-core"
>>>
>>> Signed-off-by: Ming Qian <ming.qian@nxp.com>
>>> ---
>>> Documentation/devicetree/bindings/media/amphion,vpu.yaml | 8
>>> ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/amphion,vpu.yaml
>>> b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
>>> index a9d80eaeeeb6..c0d83d755239 100644
>>> --- a/Documentation/devicetree/bindings/media/amphion,vpu.yaml
>>> +++ b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
>>> @@ -47,7 +47,7 @@ patternProperties:
>>> $ref: ../mailbox/fsl,mu.yaml#
>>>
>>>
>>> - "^vpu_core@[0-9a-f]+$":
>>> + "^vpu-core@[0-9a-f]+$":
>>> description:
>>> Each core correspond a decoder or encoder, need to configure them
>>> separately. NXP i.MX8QM SoC has one decoder and two encoder,
>>> i.MX8QXP SoC @@ -143,7 +143,7 @@ examples:
>>> power-domains = <&pd IMX_SC_R_VPU_MU_2>;
>>> };
>>>
>>> - vpu_core0: vpu_core@2d080000 {
>>> + vpu_core0: vpu-core@2d080000 {
>>> compatible = "nxp,imx8q-vpu-decoder";
>>> reg = <0x2d080000 0x10000>;
>>> power-domains = <&pd IMX_SC_R_VPU_DEC_0>; @@ -154,7 +154,7
>>> @@ examples:
>>> memory-region = <&decoder_boot>, <&decoder_rpc>;
>>> };
>>>
>>> - vpu_core1: vpu_core@2d090000 {
>>> + vpu_core1: vpu-core@2d090000 {
>>> compatible = "nxp,imx8q-vpu-encoder";
>>> reg = <0x2d090000 0x10000>;
>>> power-domains = <&pd IMX_SC_R_VPU_ENC_0>; @@ -165,7 +165,7
>>> @@ examples:
>>> memory-region = <&encoder1_boot>, <&encoder1_rpc>;
>>> };
>>>
>>> - vpu_core2: vpu_core@2d0a0000 {
>>> + vpu_core2: vpu-core@2d0a0000 {
>>> reg = <0x2d0a0000 0x10000>;
>>> compatible = "nxp,imx8q-vpu-encoder";
>>> power-domains = <&pd IMX_SC_R_VPU_ENC_1>;
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-14 1:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 7:48 [PATCH] dt-bindings: media: amphion: use hyphen in node name of vpu core Ming Qian
2022-11-24 8:48 ` Hans Verkuil
2023-03-13 13:26 ` Hans Verkuil
2023-03-14 1:05 ` [EXT] " Ming Qian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).