* [PATCH] hsi: clients: remove duplicate assignment
@ 2022-03-31 12:07 Qing Wang
2022-04-12 10:00 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Qing Wang @ 2022-03-31 12:07 UTC (permalink / raw)
To: Sebastian Reichel, linux-kernel; +Cc: Wang Qing
From: Wang Qing <wangqing@vivo.com>
netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
no need to repeat assignment.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/hsi/clients/ssi_protocol.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
index 21f11a5..7aacb19
--- a/drivers/hsi/clients/ssi_protocol.c
+++ b/drivers/hsi/clients/ssi_protocol.c
@@ -796,7 +796,6 @@ static void ssip_rx_strans(struct hsi_client *cl, u32 cmd)
dev_err(&cl->device, "No memory for rx skb\n");
goto out1;
}
- skb->dev = ssi->netdev;
skb_put(skb, len * 4);
msg = ssip_alloc_data(ssi, skb, GFP_ATOMIC);
if (unlikely(!msg)) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hsi: clients: remove duplicate assignment
2022-03-31 12:07 [PATCH] hsi: clients: remove duplicate assignment Qing Wang
@ 2022-04-12 10:00 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2022-04-12 10:00 UTC (permalink / raw)
To: Qing Wang; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
Hi,
On Thu, Mar 31, 2022 at 05:07:38AM -0700, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
>
> netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
> no need to repeat assignment.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/hsi/clients/ssi_protocol.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
> index 21f11a5..7aacb19
> --- a/drivers/hsi/clients/ssi_protocol.c
> +++ b/drivers/hsi/clients/ssi_protocol.c
> @@ -796,7 +796,6 @@ static void ssip_rx_strans(struct hsi_client *cl, u32 cmd)
> dev_err(&cl->device, "No memory for rx skb\n");
> goto out1;
> }
> - skb->dev = ssi->netdev;
> skb_put(skb, len * 4);
> msg = ssip_alloc_data(ssi, skb, GFP_ATOMIC);
> if (unlikely(!msg)) {
> --
> 2.7.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-12 11:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31 12:07 [PATCH] hsi: clients: remove duplicate assignment Qing Wang
2022-04-12 10:00 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).