From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH v2 2/8] staging: r8188eu: clean up comments in struct rt_firmware_hdr
Date: Thu, 14 Apr 2022 12:43:17 +0200 [thread overview]
Message-ID: <20220414104323.6152-3-straube.linux@gmail.com> (raw)
In-Reply-To: <20220414104323.6152-1-straube.linux@gmail.com>
The comments in struct rt_firmware_hdr are not needed.
Remove them.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_fw.c | 37 ++++++++-------------------
1 file changed, 11 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c
index 7cd08268f3b9..323e0c634c4e 100644
--- a/drivers/staging/r8188eu/core/rtw_fw.c
+++ b/drivers/staging/r8188eu/core/rtw_fw.c
@@ -14,37 +14,22 @@
(le16_to_cpu(_fwhdr->Signature) & 0xFFF0) == 0x2300 || \
(le16_to_cpu(_fwhdr->Signature) & 0xFFF0) == 0x88E0)
-/* This structure must be careful with byte-ordering */
-
struct rt_firmware_hdr {
- /* 8-byte alinment required */
- /* LONG WORD 0 ---- */
- __le16 Signature; /* 92C0: test chip; 92C,
- * 88C0: test chip; 88C1: MP A-cut;
- * 92C1: MP A-cut */
- u8 Category; /* AP/NIC and USB/PCI */
- u8 Function; /* Reserved for different FW function
- * indcation, for further use when
- * driver needs to download different
- * FW for different conditions */
- __le16 Version; /* FW Version */
- u8 Subversion; /* FW Subversion, default 0x00 */
+ __le16 Signature;
+ u8 Category;
+ u8 Function;
+ __le16 Version;
+ u8 Subversion;
u8 Rsvd1;
-
- /* LONG WORD 1 ---- */
- u8 Month; /* Release time Month field */
- u8 Date; /* Release time Date field */
- u8 Hour; /* Release time Hour field */
- u8 Minute; /* Release time Minute field */
- __le16 RamCodeSize; /* The size of RAM code */
+ u8 Month;
+ u8 Date;
+ u8 Hour;
+ u8 Minute;
+ __le16 RamCodeSize;
u8 Foundry;
u8 Rsvd2;
-
- /* LONG WORD 2 ---- */
- __le32 SvnIdx; /* The SVN entry index */
+ __le32 SvnIdx;
__le32 Rsvd3;
-
- /* LONG WORD 3 ---- */
__le32 Rsvd4;
__le32 Rsvd5;
};
--
2.35.1
next prev parent reply other threads:[~2022-04-14 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 10:43 [PATCH v2 0/8] staging: r8188eu: fix and clean up some firmware code Michael Straube
2022-04-14 10:43 ` [PATCH v2 1/8] staging: r8188eu: fix struct rt_firmware_hdr Michael Straube
2022-04-14 10:43 ` Michael Straube [this message]
2022-04-14 10:43 ` [PATCH v2 3/8] staging: r8188eu: rename fields of " Michael Straube
2022-04-14 10:43 ` [PATCH v2 4/8] staging: r8188eu: use sizeof instead of hardcoded firmware header size Michael Straube
2022-04-14 10:43 ` [PATCH v2 5/8] staging: r8188eu: remove variables from rtl8188e_firmware_download() Michael Straube
2022-04-14 10:43 ` [PATCH v2 6/8] staging: r8188eu: always log firmware info Michael Straube
2022-04-14 10:43 ` [PATCH v2 7/8] staging: r8188eu: check firmware header existence before access Michael Straube
2022-04-14 10:43 ` [PATCH v2 8/8] staging: r8188eu: check rt_firmware_hdr size at compile time Michael Straube
2022-04-14 15:48 ` [PATCH v2 0/8] staging: r8188eu: fix and clean up some firmware code Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414104323.6152-3-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).