linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Michael Straube <straube.linux@gmail.com>,
	David Laight <David.Laight@ACULAB.COM>
Subject: [PATCH v2 8/8] staging: r8188eu: check rt_firmware_hdr size at compile time
Date: Thu, 14 Apr 2022 12:43:23 +0200	[thread overview]
Message-ID: <20220414104323.6152-9-straube.linux@gmail.com> (raw)
In-Reply-To: <20220414104323.6152-1-straube.linux@gmail.com>

Check the size of struct rt_firmware_hdr at compile time since
we rely on the size to be 32 in rtl8188e_firmware_download().

Suggested-by: David Laight <David.Laight@ACULAB.COM>
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_fw.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c
index c58bce1a1856..4417375a158d 100644
--- a/drivers/staging/r8188eu/core/rtw_fw.c
+++ b/drivers/staging/r8188eu/core/rtw_fw.c
@@ -34,6 +34,8 @@ struct rt_firmware_hdr {
 	__le32	rsvd5;
 };
 
+static_assert(sizeof(struct rt_firmware_hdr) == 32);
+
 static void fw_download_enable(struct adapter *padapter, bool enable)
 {
 	u8 tmp;
-- 
2.35.1


  parent reply	other threads:[~2022-04-14 10:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 10:43 [PATCH v2 0/8] staging: r8188eu: fix and clean up some firmware code Michael Straube
2022-04-14 10:43 ` [PATCH v2 1/8] staging: r8188eu: fix struct rt_firmware_hdr Michael Straube
2022-04-14 10:43 ` [PATCH v2 2/8] staging: r8188eu: clean up comments in " Michael Straube
2022-04-14 10:43 ` [PATCH v2 3/8] staging: r8188eu: rename fields of " Michael Straube
2022-04-14 10:43 ` [PATCH v2 4/8] staging: r8188eu: use sizeof instead of hardcoded firmware header size Michael Straube
2022-04-14 10:43 ` [PATCH v2 5/8] staging: r8188eu: remove variables from rtl8188e_firmware_download() Michael Straube
2022-04-14 10:43 ` [PATCH v2 6/8] staging: r8188eu: always log firmware info Michael Straube
2022-04-14 10:43 ` [PATCH v2 7/8] staging: r8188eu: check firmware header existence before access Michael Straube
2022-04-14 10:43 ` Michael Straube [this message]
2022-04-14 15:48 ` [PATCH v2 0/8] staging: r8188eu: fix and clean up some firmware code Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220414104323.6152-9-straube.linux@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).