linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] remoteproc: mediatek: allow different SCP firmware names
@ 2022-04-14 11:53 Allen-KH Cheng
  2022-04-14 11:53 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: dd firmware-name property Allen-KH Cheng
  2022-04-14 11:53 ` [PATCH 2/2] remoteproc: mediatek: allow reading firmware-name from DT Allen-KH Cheng
  0 siblings, 2 replies; 3+ messages in thread
From: Allen-KH Cheng @ 2022-04-14 11:53 UTC (permalink / raw)
  To: Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier, Rob Herring,
	Matthias Brugger
  Cc: Hsin-Yi Wang, Project_Global_Chrome_Upstream_Group, linux-kernel,
	devicetree, linux-mediatek, linux-arm-kernel, linux-remoteproc,
	Allen-KH Cheng

The SCP needs firmware which differs between platforms and SoCs. Add a new
property "firmware-name" to allow the DT to specify the platform/board specific
path to this firmware file.

The firmware-name property is optional and the code falls back to the
old filename if the property isn't present.

Base on tag: next-20220412, linux-next/master

Allen-KH Cheng (2):
  dt-bindings: remoteproc: mediatek: dd firmware-name property
  remoteproc: mediatek: allow reading firmware-name from DT

 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 7 +++++++
 drivers/remoteproc/mtk_scp.c                              | 7 ++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

-- 
2.18.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] dt-bindings: remoteproc: mediatek: dd firmware-name property
  2022-04-14 11:53 [PATCH 0/2] remoteproc: mediatek: allow different SCP firmware names Allen-KH Cheng
@ 2022-04-14 11:53 ` Allen-KH Cheng
  2022-04-14 11:53 ` [PATCH 2/2] remoteproc: mediatek: allow reading firmware-name from DT Allen-KH Cheng
  1 sibling, 0 replies; 3+ messages in thread
From: Allen-KH Cheng @ 2022-04-14 11:53 UTC (permalink / raw)
  To: Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier, Rob Herring,
	Matthias Brugger
  Cc: Hsin-Yi Wang, Project_Global_Chrome_Upstream_Group, linux-kernel,
	devicetree, linux-mediatek, linux-arm-kernel, linux-remoteproc,
	Allen-KH Cheng

The SCP needs firmware which differs between other platforms and SoCs.
Add a new property "firmware-name" to allow the DT to specify the
platform/board specific path to this firmware file.

Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
index 5b693a2d049c..a20effa836f1 100644
--- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
@@ -42,6 +42,13 @@ properties:
   clock-names:
     const: main
 
+  firmware-name:
+    $ref: /schemas/types.yaml#/definitions/string
+    description:
+      If present, name (or relative path) of the file within the
+      firmware search path containing the firmware image used when
+      initializing SCP.
+
 required:
   - compatible
   - reg
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] remoteproc: mediatek: allow reading firmware-name from DT
  2022-04-14 11:53 [PATCH 0/2] remoteproc: mediatek: allow different SCP firmware names Allen-KH Cheng
  2022-04-14 11:53 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: dd firmware-name property Allen-KH Cheng
@ 2022-04-14 11:53 ` Allen-KH Cheng
  1 sibling, 0 replies; 3+ messages in thread
From: Allen-KH Cheng @ 2022-04-14 11:53 UTC (permalink / raw)
  To: Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier, Rob Herring,
	Matthias Brugger
  Cc: Hsin-Yi Wang, Project_Global_Chrome_Upstream_Group, linux-kernel,
	devicetree, linux-mediatek, linux-arm-kernel, linux-remoteproc,
	Allen-KH Cheng

The SCP firmware blob differs between platforms and SoCs. We add
support in the SCP driver for reading the path of firmware file from
DT in order to allow these files to live in a generic file system
(or linux-firmware).

The firmware-name property is optional and the code falls back to the
old filename if the property isn't present.

Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
 drivers/remoteproc/mtk_scp.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index ee6c4009586e..82813d74e829 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -809,9 +809,14 @@ static int scp_probe(struct platform_device *pdev)
 	struct mtk_scp *scp;
 	struct rproc *rproc;
 	struct resource *res;
-	char *fw_name = "scp.img";
+	const char *fw_name = "scp.img";
 	int ret, i;
 
+	ret = of_property_read_string(pdev->dev.of_node, "firmware-name",
+				      &fw_name);
+	if (ret < 0 && ret != -EINVAL)
+		return ret;
+
 	rproc = devm_rproc_alloc(dev, np->name, &scp_ops, fw_name, sizeof(*scp));
 	if (!rproc)
 		return dev_err_probe(dev, -ENOMEM, "unable to allocate remoteproc\n");
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-14 11:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 11:53 [PATCH 0/2] remoteproc: mediatek: allow different SCP firmware names Allen-KH Cheng
2022-04-14 11:53 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: dd firmware-name property Allen-KH Cheng
2022-04-14 11:53 ` [PATCH 2/2] remoteproc: mediatek: allow reading firmware-name from DT Allen-KH Cheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).