* [PATCH] ixgbe: Fix module_param allow_unsupported_sfp type
@ 2022-04-14 20:21 Jeff Daly
2022-05-02 13:49 ` [Intel-wired-lan] " G, GurucharanX
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Daly @ 2022-04-14 20:21 UTC (permalink / raw)
To: intel-wired-lan
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Jakub Kicinski,
Paolo Abeni, moderated list:INTEL ETHERNET DRIVERS,
open list:NETWORKING DRIVERS, open list
The module_param allow_unsupported_sfp should be a boolean to match the
type in the ixgbe_hw struct.
Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index c4a4954aa317..e5732a058bec 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -151,8 +151,8 @@ MODULE_PARM_DESC(max_vfs,
"Maximum number of virtual functions to allocate per physical function - default is zero and maximum value is 63. (Deprecated)");
#endif /* CONFIG_PCI_IOV */
-static unsigned int allow_unsupported_sfp;
-module_param(allow_unsupported_sfp, uint, 0);
+static bool allow_unsupported_sfp;
+module_param(allow_unsupported_sfp, bool, 0);
MODULE_PARM_DESC(allow_unsupported_sfp,
"Allow unsupported and untested SFP+ modules on 82599-based adapters");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [Intel-wired-lan] [PATCH] ixgbe: Fix module_param allow_unsupported_sfp type
2022-04-14 20:21 [PATCH] ixgbe: Fix module_param allow_unsupported_sfp type Jeff Daly
@ 2022-05-02 13:49 ` G, GurucharanX
0 siblings, 0 replies; 3+ messages in thread
From: G, GurucharanX @ 2022-05-02 13:49 UTC (permalink / raw)
To: Daly, Jeff, intel-wired-lan
Cc: open list:NETWORKING DRIVERS, open list,
moderated list:INTEL ETHERNET DRIVERS, Jakub Kicinski,
Paolo Abeni, David S. Miller
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jeff Daly
> Sent: Friday, April 15, 2022 1:51 AM
> To: intel-wired-lan@osuosl.org
> Cc: open list:NETWORKING DRIVERS <netdev@vger.kernel.org>; open list
> <linux-kernel@vger.kernel.org>; moderated list:INTEL ETHERNET DRIVERS
> <intel-wired-lan@lists.osuosl.org>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH] ixgbe: Fix module_param
> allow_unsupported_sfp type
>
> The module_param allow_unsupported_sfp should be a boolean to match
> the type in the ixgbe_hw struct.
>
> Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ixgbe: Fix module_param allow_unsupported_sfp type
@ 2022-04-14 20:20 Jeff Daly
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Daly @ 2022-04-14 20:20 UTC (permalink / raw)
To: intel-wired-lan
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Jakub Kicinski,
Paolo Abeni, moderated list:INTEL ETHERNET DRIVERS,
open list:NETWORKING DRIVERS, open list
The module_param allow_unsupported_sfp should be a boolean to match the
type in the ixgbe_hw struct.
Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index c4a4954aa317..e5732a058bec 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -151,8 +151,8 @@ MODULE_PARM_DESC(max_vfs,
"Maximum number of virtual functions to allocate per physical function - default is zero and maximum value is 63. (Deprecated)");
#endif /* CONFIG_PCI_IOV */
-static unsigned int allow_unsupported_sfp;
-module_param(allow_unsupported_sfp, uint, 0);
+static bool allow_unsupported_sfp;
+module_param(allow_unsupported_sfp, bool, 0);
MODULE_PARM_DESC(allow_unsupported_sfp,
"Allow unsupported and untested SFP+ modules on 82599-based adapters");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-02 13:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 20:21 [PATCH] ixgbe: Fix module_param allow_unsupported_sfp type Jeff Daly
2022-05-02 13:49 ` [Intel-wired-lan] " G, GurucharanX
-- strict thread matches above, loose matches on Subject: below --
2022-04-14 20:20 Jeff Daly
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).