linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -mmotm] hugetlb: use mm.h instead of mm_types.h
@ 2022-04-21  1:47 Randy Dunlap
  2022-04-21 15:43 ` Peter Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-04-21  1:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Signed-off-by : Peter Xu, Mike Kravetz, linux-mm,
	Andrew Morton

mm_types.h does not have zap_flags_t in it so use mm.h instead
in hugetlb.h.

Fixes this build error:

In file included from ../drivers/virt/nitro_enclaves/ne_misc_dev.c:16:0:
../include/linux/hugetlb.h:414:4: error: unknown type name ‘zap_flags_t’; did you mean ‘vm_flags_t’?
    zap_flags_t zap_flags)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Signed-off-by: Peter Xu <peterx@redhat.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>
---
Fixes: mm-hugetlb-only-drop-uffd-wp-special-pte-if-required-fix.patch

 include/linux/hugetlb.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -2,7 +2,7 @@
 #ifndef _LINUX_HUGETLB_H
 #define _LINUX_HUGETLB_H
 
-#include <linux/mm_types.h>
+#include <linux/mm.h>
 #include <linux/mmdebug.h>
 #include <linux/fs.h>
 #include <linux/hugetlb_inline.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -mmotm] hugetlb: use mm.h instead of mm_types.h
  2022-04-21  1:47 [PATCH -mmotm] hugetlb: use mm.h instead of mm_types.h Randy Dunlap
@ 2022-04-21 15:43 ` Peter Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Xu @ 2022-04-21 15:43 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-kernel, Mike Kravetz, linux-mm, Andrew Morton

On Wed, Apr 20, 2022 at 06:47:23PM -0700, Randy Dunlap wrote:
> mm_types.h does not have zap_flags_t in it so use mm.h instead
> in hugetlb.h.
> 
> Fixes this build error:
> 
> In file included from ../drivers/virt/nitro_enclaves/ne_misc_dev.c:16:0:
> ../include/linux/hugetlb.h:414:4: error: unknown type name ‘zap_flags_t’; did you mean ‘vm_flags_t’?
>     zap_flags_t zap_flags)
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Signed-off-by: Peter Xu <peterx@redhat.com>
      ~~~~~~~~~~~~~~~
            ^
            |
            +-------- could drop these..

> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: linux-mm@kvack.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> Fixes: mm-hugetlb-only-drop-uffd-wp-special-pte-if-required-fix.patch
> 
>  include/linux/hugetlb.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -2,7 +2,7 @@
>  #ifndef _LINUX_HUGETLB_H
>  #define _LINUX_HUGETLB_H
>  
> -#include <linux/mm_types.h>
> +#include <linux/mm.h>
>  #include <linux/mmdebug.h>
>  #include <linux/fs.h>
>  #include <linux/hugetlb_inline.h>
> 

Reviewed-by: Peter Xu <peterx@redhat.com>

Thanks for fixing it,

-- 
Peter Xu


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-21 15:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21  1:47 [PATCH -mmotm] hugetlb: use mm.h instead of mm_types.h Randy Dunlap
2022-04-21 15:43 ` Peter Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).