* [PATCH] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name
@ 2022-04-21 7:35 Vinod Koul
2022-04-21 7:39 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vinod Koul @ 2022-04-21 7:35 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel, Manivannan Sadhasivam
Per DT spec node names should not have underscores (_) in them, so
change can_clock to can-clock.
Fixes: 5c44c564e449 ("arm64: dts: qcom: qrb5165-rb5: Add support for MCP2518FD")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index 845eb7a6bf92..0e63f707b911 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -29,7 +29,7 @@ chosen {
};
/* Fixed crystal oscillator dedicated to MCP2518FD */
- clk40M: can_clock {
+ clk40M: can-clock {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <40000000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name
2022-04-21 7:35 [PATCH] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name Vinod Koul
@ 2022-04-21 7:39 ` Krzysztof Kozlowski
2022-04-21 12:59 ` Manivannan Sadhasivam
2022-04-23 16:03 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-21 7:39 UTC (permalink / raw)
To: Vinod Koul, Bjorn Andersson
Cc: linux-arm-msm, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel, Manivannan Sadhasivam
On 21/04/2022 09:35, Vinod Koul wrote:
> Per DT spec node names should not have underscores (_) in them, so
> change can_clock to can-clock.
>
> Fixes: 5c44c564e449 ("arm64: dts: qcom: qrb5165-rb5: Add support for MCP2518FD")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name
2022-04-21 7:35 [PATCH] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name Vinod Koul
2022-04-21 7:39 ` Krzysztof Kozlowski
@ 2022-04-21 12:59 ` Manivannan Sadhasivam
2022-04-23 16:03 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2022-04-21 12:59 UTC (permalink / raw)
To: Vinod Koul
Cc: Bjorn Andersson, linux-arm-msm, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On Thu, Apr 21, 2022 at 01:05:02PM +0530, Vinod Koul wrote:
> Per DT spec node names should not have underscores (_) in them, so
> change can_clock to can-clock.
>
> Fixes: 5c44c564e449 ("arm64: dts: qcom: qrb5165-rb5: Add support for MCP2518FD")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index 845eb7a6bf92..0e63f707b911 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -29,7 +29,7 @@ chosen {
> };
>
> /* Fixed crystal oscillator dedicated to MCP2518FD */
> - clk40M: can_clock {
> + clk40M: can-clock {
Should the node name be just "clock"?
Thanks,
Mani
> compatible = "fixed-clock";
> #clock-cells = <0>;
> clock-frequency = <40000000>;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: (subset) [PATCH] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name
2022-04-21 7:35 [PATCH] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name Vinod Koul
2022-04-21 7:39 ` Krzysztof Kozlowski
2022-04-21 12:59 ` Manivannan Sadhasivam
@ 2022-04-23 16:03 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-04-23 16:03 UTC (permalink / raw)
To: Vinod Koul
Cc: Manivannan Sadhasivam, Krzysztof Kozlowski, linux-kernel,
devicetree, linux-arm-msm, Rob Herring
On Thu, 21 Apr 2022 13:05:02 +0530, Vinod Koul wrote:
> Per DT spec node names should not have underscores (_) in them, so
> change can_clock to can-clock.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name
commit: 1eae95fb1d696968ca72be3ac8e0d62bb4d8da42
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-23 16:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 7:35 [PATCH] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name Vinod Koul
2022-04-21 7:39 ` Krzysztof Kozlowski
2022-04-21 12:59 ` Manivannan Sadhasivam
2022-04-23 16:03 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).