* [PATCH] ipmi: remove unnecessary type castings
@ 2022-04-21 15:09 Yu Zhe
2022-04-21 16:05 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Yu Zhe @ 2022-04-21 15:09 UTC (permalink / raw)
To: minyard
Cc: openipmi-developer, linux-kernel, kernel-janitors, liqiong, Yu Zhe
remove unnecessary void* type castings.
Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 6 +++---
drivers/char/ipmi/ipmi_ssif.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index c59265146e9c..6e6aee19c39d 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -2296,7 +2296,7 @@ static int i_ipmi_request(struct ipmi_user *user,
recv_msg->user_msg_data = user_msg_data;
if (supplied_smi)
- smi_msg = (struct ipmi_smi_msg *) supplied_smi;
+ smi_msg = supplied_smi;
else {
smi_msg = ipmi_alloc_smi_msg();
if (smi_msg == NULL) {
@@ -3989,7 +3989,7 @@ static int handle_ipmb_direct_rcv_rsp(struct ipmi_smi *intf,
struct ipmi_recv_msg *recv_msg;
struct ipmi_ipmb_direct_addr *daddr;
- recv_msg = (struct ipmi_recv_msg *) msg->user_data;
+ recv_msg = msg->user_data;
if (recv_msg == NULL) {
dev_warn(intf->si_dev,
"IPMI message received with no owner. This could be because of a malformed message, or because of a hardware error. Contact your hardware vendor for assistance.\n");
@@ -4407,7 +4407,7 @@ static int handle_bmc_rsp(struct ipmi_smi *intf,
struct ipmi_recv_msg *recv_msg;
struct ipmi_system_interface_addr *smi_addr;
- recv_msg = (struct ipmi_recv_msg *) msg->user_data;
+ recv_msg = msg->user_data;
if (recv_msg == NULL) {
dev_warn(intf->si_dev,
"IPMI message received with no owner. This could be because of a malformed message, or because of a hardware error. Contact your hardware vendor for assistance.\n");
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index f199cc194844..e8ee195a33cf 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1053,7 +1053,7 @@ static void start_next_msg(struct ssif_info *ssif_info, unsigned long *flags)
static void sender(void *send_info,
struct ipmi_smi_msg *msg)
{
- struct ssif_info *ssif_info = (struct ssif_info *) send_info;
+ struct ssif_info *ssif_info = send_info;
unsigned long oflags, *flags;
BUG_ON(ssif_info->waiting_msg);
@@ -1090,7 +1090,7 @@ static int get_smi_info(void *send_info, struct ipmi_smi_info *data)
*/
static void request_events(void *send_info)
{
- struct ssif_info *ssif_info = (struct ssif_info *) send_info;
+ struct ssif_info *ssif_info = send_info;
unsigned long oflags, *flags;
if (!ssif_info->has_event_buffer)
@@ -1107,7 +1107,7 @@ static void request_events(void *send_info)
*/
static void ssif_set_need_watch(void *send_info, unsigned int watch_mask)
{
- struct ssif_info *ssif_info = (struct ssif_info *) send_info;
+ struct ssif_info *ssif_info = send_info;
unsigned long oflags, *flags;
long timeout = 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipmi: remove unnecessary type castings
2022-04-21 15:09 [PATCH] ipmi: remove unnecessary type castings Yu Zhe
@ 2022-04-21 16:05 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2022-04-21 16:05 UTC (permalink / raw)
To: Yu Zhe; +Cc: openipmi-developer, linux-kernel, kernel-janitors, liqiong
On Thu, Apr 21, 2022 at 08:09:41AM -0700, Yu Zhe wrote:
> remove unnecessary void* type castings.
Thanks, queued for next release.
-corey
>
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 6 +++---
> drivers/char/ipmi/ipmi_ssif.c | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index c59265146e9c..6e6aee19c39d 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -2296,7 +2296,7 @@ static int i_ipmi_request(struct ipmi_user *user,
> recv_msg->user_msg_data = user_msg_data;
>
> if (supplied_smi)
> - smi_msg = (struct ipmi_smi_msg *) supplied_smi;
> + smi_msg = supplied_smi;
> else {
> smi_msg = ipmi_alloc_smi_msg();
> if (smi_msg == NULL) {
> @@ -3989,7 +3989,7 @@ static int handle_ipmb_direct_rcv_rsp(struct ipmi_smi *intf,
> struct ipmi_recv_msg *recv_msg;
> struct ipmi_ipmb_direct_addr *daddr;
>
> - recv_msg = (struct ipmi_recv_msg *) msg->user_data;
> + recv_msg = msg->user_data;
> if (recv_msg == NULL) {
> dev_warn(intf->si_dev,
> "IPMI message received with no owner. This could be because of a malformed message, or because of a hardware error. Contact your hardware vendor for assistance.\n");
> @@ -4407,7 +4407,7 @@ static int handle_bmc_rsp(struct ipmi_smi *intf,
> struct ipmi_recv_msg *recv_msg;
> struct ipmi_system_interface_addr *smi_addr;
>
> - recv_msg = (struct ipmi_recv_msg *) msg->user_data;
> + recv_msg = msg->user_data;
> if (recv_msg == NULL) {
> dev_warn(intf->si_dev,
> "IPMI message received with no owner. This could be because of a malformed message, or because of a hardware error. Contact your hardware vendor for assistance.\n");
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index f199cc194844..e8ee195a33cf 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1053,7 +1053,7 @@ static void start_next_msg(struct ssif_info *ssif_info, unsigned long *flags)
> static void sender(void *send_info,
> struct ipmi_smi_msg *msg)
> {
> - struct ssif_info *ssif_info = (struct ssif_info *) send_info;
> + struct ssif_info *ssif_info = send_info;
> unsigned long oflags, *flags;
>
> BUG_ON(ssif_info->waiting_msg);
> @@ -1090,7 +1090,7 @@ static int get_smi_info(void *send_info, struct ipmi_smi_info *data)
> */
> static void request_events(void *send_info)
> {
> - struct ssif_info *ssif_info = (struct ssif_info *) send_info;
> + struct ssif_info *ssif_info = send_info;
> unsigned long oflags, *flags;
>
> if (!ssif_info->has_event_buffer)
> @@ -1107,7 +1107,7 @@ static void request_events(void *send_info)
> */
> static void ssif_set_need_watch(void *send_info, unsigned int watch_mask)
> {
> - struct ssif_info *ssif_info = (struct ssif_info *) send_info;
> + struct ssif_info *ssif_info = send_info;
> unsigned long oflags, *flags;
> long timeout = 0;
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-21 16:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 15:09 [PATCH] ipmi: remove unnecessary type castings Yu Zhe
2022-04-21 16:05 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).