* [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting
@ 2022-04-21 20:30 Jiapeng Chong
2022-04-30 13:09 ` Heiko Stuebner
2022-05-02 7:02 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2022-04-21 20:30 UTC (permalink / raw)
To: kishon
Cc: vkoul, heiko, linux-phy, linux-arm-kernel, linux-rockchip,
linux-kernel, Jiapeng Chong, Abaci Robot
Eliminate the follow smatch warning:
drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
rockchip_usb2phy_probe() warn: inconsistent indenting.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index e377b958d9b6..6711659f727c 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@ -1200,8 +1200,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
else {
rphy->grf = syscon_node_to_regmap(dev->parent->of_node);
- if (IS_ERR(rphy->grf))
- return PTR_ERR(rphy->grf);
+ if (IS_ERR(rphy->grf))
+ return PTR_ERR(rphy->grf);
}
if (of_device_is_compatible(np, "rockchip,rv1108-usb2phy")) {
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting
2022-04-21 20:30 [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting Jiapeng Chong
@ 2022-04-30 13:09 ` Heiko Stuebner
2022-05-02 7:02 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2022-04-30 13:09 UTC (permalink / raw)
To: kishon, Jiapeng Chong
Cc: vkoul, linux-phy, linux-arm-kernel, linux-rockchip, linux-kernel,
Jiapeng Chong, Abaci Robot
Am Donnerstag, 21. April 2022, 22:30:38 CEST schrieb Jiapeng Chong:
> Eliminate the follow smatch warning:
>
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
> rockchip_usb2phy_probe() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> index e377b958d9b6..6711659f727c 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -1200,8 +1200,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
>
> else {
> rphy->grf = syscon_node_to_regmap(dev->parent->of_node);
> - if (IS_ERR(rphy->grf))
> - return PTR_ERR(rphy->grf);
> + if (IS_ERR(rphy->grf))
> + return PTR_ERR(rphy->grf);
> }
>
> if (of_device_is_compatible(np, "rockchip,rv1108-usb2phy")) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting
2022-04-21 20:30 [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting Jiapeng Chong
2022-04-30 13:09 ` Heiko Stuebner
@ 2022-05-02 7:02 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-05-02 7:02 UTC (permalink / raw)
To: Jiapeng Chong
Cc: kishon, heiko, linux-phy, linux-arm-kernel, linux-rockchip,
linux-kernel, Abaci Robot
On 22-04-22, 04:30, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
> rockchip_usb2phy_probe() warn: inconsistent indenting.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-02 7:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 20:30 [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting Jiapeng Chong
2022-04-30 13:09 ` Heiko Stuebner
2022-05-02 7:02 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).