* [PATCH v2 0/6] dmaengine/ARM: use proper 'dma-channels/requests' properties
@ 2022-04-27 16:11 Krzysztof Kozlowski
2022-04-27 16:11 ` [PATCH v2 1/6] dt-bindings: usb: am33xx-usb: deprecate '#dma-channels' Krzysztof Kozlowski
` (5 more replies)
0 siblings, 6 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:11 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Benoît Cousson, Tony Lindgren, Sekhar Nori,
Bartosz Golaszewski, Vinod Koul, linux-usb, devicetree,
linux-kernel, linux-omap, linux-arm-kernel, dmaengine
Cc: Krzysztof Kozlowski
Hi,
The core DT schema defines generic 'dma-channels' and 'dma-requests'
properties, so in preparation to moving bindings to DT schema, convert
existing users of '#dma-channels' and '#dma-requests' to the generic
variant.
Not tested on hardware.
IMPORTANT
=========
The patchset is not bisectable! The DTS patches should be applied a
release *after* driver change is accepted.
Changes since v1
================
1. Add missing TI patches.
See also:
[1] https://lore.kernel.org/linux-devicetree/fedb56be-f275-aabb-cdf5-dbd394b8a7bd@linaro.org/T/#m6235f451045c337d70a62dc65eab9a716618550b
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 1/6] dt-bindings: usb: am33xx-usb: deprecate '#dma-channels'
2022-04-27 16:11 [PATCH v2 0/6] dmaengine/ARM: use proper 'dma-channels/requests' properties Krzysztof Kozlowski
@ 2022-04-27 16:11 ` Krzysztof Kozlowski
2022-04-27 18:20 ` Rob Herring
2022-04-27 16:11 ` [PATCH v2 2/6] dt-bindings: usb: da8xx-usb: " Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:11 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Benoît Cousson, Tony Lindgren, Sekhar Nori,
Bartosz Golaszewski, Vinod Koul, linux-usb, devicetree,
linux-kernel, linux-omap, linux-arm-kernel, dmaengine
Cc: Krzysztof Kozlowski
The generic property, used in most of the drivers and defined in generic
dma-common DT bindings, is 'dma-channels'.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/usb/am33xx-usb.txt | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/am33xx-usb.txt b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
index 7a198a30408a..654ffc62d013 100644
--- a/Documentation/devicetree/bindings/usb/am33xx-usb.txt
+++ b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
@@ -61,8 +61,9 @@ DMA
endpoint number (0 … 14 for endpoints 1 … 15 on instance 0 and 15 … 29
for endpoints 1 … 15 on instance 1). The second number is 0 for RX and
1 for TX transfers.
-- #dma-channels: should be set to 30 representing the 15 endpoints for
+- dma-channels: should be set to 30 representing the 15 endpoints for
each USB instance.
+- #dma-channels: deprecated
Example:
~~~~~~~~
@@ -193,7 +194,7 @@ usb: usb@47400000 {
interrupts = <17>;
interrupt-names = "glue";
#dma-cells = <2>;
- #dma-channels = <30>;
- #dma-requests = <256>;
+ dma-channels = <30>;
+ dma-requests = <256>;
};
};
--
2.32.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 2/6] dt-bindings: usb: da8xx-usb: deprecate '#dma-channels'
2022-04-27 16:11 [PATCH v2 0/6] dmaengine/ARM: use proper 'dma-channels/requests' properties Krzysztof Kozlowski
2022-04-27 16:11 ` [PATCH v2 1/6] dt-bindings: usb: am33xx-usb: deprecate '#dma-channels' Krzysztof Kozlowski
@ 2022-04-27 16:11 ` Krzysztof Kozlowski
2022-04-27 18:21 ` Rob Herring
2022-04-27 16:11 ` [PATCH v2 3/6] dmaengine: ti: " Krzysztof Kozlowski
` (3 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:11 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Benoît Cousson, Tony Lindgren, Sekhar Nori,
Bartosz Golaszewski, Vinod Koul, linux-usb, devicetree,
linux-kernel, linux-omap, linux-arm-kernel, dmaengine
Cc: Krzysztof Kozlowski
The generic property, used in most of the drivers and defined in generic
dma-common DT bindings, is 'dma-channels'.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/usb/da8xx-usb.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
index 9ce22551b2b3..fb2027a7d80d 100644
--- a/Documentation/devicetree/bindings/usb/da8xx-usb.txt
+++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt
@@ -36,7 +36,8 @@ DMA
- #dma-cells: should be set to 2. The first number represents the
channel number (0 … 3 for endpoints 1 … 4).
The second number is 0 for RX and 1 for TX transfers.
-- #dma-channels: should be set to 4 representing the 4 endpoints.
+- dma-channels: should be set to 4 representing the 4 endpoints.
+- #dma-channels: deprecated
Example:
usb_phy: usb-phy {
@@ -74,7 +75,7 @@ Example:
reg-names = "controller", "scheduler", "queuemgr";
interrupts = <58>;
#dma-cells = <2>;
- #dma-channels = <4>;
+ dma-channels = <4>;
};
};
--
2.32.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 3/6] dmaengine: ti: deprecate '#dma-channels'
2022-04-27 16:11 [PATCH v2 0/6] dmaengine/ARM: use proper 'dma-channels/requests' properties Krzysztof Kozlowski
2022-04-27 16:11 ` [PATCH v2 1/6] dt-bindings: usb: am33xx-usb: deprecate '#dma-channels' Krzysztof Kozlowski
2022-04-27 16:11 ` [PATCH v2 2/6] dt-bindings: usb: da8xx-usb: " Krzysztof Kozlowski
@ 2022-04-27 16:11 ` Krzysztof Kozlowski
2022-04-28 7:31 ` Tony Lindgren
2022-05-19 17:28 ` Vinod Koul
2022-04-27 16:11 ` [PATCH v2 4/6] ARM: dts: am33xx: use new 'dma-channels/requests' properties Krzysztof Kozlowski
` (2 subsequent siblings)
5 siblings, 2 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:11 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Benoît Cousson, Tony Lindgren, Sekhar Nori,
Bartosz Golaszewski, Vinod Koul, linux-usb, devicetree,
linux-kernel, linux-omap, linux-arm-kernel, dmaengine
Cc: Krzysztof Kozlowski
The generic property, used in most of the drivers and defined in generic
dma-common DT bindings, is 'dma-channels'. Switch to new property while
keeping backward compatibility.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/dma/ti/cppi41.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/ti/cppi41.c b/drivers/dma/ti/cppi41.c
index 062bd9bd4de0..695915dba707 100644
--- a/drivers/dma/ti/cppi41.c
+++ b/drivers/dma/ti/cppi41.c
@@ -1105,8 +1105,12 @@ static int cppi41_dma_probe(struct platform_device *pdev)
cdd->qmgr_num_pend = glue_info->qmgr_num_pend;
cdd->first_completion_queue = glue_info->first_completion_queue;
+ /* Parse new and deprecated dma-channels properties */
ret = of_property_read_u32(dev->of_node,
- "#dma-channels", &cdd->n_chans);
+ "dma-channels", &cdd->n_chans);
+ if (ret)
+ ret = of_property_read_u32(dev->of_node,
+ "#dma-channels", &cdd->n_chans);
if (ret)
goto err_get_n_chans;
--
2.32.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 4/6] ARM: dts: am33xx: use new 'dma-channels/requests' properties
2022-04-27 16:11 [PATCH v2 0/6] dmaengine/ARM: use proper 'dma-channels/requests' properties Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-04-27 16:11 ` [PATCH v2 3/6] dmaengine: ti: " Krzysztof Kozlowski
@ 2022-04-27 16:11 ` Krzysztof Kozlowski
2022-04-27 18:20 ` Rob Herring
2022-04-27 16:13 ` [PATCH v2 5/6] ARM: dts: da850: use new 'dma-channels' property Krzysztof Kozlowski
2022-04-27 16:13 ` [PATCH v2 6/6] ARM: dts: dm81xx: use new 'dma-channels/requests' properties Krzysztof Kozlowski
5 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:11 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Benoît Cousson, Tony Lindgren, Sekhar Nori,
Bartosz Golaszewski, Vinod Koul, linux-usb, devicetree,
linux-kernel, linux-omap, linux-arm-kernel, dmaengine
Cc: Krzysztof Kozlowski
The '#dma-channels' and '#dma-requests' properties were deprecated in
favor of these defined by generic dma-common DT bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/am33xx.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index f6ec85d58dd1..55ffb0813ded 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -461,8 +461,8 @@ cppi41dma: dma-controller@2000 {
interrupts = <17>;
interrupt-names = "glue";
#dma-cells = <2>;
- #dma-channels = <30>;
- #dma-requests = <256>;
+ dma-channels = <30>;
+ dma-requests = <256>;
};
};
--
2.32.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 5/6] ARM: dts: da850: use new 'dma-channels' property
2022-04-27 16:11 [PATCH v2 0/6] dmaengine/ARM: use proper 'dma-channels/requests' properties Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-04-27 16:11 ` [PATCH v2 4/6] ARM: dts: am33xx: use new 'dma-channels/requests' properties Krzysztof Kozlowski
@ 2022-04-27 16:13 ` Krzysztof Kozlowski
2022-04-27 16:13 ` [PATCH v2 6/6] ARM: dts: dm81xx: use new 'dma-channels/requests' properties Krzysztof Kozlowski
5 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:13 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Benoît Cousson, Tony Lindgren, Sekhar Nori,
Bartosz Golaszewski, Vinod Koul, linux-usb, devicetree,
linux-kernel, linux-omap, linux-arm-kernel, dmaengine
Cc: Krzysztof Kozlowski
The '#dma-channels' property was deprecated in favor of one defined by
generic dma-common DT bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/da850.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index c3942b4e82ad..0e8b42a95ba4 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -679,7 +679,7 @@ cppi41dma: dma-controller@201000 {
"scheduler", "queuemgr";
interrupts = <58>;
#dma-cells = <2>;
- #dma-channels = <4>;
+ dma-channels = <4>;
power-domains = <&psc1 1>;
status = "okay";
};
--
2.32.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 6/6] ARM: dts: dm81xx: use new 'dma-channels/requests' properties
2022-04-27 16:11 [PATCH v2 0/6] dmaengine/ARM: use proper 'dma-channels/requests' properties Krzysztof Kozlowski
` (4 preceding siblings ...)
2022-04-27 16:13 ` [PATCH v2 5/6] ARM: dts: da850: use new 'dma-channels' property Krzysztof Kozlowski
@ 2022-04-27 16:13 ` Krzysztof Kozlowski
5 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:13 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Benoît Cousson, Tony Lindgren, Sekhar Nori,
Bartosz Golaszewski, Vinod Koul, linux-usb, devicetree,
linux-kernel, linux-omap, linux-arm-kernel, dmaengine
Cc: Krzysztof Kozlowski
The '#dma-channels' and '#dma-requests' properties were deprecated in
favor of these defined by generic dma-common DT bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/dm814x.dtsi | 4 ++--
arch/arm/boot/dts/dm816x.dtsi | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/dm814x.dtsi b/arch/arm/boot/dts/dm814x.dtsi
index 7702e048e110..ab2572482ba9 100644
--- a/arch/arm/boot/dts/dm814x.dtsi
+++ b/arch/arm/boot/dts/dm814x.dtsi
@@ -167,8 +167,8 @@ cppi41dma: dma-controller@47402000 {
interrupts = <17>;
interrupt-names = "glue";
#dma-cells = <2>;
- #dma-channels = <30>;
- #dma-requests = <256>;
+ dma-channels = <30>;
+ dma-requests = <256>;
};
};
diff --git a/arch/arm/boot/dts/dm816x.dtsi b/arch/arm/boot/dts/dm816x.dtsi
index a9e7274806f4..317b7c74e32c 100644
--- a/arch/arm/boot/dts/dm816x.dtsi
+++ b/arch/arm/boot/dts/dm816x.dtsi
@@ -655,8 +655,8 @@ cppi41dma: dma-controller@47402000 {
interrupts = <17>;
interrupt-names = "glue";
#dma-cells = <2>;
- #dma-channels = <30>;
- #dma-requests = <256>;
+ dma-channels = <30>;
+ dma-requests = <256>;
};
};
--
2.32.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v2 4/6] ARM: dts: am33xx: use new 'dma-channels/requests' properties
2022-04-27 16:11 ` [PATCH v2 4/6] ARM: dts: am33xx: use new 'dma-channels/requests' properties Krzysztof Kozlowski
@ 2022-04-27 18:20 ` Rob Herring
2022-04-27 19:26 ` Krzysztof Kozlowski
0 siblings, 1 reply; 15+ messages in thread
From: Rob Herring @ 2022-04-27 18:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Krzysztof Kozlowski, Benoît Cousson,
Tony Lindgren, Sekhar Nori, Bartosz Golaszewski, Vinod Koul,
linux-usb, devicetree, linux-kernel, linux-omap,
linux-arm-kernel, dmaengine
On Wed, Apr 27, 2022 at 06:11:24PM +0200, Krzysztof Kozlowski wrote:
> The '#dma-channels' and '#dma-requests' properties were deprecated in
> favor of these defined by generic dma-common DT bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index f6ec85d58dd1..55ffb0813ded 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -461,8 +461,8 @@ cppi41dma: dma-controller@2000 {
> interrupts = <17>;
> interrupt-names = "glue";
> #dma-cells = <2>;
> - #dma-channels = <30>;
> - #dma-requests = <256>;
> + dma-channels = <30>;
> + dma-requests = <256>;
You could keep the old properties for compatibility and to apply
immediately.
> };
> };
>
> --
> 2.32.0
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/6] dt-bindings: usb: am33xx-usb: deprecate '#dma-channels'
2022-04-27 16:11 ` [PATCH v2 1/6] dt-bindings: usb: am33xx-usb: deprecate '#dma-channels' Krzysztof Kozlowski
@ 2022-04-27 18:20 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2022-04-27 18:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, linux-omap, Tony Lindgren, devicetree, Vinod Koul,
linux-usb, linux-arm-kernel, dmaengine, Rob Herring, Sekhar Nori,
Krzysztof Kozlowski, Bartosz Golaszewski, Benoît Cousson,
Greg Kroah-Hartman
On Wed, 27 Apr 2022 18:11:21 +0200, Krzysztof Kozlowski wrote:
> The generic property, used in most of the drivers and defined in generic
> dma-common DT bindings, is 'dma-channels'.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/usb/am33xx-usb.txt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 2/6] dt-bindings: usb: da8xx-usb: deprecate '#dma-channels'
2022-04-27 16:11 ` [PATCH v2 2/6] dt-bindings: usb: da8xx-usb: " Krzysztof Kozlowski
@ 2022-04-27 18:21 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2022-04-27 18:21 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-omap, Greg Kroah-Hartman, Rob Herring, linux-arm-kernel,
dmaengine, Bartosz Golaszewski, Krzysztof Kozlowski, devicetree,
linux-usb, Tony Lindgren, Sekhar Nori, Benoît Cousson,
linux-kernel, Vinod Koul
On Wed, 27 Apr 2022 18:11:22 +0200, Krzysztof Kozlowski wrote:
> The generic property, used in most of the drivers and defined in generic
> dma-common DT bindings, is 'dma-channels'.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/usb/da8xx-usb.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 4/6] ARM: dts: am33xx: use new 'dma-channels/requests' properties
2022-04-27 18:20 ` Rob Herring
@ 2022-04-27 19:26 ` Krzysztof Kozlowski
2022-04-28 7:30 ` Tony Lindgren
0 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 19:26 UTC (permalink / raw)
To: Rob Herring
Cc: Greg Kroah-Hartman, Benoît Cousson, Tony Lindgren,
Sekhar Nori, Bartosz Golaszewski, Vinod Koul, linux-usb,
devicetree, linux-kernel, linux-omap, linux-arm-kernel,
dmaengine
On Wed, 27 Apr 2022 at 20:20, Rob Herring <robh@kernel.org> wrote:
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index f6ec85d58dd1..55ffb0813ded 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -461,8 +461,8 @@ cppi41dma: dma-controller@2000 {
> > interrupts = <17>;
> > interrupt-names = "glue";
> > #dma-cells = <2>;
> > - #dma-channels = <30>;
> > - #dma-requests = <256>;
> > + dma-channels = <30>;
> > + dma-requests = <256>;
>
> You could keep the old properties for compatibility and to apply
> immediately.
Indeed, that's a nice solution. Any preference from TI SoC maintainers?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 4/6] ARM: dts: am33xx: use new 'dma-channels/requests' properties
2022-04-27 19:26 ` Krzysztof Kozlowski
@ 2022-04-28 7:30 ` Tony Lindgren
2022-04-28 7:33 ` Krzysztof Kozlowski
0 siblings, 1 reply; 15+ messages in thread
From: Tony Lindgren @ 2022-04-28 7:30 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Greg Kroah-Hartman, Benoît Cousson,
Sekhar Nori, Bartosz Golaszewski, Vinod Koul, linux-usb,
devicetree, linux-kernel, linux-omap, linux-arm-kernel,
dmaengine
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [220427 19:23]:
> On Wed, 27 Apr 2022 at 20:20, Rob Herring <robh@kernel.org> wrote:
> > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > > index f6ec85d58dd1..55ffb0813ded 100644
> > > --- a/arch/arm/boot/dts/am33xx.dtsi
> > > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > > @@ -461,8 +461,8 @@ cppi41dma: dma-controller@2000 {
> > > interrupts = <17>;
> > > interrupt-names = "glue";
> > > #dma-cells = <2>;
> > > - #dma-channels = <30>;
> > > - #dma-requests = <256>;
> > > + dma-channels = <30>;
> > > + dma-requests = <256>;
> >
> > You could keep the old properties for compatibility and to apply
> > immediately.
>
> Indeed, that's a nice solution. Any preference from TI SoC maintainers?
Makes sense to me to avoid dependencies.
Regards,
Tony
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 3/6] dmaengine: ti: deprecate '#dma-channels'
2022-04-27 16:11 ` [PATCH v2 3/6] dmaengine: ti: " Krzysztof Kozlowski
@ 2022-04-28 7:31 ` Tony Lindgren
2022-05-19 17:28 ` Vinod Koul
1 sibling, 0 replies; 15+ messages in thread
From: Tony Lindgren @ 2022-04-28 7:31 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Benoît Cousson, Sekhar Nori, Bartosz Golaszewski,
Vinod Koul, linux-usb, devicetree, linux-kernel, linux-omap,
linux-arm-kernel, dmaengine
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [220427 16:08]:
> The generic property, used in most of the drivers and defined in generic
> dma-common DT bindings, is 'dma-channels'. Switch to new property while
> keeping backward compatibility.
Looks good to me:
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 4/6] ARM: dts: am33xx: use new 'dma-channels/requests' properties
2022-04-28 7:30 ` Tony Lindgren
@ 2022-04-28 7:33 ` Krzysztof Kozlowski
0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-28 7:33 UTC (permalink / raw)
To: Tony Lindgren
Cc: Rob Herring, Greg Kroah-Hartman, Benoît Cousson,
Sekhar Nori, Bartosz Golaszewski, Vinod Koul, linux-usb,
devicetree, linux-kernel, linux-omap, linux-arm-kernel,
dmaengine
On 28/04/2022 09:30, Tony Lindgren wrote:
> * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [220427 19:23]:
>> On Wed, 27 Apr 2022 at 20:20, Rob Herring <robh@kernel.org> wrote:
>>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>>>> index f6ec85d58dd1..55ffb0813ded 100644
>>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>>> @@ -461,8 +461,8 @@ cppi41dma: dma-controller@2000 {
>>>> interrupts = <17>;
>>>> interrupt-names = "glue";
>>>> #dma-cells = <2>;
>>>> - #dma-channels = <30>;
>>>> - #dma-requests = <256>;
>>>> + dma-channels = <30>;
>>>> + dma-requests = <256>;
>>>
>>> You could keep the old properties for compatibility and to apply
>>> immediately.
>>
>> Indeed, that's a nice solution. Any preference from TI SoC maintainers?
>
> Makes sense to me to avoid dependencies.
Thanks. I will send a v3 today with such change.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 3/6] dmaengine: ti: deprecate '#dma-channels'
2022-04-27 16:11 ` [PATCH v2 3/6] dmaengine: ti: " Krzysztof Kozlowski
2022-04-28 7:31 ` Tony Lindgren
@ 2022-05-19 17:28 ` Vinod Koul
1 sibling, 0 replies; 15+ messages in thread
From: Vinod Koul @ 2022-05-19 17:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Benoît Cousson, Tony Lindgren, Sekhar Nori,
Bartosz Golaszewski, linux-usb, devicetree, linux-kernel,
linux-omap, linux-arm-kernel, dmaengine
On 27-04-22, 18:11, Krzysztof Kozlowski wrote:
> The generic property, used in most of the drivers and defined in generic
> dma-common DT bindings, is 'dma-channels'. Switch to new property while
> keeping backward compatibility.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-05-19 17:30 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 16:11 [PATCH v2 0/6] dmaengine/ARM: use proper 'dma-channels/requests' properties Krzysztof Kozlowski
2022-04-27 16:11 ` [PATCH v2 1/6] dt-bindings: usb: am33xx-usb: deprecate '#dma-channels' Krzysztof Kozlowski
2022-04-27 18:20 ` Rob Herring
2022-04-27 16:11 ` [PATCH v2 2/6] dt-bindings: usb: da8xx-usb: " Krzysztof Kozlowski
2022-04-27 18:21 ` Rob Herring
2022-04-27 16:11 ` [PATCH v2 3/6] dmaengine: ti: " Krzysztof Kozlowski
2022-04-28 7:31 ` Tony Lindgren
2022-05-19 17:28 ` Vinod Koul
2022-04-27 16:11 ` [PATCH v2 4/6] ARM: dts: am33xx: use new 'dma-channels/requests' properties Krzysztof Kozlowski
2022-04-27 18:20 ` Rob Herring
2022-04-27 19:26 ` Krzysztof Kozlowski
2022-04-28 7:30 ` Tony Lindgren
2022-04-28 7:33 ` Krzysztof Kozlowski
2022-04-27 16:13 ` [PATCH v2 5/6] ARM: dts: da850: use new 'dma-channels' property Krzysztof Kozlowski
2022-04-27 16:13 ` [PATCH v2 6/6] ARM: dts: dm81xx: use new 'dma-channels/requests' properties Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).