From: Herve Codina <herve.codina@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Clement Leger" <clement.leger@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v3 2/8] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032
Date: Thu, 28 Apr 2022 11:08:17 +0200 [thread overview]
Message-ID: <20220428110817.07ce92a6@bootlin.com> (raw)
In-Reply-To: <CAMuHMdVB2-Sv1AWFr43erOioui0me5A4TfvazKHp9hTF3gJCwg@mail.gmail.com>
Hi Geert,
On Wed, 27 Apr 2022 17:15:15 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Hervé,
>
> On Fri, Apr 22, 2022 at 2:09 PM Herve Codina <herve.codina@bootlin.com> wrote:
> > Add internal PCI bridge support for the r9a06g032 SOC. The Renesas
> > RZ/N1D (R9A06G032) internal PCI bridge is compatible with the one
> > present in the R-Car Gen2 family.
> > Compared to the R-Car Gen2 family, it needs three clocks instead of
> > one.
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml
> > +++ b/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml
> > @@ -113,6 +113,37 @@ required:
> > - "#size-cells"
> > - "#interrupt-cells"
> >
> > +if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - renesas,pci-rzn1
> > +
> > +then:
> > + properties:
> > + clocks:
> > + items:
> > + - description: Internal bus clock (AHB) for HOST
> > + - description: Internal bus clock (AHB) Power Management
> > + - description: PCI clock for USB subsystem
> > + clock-names:
> > + items:
> > + - const: hclk_usbh
> > + - const: hclk_usbpm
> > + - const: clk_pci_usb
>
> These are the provider names.
> I think they should use the consumer names: usb_hclkh, usb_hclkpm,
> and usb_pciclk.
Yes, it makes sense.
I will changed in v4.
>
> The rest looks good to me.
Perfect.
Thanks for the review,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-04-28 9:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 12:08 [PATCH v3 0/8] RZN1 USB Host support Herve Codina
2022-04-22 12:08 ` [PATCH v3 1/8] dt-bindings: PCI: pci-rcar-gen2: Convert bindings to json-schema Herve Codina
2022-04-26 0:45 ` Rob Herring
2022-04-26 0:47 ` Rob Herring
2022-04-27 15:05 ` Geert Uytterhoeven
2022-04-22 12:08 ` [PATCH v3 2/8] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032 Herve Codina
2022-04-26 0:46 ` Rob Herring
2022-04-27 15:15 ` Geert Uytterhoeven
2022-04-28 9:08 ` Herve Codina [this message]
2022-04-22 12:08 ` [PATCH v3 3/8] PCI: rcar-gen2: Add RZ/N1 SOCs support Herve Codina
2022-04-22 16:47 ` Bjorn Helgaas
2022-04-28 9:19 ` Herve Codina
2022-04-22 12:08 ` [PATCH v3 4/8] soc: renesas: rzn1: Select PM and PM_GENERIC_DOMAINS configs Herve Codina
2022-04-27 14:58 ` Geert Uytterhoeven
2022-04-28 9:15 ` Herve Codina
2022-04-28 9:22 ` Geert Uytterhoeven
2022-04-28 9:25 ` Herve Codina
2022-04-22 12:08 ` [PATCH v3 5/8] ARM: dts: r9a06g032: Add missing '#power-domain-cells' Herve Codina
2022-04-27 14:59 ` Geert Uytterhoeven
2022-04-22 12:08 ` [PATCH v3 6/8] ARM: dts: r9a06g032: Add internal PCI bridge node Herve Codina
2022-04-28 9:49 ` Geert Uytterhoeven
2022-04-28 9:50 ` Geert Uytterhoeven
2022-04-28 10:08 ` Herve Codina
2022-04-28 10:07 ` Herve Codina
2022-04-22 12:08 ` [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support Herve Codina
2022-04-23 9:09 ` Sergey Shtylyov
2022-04-23 16:41 ` Sergey Shtylyov
2022-04-28 9:23 ` Herve Codina
2022-04-28 9:51 ` Geert Uytterhoeven
2022-04-28 10:30 ` Herve Codina
2022-04-22 12:08 ` [PATCH v3 8/8] ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY Herve Codina
2022-04-28 9:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428110817.07ce92a6@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=bhelgaas@google.com \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=thomas.petazzoni@bootlin.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).