* [PATCH 0/2] Support MediaTek devapc for MT8186
@ 2022-04-29 6:54 Rex-BC Chen
2022-04-29 6:54 ` [PATCH 1/2] dt-bindings: soc: mediatek: devapc: Add bindings " Rex-BC Chen
2022-04-29 6:54 ` [PATCH 2/2] soc: mediatek: devapc: Add support " Rex-BC Chen
0 siblings, 2 replies; 8+ messages in thread
From: Rex-BC Chen @ 2022-04-29 6:54 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, matthias.bgg
Cc: neal.liu, runyang.chen, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
Rex-BC Chen
This series is for supporting devapc implementation in MT8186.
V1:
- Add dt-binding and add devapc data for MT8186.
Rex-BC Chen (2):
dt-bindings: soc: mediatek: devapc: Add bindings for MT8186
soc: mediatek: devapc: Add support for MT8186
.../devicetree/bindings/soc/mediatek/devapc.yaml | 1 +
drivers/soc/mediatek/mtk-devapc.c | 15 +++++++++++++++
2 files changed, 16 insertions(+)
--
2.18.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: soc: mediatek: devapc: Add bindings for MT8186
2022-04-29 6:54 [PATCH 0/2] Support MediaTek devapc for MT8186 Rex-BC Chen
@ 2022-04-29 6:54 ` Rex-BC Chen
2022-04-29 21:00 ` Krzysztof Kozlowski
2022-05-04 9:36 ` AngeloGioacchino Del Regno
2022-04-29 6:54 ` [PATCH 2/2] soc: mediatek: devapc: Add support " Rex-BC Chen
1 sibling, 2 replies; 8+ messages in thread
From: Rex-BC Chen @ 2022-04-29 6:54 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, matthias.bgg
Cc: neal.liu, runyang.chen, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
Rex-BC Chen
Add the dt-binding to support MT8186 devapc.
Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
---
Documentation/devicetree/bindings/soc/mediatek/devapc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml b/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
index 31e4d3c339bf..d0a4bc3b03e9 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
@@ -20,6 +20,7 @@ properties:
compatible:
enum:
- mediatek,mt6779-devapc
+ - mediatek,mt8186-devapc
reg:
description: The base address of devapc register bank
--
2.18.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] soc: mediatek: devapc: Add support for MT8186
2022-04-29 6:54 [PATCH 0/2] Support MediaTek devapc for MT8186 Rex-BC Chen
2022-04-29 6:54 ` [PATCH 1/2] dt-bindings: soc: mediatek: devapc: Add bindings " Rex-BC Chen
@ 2022-04-29 6:54 ` Rex-BC Chen
2022-05-04 9:34 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 8+ messages in thread
From: Rex-BC Chen @ 2022-04-29 6:54 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, matthias.bgg
Cc: neal.liu, runyang.chen, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
Rex-BC Chen
Add devapc data and compatible to support MT8186 devapc.
Signed-off-by: Runyang Chen <runyang.chen@mediatek.com>
Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
---
drivers/soc/mediatek/mtk-devapc.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-devapc.c
index 7c65ad3d1f8a..762e0e4d967d 100644
--- a/drivers/soc/mediatek/mtk-devapc.c
+++ b/drivers/soc/mediatek/mtk-devapc.c
@@ -227,10 +227,25 @@ static const struct mtk_devapc_data devapc_mt6779 = {
.vio_shift_con_offset = 0xF20,
};
+static const struct mtk_devapc_data devapc_mt8186 = {
+ .vio_idx_num = 519,
+ .vio_mask_offset = 0x0,
+ .vio_sta_offset = 0x400,
+ .vio_dbg0_offset = 0x900,
+ .vio_dbg1_offset = 0x904,
+ .apc_con_offset = 0xF00,
+ .vio_shift_sta_offset = 0xF10,
+ .vio_shift_sel_offset = 0xF14,
+ .vio_shift_con_offset = 0xF20,
+};
+
static const struct of_device_id mtk_devapc_dt_match[] = {
{
.compatible = "mediatek,mt6779-devapc",
.data = &devapc_mt6779,
+ }, {
+ .compatible = "mediatek,mt8186-devapc",
+ .data = &devapc_mt8186,
}, {
},
};
--
2.18.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: soc: mediatek: devapc: Add bindings for MT8186
2022-04-29 6:54 ` [PATCH 1/2] dt-bindings: soc: mediatek: devapc: Add bindings " Rex-BC Chen
@ 2022-04-29 21:00 ` Krzysztof Kozlowski
2022-05-04 9:36 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-29 21:00 UTC (permalink / raw)
To: Rex-BC Chen, robh+dt, krzysztof.kozlowski+dt, matthias.bgg
Cc: neal.liu, runyang.chen, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group
On 29/04/2022 08:54, Rex-BC Chen wrote:
> Add the dt-binding to support MT8186 devapc.
>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] soc: mediatek: devapc: Add support for MT8186
2022-04-29 6:54 ` [PATCH 2/2] soc: mediatek: devapc: Add support " Rex-BC Chen
@ 2022-05-04 9:34 ` AngeloGioacchino Del Regno
2022-05-04 10:51 ` Rex-BC Chen
0 siblings, 1 reply; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-04 9:34 UTC (permalink / raw)
To: Rex-BC Chen, robh+dt, krzysztof.kozlowski+dt, matthias.bgg
Cc: neal.liu, runyang.chen, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group
Il 29/04/22 08:54, Rex-BC Chen ha scritto:
> Add devapc data and compatible to support MT8186 devapc.
>
> Signed-off-by: Runyang Chen <runyang.chen@mediatek.com>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-devapc.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-devapc.c
> index 7c65ad3d1f8a..762e0e4d967d 100644
> --- a/drivers/soc/mediatek/mtk-devapc.c
> +++ b/drivers/soc/mediatek/mtk-devapc.c
> @@ -227,10 +227,25 @@ static const struct mtk_devapc_data devapc_mt6779 = {
> .vio_shift_con_offset = 0xF20,
> };
>
> +static const struct mtk_devapc_data devapc_mt8186 = {
> + .vio_idx_num = 519,
> + .vio_mask_offset = 0x0,
> + .vio_sta_offset = 0x400,
> + .vio_dbg0_offset = 0x900,
> + .vio_dbg1_offset = 0x904,
> + .apc_con_offset = 0xF00,
> + .vio_shift_sta_offset = 0xF10,
> + .vio_shift_sel_offset = 0xF14,
> + .vio_shift_con_offset = 0xF20,
> +};
Hello Rex,
since the register layout is common across a lot of MediaTek SoCs and basically
only the vio_idx_num wildly varies between them, can you separate this parameter
from the mtk_devapc_data struct?
I propose the following:
struct mtk_devapc_regs {
/* reg offset */
u32 vio_mask_offset;
u32 ... etc
};
struct mtk_devapc_data {
u32 vio_idx_num;
const struct mtk_devapc_regs *regs;
};
static const struct mtk_devapc_regs devapc_regs_mt6779 = {
.vio_mask_offset = 0x0,
.vio...etc
};
static const struct mtk_devapc_data devapc_mt6779 = {
.vio_idx_num = 511,
.regs = devapc_regs_mt6779,
};
static const struct mtk_devapc_data devapc_mt8186 = {
.vio_idx_num = 519,
.regs = devapc_regs_mt6779,
};
Regards,
Angelo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: soc: mediatek: devapc: Add bindings for MT8186
2022-04-29 6:54 ` [PATCH 1/2] dt-bindings: soc: mediatek: devapc: Add bindings " Rex-BC Chen
2022-04-29 21:00 ` Krzysztof Kozlowski
@ 2022-05-04 9:36 ` AngeloGioacchino Del Regno
2022-05-07 15:46 ` Chun-Kuang Hu
1 sibling, 1 reply; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-04 9:36 UTC (permalink / raw)
To: Rex-BC Chen, robh+dt, krzysztof.kozlowski+dt, matthias.bgg
Cc: neal.liu, runyang.chen, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group
Il 29/04/22 08:54, Rex-BC Chen ha scritto:
> Add the dt-binding to support MT8186 devapc.
>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] soc: mediatek: devapc: Add support for MT8186
2022-05-04 9:34 ` AngeloGioacchino Del Regno
@ 2022-05-04 10:51 ` Rex-BC Chen
0 siblings, 0 replies; 8+ messages in thread
From: Rex-BC Chen @ 2022-05-04 10:51 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, robh+dt, krzysztof.kozlowski+dt,
matthias.bgg
Cc: neal.liu, runyang.chen, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group
On Wed, 2022-05-04 at 11:34 +0200, AngeloGioacchino Del Regno wrote:
> Il 29/04/22 08:54, Rex-BC Chen ha scritto:
> > Add devapc data and compatible to support MT8186 devapc.
> >
> > Signed-off-by: Runyang Chen <runyang.chen@mediatek.com>
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > ---
> > drivers/soc/mediatek/mtk-devapc.c | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/drivers/soc/mediatek/mtk-devapc.c
> > b/drivers/soc/mediatek/mtk-devapc.c
> > index 7c65ad3d1f8a..762e0e4d967d 100644
> > --- a/drivers/soc/mediatek/mtk-devapc.c
> > +++ b/drivers/soc/mediatek/mtk-devapc.c
> > @@ -227,10 +227,25 @@ static const struct mtk_devapc_data
> > devapc_mt6779 = {
> > .vio_shift_con_offset = 0xF20,
> > };
> >
> > +static const struct mtk_devapc_data devapc_mt8186 = {
> > + .vio_idx_num = 519,
> > + .vio_mask_offset = 0x0,
> > + .vio_sta_offset = 0x400,
> > + .vio_dbg0_offset = 0x900,
> > + .vio_dbg1_offset = 0x904,
> > + .apc_con_offset = 0xF00,
> > + .vio_shift_sta_offset = 0xF10,
> > + .vio_shift_sel_offset = 0xF14,
> > + .vio_shift_con_offset = 0xF20,
> > +};
>
> Hello Rex,
> since the register layout is common across a lot of MediaTek SoCs and
> basically
> only the vio_idx_num wildly varies between them, can you separate
> this parameter
> from the mtk_devapc_data struct?
>
> I propose the following:
>
> struct mtk_devapc_regs {
> /* reg offset */
> u32 vio_mask_offset;
> u32 ... etc
> };
>
> struct mtk_devapc_data {
> u32 vio_idx_num;
> const struct mtk_devapc_regs *regs;
> };
>
> static const struct mtk_devapc_regs devapc_regs_mt6779 = {
> .vio_mask_offset = 0x0,
> .vio...etc
> };
>
> static const struct mtk_devapc_data devapc_mt6779 = {
> .vio_idx_num = 511,
> .regs = devapc_regs_mt6779,
> };
>
> static const struct mtk_devapc_data devapc_mt8186 = {
> .vio_idx_num = 519,
> .regs = devapc_regs_mt6779,
> };
>
> Regards,
> Angelo
>
Hello Angelo,
Thanks for your advise.
I will separate vio_idx_num and register offsets in next version.
BRs,
Rex
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: soc: mediatek: devapc: Add bindings for MT8186
2022-05-04 9:36 ` AngeloGioacchino Del Regno
@ 2022-05-07 15:46 ` Chun-Kuang Hu
0 siblings, 0 replies; 8+ messages in thread
From: Chun-Kuang Hu @ 2022-05-07 15:46 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: Rex-BC Chen, Rob Herring, krzysztof.kozlowski+dt,
Matthias Brugger, Neal Liu, runyang.chen,
moderated list:ARM/Mediatek SoC support, DTML, linux-kernel,
Linux ARM, Project_Global_Chrome_Upstream_Group
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> 於
2022年5月4日 週三 下午5:53寫道:
>
> Il 29/04/22 08:54, Rex-BC Chen ha scritto:
> > Add the dt-binding to support MT8186 devapc.
> >
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-07 15:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 6:54 [PATCH 0/2] Support MediaTek devapc for MT8186 Rex-BC Chen
2022-04-29 6:54 ` [PATCH 1/2] dt-bindings: soc: mediatek: devapc: Add bindings " Rex-BC Chen
2022-04-29 21:00 ` Krzysztof Kozlowski
2022-05-04 9:36 ` AngeloGioacchino Del Regno
2022-05-07 15:46 ` Chun-Kuang Hu
2022-04-29 6:54 ` [PATCH 2/2] soc: mediatek: devapc: Add support " Rex-BC Chen
2022-05-04 9:34 ` AngeloGioacchino Del Regno
2022-05-04 10:51 ` Rex-BC Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).