From: Fabien Parent <fparent@baylibre.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Macpaul Lin <macpaul.lin@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] arm64: dts: mediatek: mt8195-demo: enable ethernet
Date: Fri, 29 Apr 2022 17:22:03 +0200 [thread overview]
Message-ID: <20220429152203.ppuimwcka5d6rvq4@radium> (raw)
In-Reply-To: <f4256b5e-e6b8-f9de-fe97-3e9c6cdcb00c@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 5329 bytes --]
On Fri, Apr 29, 2022 at 04:00:32PM +0200, Matthias Brugger wrote:
>
>
> On 27/04/2022 08:25, Macpaul Lin wrote:
> > On Tue, 2022-04-26 at 15:41 +0200, Fabien Parent wrote:
> > > Enable ethernet on the MT8195 demo board.
> > >
> > > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > > ---
> > > arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 108
> > > +++++++++++++++++++
> > > 1 file changed, 108 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> > > b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> > > index 08cab3b3943b..0b7985486e2a 100644
> > > --- a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> > > +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> > > @@ -80,6 +80,30 @@ optee_reserved: optee@43200000 {
> > > };
> > > };
> > > +ð {
> > > + phy-mode = "rgmii-rxid";
> > > + phy-handle = <ð_phy>;
> > > + snps,reset-gpio = <&pio 93 GPIO_ACTIVE_HIGH>;
> > > + snps,reset-delays-us = <0 10000 10000>;
> > > + mediatek,tx-delay-ps = <2030>;
> > > + pinctrl-names = "default", "sleep";
> > > + pinctrl-0 = <ð_default_pins>;
> > > + pinctrl-1 = <ð_sleep_pins>;
> > > + status = "okay";
> > > +
> > > + mdio {
> > > + compatible = "snps,dwmac-mdio";
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + eth_phy: phy@1 {
> > > + compatible = "ethernet-phy-id001c.c916";
> > > + #phy-cells = <0>;
> > > + reg = <0x1>;
> > > + };
> > > + };
> > > +};
> > > +
> > > &i2c6 {
> > > clock-frequency = <400000>;
> > > pinctrl-0 = <&i2c6_pins>;
> > > @@ -260,6 +284,90 @@ &mt6359_vsram_others_ldo_reg {
> > > };
> > > &pio {
> > > + eth_default_pins: eth-default-pins {
> > > + pins-cc {
> > > + pinmux = <PINMUX_GPIO85__FUNC_GBE_TXC>,
> > > + <PINMUX_GPIO88__FUNC_GBE_TXEN>,
> > > + <PINMUX_GPIO87__FUNC_GBE_RXDV>,
> > > + <PINMUX_GPIO86__FUNC_GBE_RXC>;
> > > + drive-strength = <MTK_DRIVE_8mA>;
> > > + };
> > > +
> > > + pins-mdio {
> > > + pinmux = <PINMUX_GPIO89__FUNC_GBE_MDC>,
> > > + <PINMUX_GPIO90__FUNC_GBE_MDIO>;
> > > + input-enable;
> > > + };
> > > +
> > > + pins-phy-reset {
> > > + pinmux = <PINMUX_GPIO93__FUNC_GPIO93>;
> > > + };
> > > +
> > > + pins-power {
> > > + pinmux = <PINMUX_GPIO91__FUNC_GPIO91>,
> > > + <PINMUX_GPIO92__FUNC_GPIO92>;
> > > + output-high;
> > > + };
> > > +
> > > + pins-rxd {
> > > + pinmux = <PINMUX_GPIO81__FUNC_GBE_RXD3>,
> > > + <PINMUX_GPIO82__FUNC_GBE_RXD2>,
> > > + <PINMUX_GPIO83__FUNC_GBE_RXD1>,
> > > + <PINMUX_GPIO84__FUNC_GBE_RXD0>;
> > > + };
> > > +
> > > + pins-txd {
> > > + pinmux = <PINMUX_GPIO77__FUNC_GBE_TXD3>,
> > > + <PINMUX_GPIO78__FUNC_GBE_TXD2>,
> > > + <PINMUX_GPIO79__FUNC_GBE_TXD1>,
> > > + <PINMUX_GPIO80__FUNC_GBE_TXD0>;
> > > + drive-strength = <MTK_DRIVE_8mA>;
> > > + };
> > > + };
> > > +
> > > + eth_sleep_pins: eth-sleep-pins {
> > > + pins-cc {
> > > + pinmux = <PINMUX_GPIO85__FUNC_GPIO85>,
> > > + <PINMUX_GPIO88__FUNC_GPIO88>,
> > > + <PINMUX_GPIO87__FUNC_GPIO87>,
> > > + <PINMUX_GPIO86__FUNC_GPIO86>;
> > > + };
> > > +
> > > + pins-mdio {
> > > + pinmux = <PINMUX_GPIO89__FUNC_GPIO89>,
> > > + <PINMUX_GPIO90__FUNC_GPIO90>;
> > > + input-disable;
> > > + bias-disable;
> > > + };
> > > +
> > > + pins-phy-reset {
> > > + pinmux = <PINMUX_GPIO93__FUNC_GPIO93>;
> > > + input-disable;
> > > + bias-disable;
> > > + };
> > > +
> > > + pins-power {
> > > + pinmux = <PINMUX_GPIO91__FUNC_GPIO91>,
> > > + <PINMUX_GPIO92__FUNC_GPIO92>;
> > > + input-disable;
> > > + bias-disable;
> > > + };
> > > +
> > > + pins-rxd {
> > > + pinmux = <PINMUX_GPIO81__FUNC_GPIO81>,
> > > + <PINMUX_GPIO82__FUNC_GPIO82>,
> > > + <PINMUX_GPIO83__FUNC_GPIO83>,
> > > + <PINMUX_GPIO84__FUNC_GPIO84>;
> > > + };
> > > +
> > > + pins-txd {
> > > + pinmux = <PINMUX_GPIO77__FUNC_GPIO77>,
> > > + <PINMUX_GPIO78__FUNC_GPIO78>,
> > > + <PINMUX_GPIO79__FUNC_GPIO79>,
> > > + <PINMUX_GPIO80__FUNC_GPIO80>;
> > > + };
> > > + };
> > > +
> > > gpio_keys_pins: gpio-keys-pins {
> > > pins {
> > > pinmux = <PINMUX_GPIO106__FUNC_GPIO106>;
> >
> > Tested-by: Macpaul Lin <macpaul.lin@mediatek.com>
> >
>
> I get the following error:
> Error: arch/arm64/boot/dts/mediatek/mt8195.dtsi:582.26-27 syntax error
I think he used my upstreaming branch where I store the patches I sent
and will send to the mailing list: [0].
I forgot there is a dependency between this patch and [1], and I forgot
to test this patch serie independenly from the other commits from my
branch. I will make sure to not forget next time.
So from this patch serie, only patch 1-2, 6-7 can be applied since they
don't have any hidden dependency:
dt-bindings: usb: mediatek,mtu3: add binding for MT8195 SoC
arm64: dts: mediatek: mt8195: add ssusb support
arm64: dts: mediatek: mt8195-demo: Remove input-name property
arm64: dts: mediatek: mt8195-demo: enable uart1
[0] https://github.com/Fabo/linux/tree/mt8195-demo
[1] https://lore.kernel.org/all/20210615173233.26682-7-tinghan.shen@mediatek.com/
>
>
>
> How did you test?
>
> Regards,
> Matthias
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-04-29 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220426134106.242353-1-fparent@baylibre.com>
2022-04-26 13:40 ` [PATCH 1/7] dt-bindings: usb: mediatek,mtu3: add binding for MT8195 SoC Fabien Parent
2022-04-27 6:12 ` [PATCH 1/7] dt-bindings: usb: mediatek, mtu3: " Macpaul Lin
2022-04-28 7:53 ` [PATCH 1/7] dt-bindings: usb: mediatek,mtu3: " Krzysztof Kozlowski
2022-04-26 13:41 ` [PATCH 2/7] arm64: dts: mediatek: mt8195: add ssusb support Fabien Parent
2022-04-26 13:41 ` [PATCH 3/7] arm64: dts: mediatek: mt8195: add ethernet device node Fabien Parent
2022-04-27 6:16 ` Macpaul Lin
2022-04-26 13:41 ` [PATCH 4/7] arm64: dts: mediatek: mt8195-evb: enable ethernet Fabien Parent
2022-04-26 13:41 ` [PATCH 5/7] arm64: dts: mediatek: mt8195-demo: " Fabien Parent
2022-04-27 6:25 ` Macpaul Lin
2022-04-29 14:00 ` Matthias Brugger
2022-04-29 15:22 ` Fabien Parent [this message]
2022-05-06 9:11 ` Macpaul Lin
2022-04-26 13:41 ` [PATCH 6/7] arm64: dts: mediatek: mt8195-demo: Remove input-name property Fabien Parent
2022-04-26 13:41 ` [PATCH 7/7] arm64: dts: mediatek: mt8195-demo: enable uart1 Fabien Parent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429152203.ppuimwcka5d6rvq4@radium \
--to=fparent@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).