[PATCH 0/2] slimbus: patches for 5.19

[PATCH 0/2] slimbus: patches for 5.19

[Srinivas Kandagatla]

Hi Greg,

Here are some trivial SLIMbus patches for 5.19 which mostly includes
cleanups around get_irq.

Can you please queue them up for 5.19.

thanks for you help,
srini

Lad Prabhakar (1):
  slimbus: qcom-ngd-ctrl: Use platform_get_irq() to get the interrupt

Yang Li (1):
  slimbus: qcom: Remove unnecessary print function dev_err()

 drivers/slimbus/qcom-ctrl.c     |  4 +---
 drivers/slimbus/qcom-ngd-ctrl.c | 10 ++++------
 2 files changed, 5 insertions(+), 9 deletions(-)

-- 
2.21.0

[PATCH 1/2] slimbus: qcom-ngd-ctrl: Use platform_get_irq() to get the interrupt

[Srinivas Kandagatla]

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Tested-By: Steev Klimaszewski <steev@kali.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/slimbus/qcom-ngd-ctrl.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index 7040293c2ee8..0f29a08b4c09 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -1526,13 +1526,11 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
 	if (IS_ERR(ctrl->base))
 		return PTR_ERR(ctrl->base);
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!res) {
-		dev_err(&pdev->dev, "no slimbus IRQ resource\n");
-		return -ENODEV;
-	}
+	ret = platform_get_irq(pdev, 0);
+	if (ret < 0)
+		return ret;
 
-	ret = devm_request_irq(dev, res->start, qcom_slim_ngd_interrupt,
+	ret = devm_request_irq(dev, ret, qcom_slim_ngd_interrupt,
 			       IRQF_TRIGGER_HIGH, "slim-ngd", ctrl);
 	if (ret) {
 		dev_err(&pdev->dev, "request IRQ failed\n");
-- 
2.21.0

[PATCH 2/2] slimbus: qcom: Remove unnecessary print function dev_err()

[Srinivas Kandagatla]

From: Yang Li <yang.lee@linux.alibaba.com>

The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because
platform_get_irq() already prints an error

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/slimbus/qcom-ctrl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
index ec58091fc948..c0c4f895d76e 100644
--- a/drivers/slimbus/qcom-ctrl.c
+++ b/drivers/slimbus/qcom-ctrl.c
@@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev)
 	}
 
 	ctrl->irq = platform_get_irq(pdev, 0);
-	if (ctrl->irq < 0) {
-		dev_err(&pdev->dev, "no slimbus IRQ\n");
+	if (ctrl->irq < 0)
 		return ctrl->irq;
-	}
 
 	sctrl = &ctrl->ctrl;
 	sctrl->dev = &pdev->dev;
-- 
2.21.0

Re: [PATCH 2/2] slimbus: qcom: Remove unnecessary print function dev_err()

[Greg KH]

On Fri, Apr 29, 2022 at 05:50:51PM +0100, Srinivas Kandagatla wrote:
> From: Yang Li <yang.lee@linux.alibaba.com>
> 
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
> 
> Eliminate the follow coccicheck warning:
> ./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because
> platform_get_irq() already prints an error
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/slimbus/qcom-ctrl.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
> index ec58091fc948..c0c4f895d76e 100644
> --- a/drivers/slimbus/qcom-ctrl.c
> +++ b/drivers/slimbus/qcom-ctrl.c
> @@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev)
>  	}
>  
>  	ctrl->irq = platform_get_irq(pdev, 0);
> -	if (ctrl->irq < 0) {
> -		dev_err(&pdev->dev, "no slimbus IRQ\n");
> +	if (ctrl->irq < 0)
>  		return ctrl->irq;
> -	}
>  
>  	sctrl = &ctrl->ctrl;
>  	sctrl->dev = &pdev->dev;
> -- 
> 2.21.0
> 

Does not apply to my tree :(

Re: [PATCH 2/2] slimbus: qcom: Remove unnecessary print function dev_err()

[Srinivas Kandagatla]

On 09/05/2022 14:42, Greg KH wrote:
> On Fri, Apr 29, 2022 at 05:50:51PM +0100, Srinivas Kandagatla wrote:
>> From: Yang Li <yang.lee@linux.alibaba.com>
>>
>> The print function dev_err() is redundant because
>> platform_get_irq_byname() already prints an error.
>>
>> Eliminate the follow coccicheck warning:
>> ./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because
>> platform_get_irq() already prints an error
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>>   drivers/slimbus/qcom-ctrl.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
>> index ec58091fc948..c0c4f895d76e 100644
>> --- a/drivers/slimbus/qcom-ctrl.c
>> +++ b/drivers/slimbus/qcom-ctrl.c
>> @@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev)
>>   	}
>>   
>>   	ctrl->irq = platform_get_irq(pdev, 0);
>> -	if (ctrl->irq < 0) {
>> -		dev_err(&pdev->dev, "no slimbus IRQ\n");
>> +	if (ctrl->irq < 0)
>>   		return ctrl->irq;
>> -	}
>>   
>>   	sctrl = &ctrl->ctrl;
>>   	sctrl->dev = &pdev->dev;
>> -- 
>> 2.21.0
>>
> 
> Does not apply to my tree :(
Sorry my bad..
I see there was a depended fix[1] that needs to go in first.
I was hoping that that will be applied first..
Let me resend them together in v2.


[1] https://lkml.org/lkml/2022/4/29/1093

Thanks,
srini
> 
>