linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: msm8996: Add SDHCI resets
@ 2022-04-30 16:26 Konrad Dybcio
  2022-06-28 20:18 ` (subset) " Bjorn Andersson
  0 siblings, 1 reply; 2+ messages in thread
From: Konrad Dybcio @ 2022-04-30 16:26 UTC (permalink / raw)
  To: ~postmarketos/upstreaming
  Cc: martin.botka, angelogioacchino.delregno, marijn.suijten,
	jamipkettunen, Konrad Dybcio, Andy Gross, Bjorn Andersson,
	Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
	linux-kernel

On MSM8996, the default bootloader configuration leaves the hosts in some
weird state that never allows them to function properly under Linux.
Add the hardware resets so that we can start clean and get them actually
working.

Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
Depends on [1], fixes eMMC on at least SONY Tone.

[1] https://patchwork.kernel.org/project/linux-mmc/patch/1650816153-23797-1-git-send-email-quic_c_sbhanu@quicinc.com/

 arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index b9a48cfd760f..dc56830f9e00 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -2707,6 +2707,7 @@ sdhc1: sdhci@7464900 {
 			clocks = <&gcc GCC_SDCC1_AHB_CLK>,
 				<&gcc GCC_SDCC1_APPS_CLK>,
 				<&rpmcc RPM_SMD_BB_CLK1>;
+			resets = <&gcc GCC_SDCC1_BCR>;
 
 			pinctrl-names = "default", "sleep";
 			pinctrl-0 = <&sdc1_state_on>;
@@ -2730,6 +2731,7 @@ sdhc2: sdhci@74a4900 {
 			clocks = <&gcc GCC_SDCC2_AHB_CLK>,
 				<&gcc GCC_SDCC2_APPS_CLK>,
 				<&rpmcc RPM_SMD_BB_CLK1>;
+			resets = <&gcc GCC_SDCC2_BCR>;
 
 			pinctrl-names = "default", "sleep";
 			pinctrl-0 = <&sdc2_state_on>;
-- 
2.35.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: (subset) [PATCH] arm64: dts: qcom: msm8996: Add SDHCI resets
  2022-04-30 16:26 [PATCH] arm64: dts: qcom: msm8996: Add SDHCI resets Konrad Dybcio
@ 2022-06-28 20:18 ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2022-06-28 20:18 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, Konrad Dybcio
  Cc: martin.botka, devicetree, linux-kernel, marijn.suijten,
	jamipkettunen, linux-arm-msm, Krzysztof Kozlowski, Andy Gross,
	Rob Herring, angelogioacchino.delregno

On Sat, 30 Apr 2022 18:26:42 +0200, Konrad Dybcio wrote:
> On MSM8996, the default bootloader configuration leaves the hosts in some
> weird state that never allows them to function properly under Linux.
> Add the hardware resets so that we can start clean and get them actually
> working.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: msm8996: Add SDHCI resets
      commit: 68333a42fcf53f20aa09567f8b57216438cdd2f6

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-28 20:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-30 16:26 [PATCH] arm64: dts: qcom: msm8996: Add SDHCI resets Konrad Dybcio
2022-06-28 20:18 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).