From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Kevin Tian <kevin.tian@intel.com>
Cc: Jacob jun Pan <jacob.jun.pan@intel.com>,
Liu Yi L <yi.l.liu@intel.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH 1/5] iommu/vt-d: Block force-snoop domain attaching if no SC support
Date: Sun, 1 May 2022 19:24:30 +0800 [thread overview]
Message-ID: <20220501112434.874236-2-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20220501112434.874236-1-baolu.lu@linux.intel.com>
In the attach_dev callback of the default domain ops, if the domain has
been set force_snooping, but the iommu hardware of the device does not
support SC(Snoop Control) capability, the callback should block it and
return a corresponding error code.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/intel/iommu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index cf43e8f9091b..d68f5bbf3e93 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -4354,6 +4354,9 @@ static int prepare_domain_attach_device(struct iommu_domain *domain,
if (!iommu)
return -ENODEV;
+ if (dmar_domain->force_snooping && !ecap_sc_support(iommu->ecap))
+ return -EOPNOTSUPP;
+
/* check if this iommu agaw is sufficient for max mapped address */
addr_width = agaw_to_width(iommu->agaw);
if (addr_width > cap_mgaw(iommu->cap))
--
2.25.1
next prev parent reply other threads:[~2022-05-01 11:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 11:24 [PATCH 0/5] iommu/vt-d: Force snooping improvement Lu Baolu
2022-05-01 11:24 ` Lu Baolu [this message]
2022-05-02 13:04 ` [PATCH 1/5] iommu/vt-d: Block force-snoop domain attaching if no SC support Jason Gunthorpe
2022-05-01 11:24 ` [PATCH 2/5] iommu/vt-d: Set SNP bit only in second-level page table entries Lu Baolu
2022-05-02 13:05 ` Jason Gunthorpe
2022-05-04 7:25 ` Baolu Lu
2022-05-04 13:31 ` Jason Gunthorpe
2022-05-04 14:37 ` Baolu Lu
2022-05-01 11:24 ` [PATCH 3/5] iommu/vt-d: Check domain force_snooping against attached devices Lu Baolu
2022-05-02 13:17 ` Jason Gunthorpe
2022-05-04 7:58 ` Baolu Lu
2022-05-02 21:31 ` Jacob Pan
2022-05-04 8:06 ` Baolu Lu
2022-05-01 11:24 ` [PATCH 4/5] iommu/vt-d: Remove domain_update_iommu_snooping() Lu Baolu
2022-05-02 13:19 ` Jason Gunthorpe
2022-05-02 21:36 ` Jacob Pan
2022-05-04 8:47 ` Baolu Lu
2022-05-01 11:24 ` [PATCH 5/5] iommu/vt-d: Remove hard coding PGSNP bit in PASID entries Lu Baolu
2022-05-02 13:19 ` Jason Gunthorpe
2022-05-04 8:49 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220501112434.874236-2-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).