From: Jacob Pan <jacob.jun.pan@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
Kevin Tian <kevin.tian@intel.com>, Liu Yi L <yi.l.liu@intel.com>,
<iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
jacob.jun.pan@intel.com
Subject: Re: [PATCH 4/5] iommu/vt-d: Remove domain_update_iommu_snooping()
Date: Mon, 2 May 2022 14:36:03 -0700 [thread overview]
Message-ID: <20220502143603.4143dd66@jacob-builder> (raw)
In-Reply-To: <20220501112434.874236-5-baolu.lu@linux.intel.com>
Hi BaoLu,
On Sun, 1 May 2022 19:24:33 +0800, Lu Baolu <baolu.lu@linux.intel.com>
wrote:
> The IOMMU force snooping capability is not required to be consistent
> among all the IOMMUs anymore. Remove force snooping capability check
> in the IOMMU hot-add path and domain_update_iommu_snooping() becomes
> a dead code now.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/iommu/intel/iommu.c | 34 +---------------------------------
> 1 file changed, 1 insertion(+), 33 deletions(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 3c1c228f9031..d5808495eb64 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -533,33 +533,6 @@ static void domain_update_iommu_coherency(struct
> dmar_domain *domain) rcu_read_unlock();
> }
>
> -static bool domain_update_iommu_snooping(struct intel_iommu *skip)
> -{
> - struct dmar_drhd_unit *drhd;
> - struct intel_iommu *iommu;
> - bool ret = true;
> -
> - rcu_read_lock();
> - for_each_active_iommu(iommu, drhd) {
> - if (iommu != skip) {
> - /*
> - * If the hardware is operating in the scalable
> mode,
> - * the snooping control is always supported
> since we
> - * always set PASID-table-entry.PGSNP bit if the
> domain
> - * is managed outside (UNMANAGED).
> - */
> - if (!sm_supported(iommu) &&
> - !ecap_sc_support(iommu->ecap)) {
> - ret = false;
> - break;
> - }
> - }
> - }
> - rcu_read_unlock();
> -
> - return ret;
> -}
> -
> static int domain_update_iommu_superpage(struct dmar_domain *domain,
> struct intel_iommu *skip)
> {
> @@ -3593,12 +3566,7 @@ static int intel_iommu_add(struct dmar_drhd_unit
> *dmaru) iommu->name);
> return -ENXIO;
> }
> - if (!ecap_sc_support(iommu->ecap) &&
> - domain_update_iommu_snooping(iommu)) {
> - pr_warn("%s: Doesn't support snooping.\n",
> - iommu->name);
> - return -ENXIO;
> - }
> +
Maybe I missed earlier patches, so this bit can also be deleted?
struct dmar_domain {
u8 iommu_snooping: 1; /* indicate snooping control
feature */
> sp = domain_update_iommu_superpage(NULL, iommu) - 1;
> if (sp >= 0 && !(cap_super_page_val(iommu->cap) & (1 << sp))) {
> pr_warn("%s: Doesn't support large page.\n",
Thanks,
Jacob
next prev parent reply other threads:[~2022-05-02 21:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 11:24 [PATCH 0/5] iommu/vt-d: Force snooping improvement Lu Baolu
2022-05-01 11:24 ` [PATCH 1/5] iommu/vt-d: Block force-snoop domain attaching if no SC support Lu Baolu
2022-05-02 13:04 ` Jason Gunthorpe
2022-05-01 11:24 ` [PATCH 2/5] iommu/vt-d: Set SNP bit only in second-level page table entries Lu Baolu
2022-05-02 13:05 ` Jason Gunthorpe
2022-05-04 7:25 ` Baolu Lu
2022-05-04 13:31 ` Jason Gunthorpe
2022-05-04 14:37 ` Baolu Lu
2022-05-01 11:24 ` [PATCH 3/5] iommu/vt-d: Check domain force_snooping against attached devices Lu Baolu
2022-05-02 13:17 ` Jason Gunthorpe
2022-05-04 7:58 ` Baolu Lu
2022-05-02 21:31 ` Jacob Pan
2022-05-04 8:06 ` Baolu Lu
2022-05-01 11:24 ` [PATCH 4/5] iommu/vt-d: Remove domain_update_iommu_snooping() Lu Baolu
2022-05-02 13:19 ` Jason Gunthorpe
2022-05-02 21:36 ` Jacob Pan [this message]
2022-05-04 8:47 ` Baolu Lu
2022-05-01 11:24 ` [PATCH 5/5] iommu/vt-d: Remove hard coding PGSNP bit in PASID entries Lu Baolu
2022-05-02 13:19 ` Jason Gunthorpe
2022-05-04 8:49 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502143603.4143dd66@jacob-builder \
--to=jacob.jun.pan@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).