linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: at91: sama7g5: remove interrupt-parent from gic node
@ 2022-05-03 13:31 Eugen Hristev
  2022-05-09  5:57 ` Claudiu.Beznea
  0 siblings, 1 reply; 2+ messages in thread
From: Eugen Hristev @ 2022-05-03 13:31 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: devicetree, linux-kernel, claudiu.beznea, nicolas.ferre, Eugen Hristev

interrupt-parent is not to be used as a boolean property.
It is already present in the DT in the proper way it's supposed to be used:
interrupt-parent = <&gic>;

This is also reported by dtbs_check:
arch/arm/boot/dts/at91-sama7g5ek.dtb: interrupt-controller@e8c11000: interrupt-parent: True is not of type 'array'
	From schema: /.local/lib/python3.8/site-packages/dtschema/schemas/interrupts.yaml

Fixes: 7540629e2fc7 ("ARM: dts: at91: add sama7g5 SoC DT and sama7g5-ek")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 arch/arm/boot/dts/sama7g5.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
index cdaa9c825f69..f4f174314e4e 100644
--- a/arch/arm/boot/dts/sama7g5.dtsi
+++ b/arch/arm/boot/dts/sama7g5.dtsi
@@ -949,7 +949,6 @@ gic: interrupt-controller@e8c11000 {
 			#interrupt-cells = <3>;
 			#address-cells = <0>;
 			interrupt-controller;
-			interrupt-parent;
 			reg = <0xe8c11000 0x1000>,
 				<0xe8c12000 0x2000>;
 		};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: at91: sama7g5: remove interrupt-parent from gic node
  2022-05-03 13:31 [PATCH] ARM: dts: at91: sama7g5: remove interrupt-parent from gic node Eugen Hristev
@ 2022-05-09  5:57 ` Claudiu.Beznea
  0 siblings, 0 replies; 2+ messages in thread
From: Claudiu.Beznea @ 2022-05-09  5:57 UTC (permalink / raw)
  To: Eugen.Hristev, linux-arm-kernel; +Cc: devicetree, linux-kernel, Nicolas.Ferre

On 03.05.2022 16:31, Eugen Hristev wrote:
> interrupt-parent is not to be used as a boolean property.
> It is already present in the DT in the proper way it's supposed to be used:
> interrupt-parent = <&gic>;
> 
> This is also reported by dtbs_check:
> arch/arm/boot/dts/at91-sama7g5ek.dtb: interrupt-controller@e8c11000: interrupt-parent: True is not of type 'array'
> 	From schema: /.local/lib/python3.8/site-packages/dtschema/schemas/interrupts.yaml
> 
> Fixes: 7540629e2fc7 ("ARM: dts: at91: add sama7g5 SoC DT and sama7g5-ek")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

> ---
>  arch/arm/boot/dts/sama7g5.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
> index cdaa9c825f69..f4f174314e4e 100644
> --- a/arch/arm/boot/dts/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/sama7g5.dtsi
> @@ -949,7 +949,6 @@ gic: interrupt-controller@e8c11000 {
>  			#interrupt-cells = <3>;
>  			#address-cells = <0>;
>  			interrupt-controller;
> -			interrupt-parent;
>  			reg = <0xe8c11000 0x1000>,
>  				<0xe8c12000 0x2000>;
>  		};


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-09  6:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-03 13:31 [PATCH] ARM: dts: at91: sama7g5: remove interrupt-parent from gic node Eugen Hristev
2022-05-09  5:57 ` Claudiu.Beznea

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).