* [PATCH 0/2] Mediatek SCP dt-binding tweaks
@ 2022-04-29 21:11 Nícolas F. R. A. Prado
2022-04-29 21:11 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp Nícolas F. R. A. Prado
2022-04-29 21:11 ` [PATCH 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp Nícolas F. R. A. Prado
0 siblings, 2 replies; 13+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-04-29 21:11 UTC (permalink / raw)
To: Bjorn Andersson
Cc: AngeloGioacchino Del Regno, kernel, Nícolas F. R. A. Prado,
Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger,
Rob Herring, Tinghan Shen, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, linux-remoteproc
Two simple patches for the Mediatek SCP dt-binding. The first fixes the
reg/reg-names property while the second adds a new optional
memory-region property.
Nícolas F. R. A. Prado (2):
dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp
dt-bindings: remoteproc: mediatek: Add optional memory-region to
mtk,scp
.../devicetree/bindings/remoteproc/mtk,scp.yaml | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
--
2.36.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp 2022-04-29 21:11 [PATCH 0/2] Mediatek SCP dt-binding tweaks Nícolas F. R. A. Prado @ 2022-04-29 21:11 ` Nícolas F. R. A. Prado 2022-05-02 15:33 ` Rob Herring 2022-05-03 12:19 ` Krzysztof Kozlowski 2022-04-29 21:11 ` [PATCH 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp Nícolas F. R. A. Prado 1 sibling, 2 replies; 13+ messages in thread From: Nícolas F. R. A. Prado @ 2022-04-29 21:11 UTC (permalink / raw) To: Bjorn Andersson Cc: AngeloGioacchino Del Regno, kernel, Nícolas F. R. A. Prado, Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger, Rob Herring, Tinghan Shen, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc The SCP has three memory regions: sram, l1tcm and cfg. Only sram is required, the other two are optional. Fix the dt-binding so that the optional regions can be omitted and passed in any order. Also add the missing minItems to the reg property and update the description. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- .../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml index 823a236242de..ec9ddeb6ca2c 100644 --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml @@ -24,14 +24,20 @@ properties: reg: description: Should contain the address ranges for memory regions SRAM, CFG, and - L1TCM. + L1TCM. Only SRAM is required, while CFG and L1TCM are optional. + minItems: 1 maxItems: 3 reg-names: + minItems: 1 items: - const: sram - - const: cfg - - const: l1tcm + - enum: + - l1tcm + - cfg + - enum: + - l1tcm + - cfg clocks: description: -- 2.36.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp 2022-04-29 21:11 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp Nícolas F. R. A. Prado @ 2022-05-02 15:33 ` Rob Herring 2022-05-02 18:32 ` Nícolas F. R. A. Prado 2022-05-03 12:19 ` Krzysztof Kozlowski 1 sibling, 1 reply; 13+ messages in thread From: Rob Herring @ 2022-05-02 15:33 UTC (permalink / raw) To: Nícolas F. R. A. Prado Cc: Krzysztof Kozlowski, kernel, Matthias Brugger, linux-mediatek, linux-remoteproc, devicetree, Tinghan Shen, linux-arm-kernel, linux-kernel, AngeloGioacchino Del Regno, Bjorn Andersson, Rob Herring, Mathieu Poirier [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain, Size: 3979 bytes --] On Fri, 29 Apr 2022 17:11:09 -0400, Nícolas F. R. A. Prado wrote: > The SCP has three memory regions: sram, l1tcm and cfg. Only sram is > required, the other two are optional. Fix the dt-binding so that the > optional regions can be omitted and passed in any order. > > Also add the missing minItems to the reg property and update the > description. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > .../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ scp@10500000: interrupts: [[0, 174, 4]] is not of type 'object' arch/arm64/boot/dts/mediatek/mt8183-evb.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb scp@10500000: memory-region: [[25]] is not of type 'object' arch/arm64/boot/dts/mediatek/mt8183-evb.dtb scp@10500000: memory-region: [[27]] is not of type 'object' arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb scp@10500000: memory-region: [[28]] is not of type 'object' arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp 2022-05-02 15:33 ` Rob Herring @ 2022-05-02 18:32 ` Nícolas F. R. A. Prado 0 siblings, 0 replies; 13+ messages in thread From: Nícolas F. R. A. Prado @ 2022-05-02 18:32 UTC (permalink / raw) To: Rob Herring Cc: Krzysztof Kozlowski, kernel, Matthias Brugger, linux-mediatek, linux-remoteproc, devicetree, Tinghan Shen, linux-arm-kernel, linux-kernel, AngeloGioacchino Del Regno, Bjorn Andersson, Rob Herring, Mathieu Poirier On Mon, May 02, 2022 at 10:33:29AM -0500, Rob Herring wrote: > On Fri, 29 Apr 2022 17:11:09 -0400, Nícolas F. R. A. Prado wrote: > > The SCP has three memory regions: sram, l1tcm and cfg. Only sram is > > required, the other two are optional. Fix the dt-binding so that the > > optional regions can be omitted and passed in any order. > > > > Also add the missing minItems to the reg property and update the > > description. > > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > > > --- > > > > .../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. Hi Rob, These indeed aren't new warnings. But in any case, the fix for the interrupts one is already on its way to mainline [1]. And the memory-region one is what is fixed by patch 2 in this series. Thanks, Nícolas [1] https://lore.kernel.org/all/165066838719.2742284.7900096409445311556.b4-ty@linaro.org/ > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > scp@10500000: interrupts: [[0, 174, 4]] is not of type 'object' > arch/arm64/boot/dts/mediatek/mt8183-evb.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb > > scp@10500000: memory-region: [[25]] is not of type 'object' > arch/arm64/boot/dts/mediatek/mt8183-evb.dtb > > scp@10500000: memory-region: [[27]] is not of type 'object' > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb > > scp@10500000: memory-region: [[28]] is not of type 'object' > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb > > > -- > To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp 2022-04-29 21:11 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp Nícolas F. R. A. Prado 2022-05-02 15:33 ` Rob Herring @ 2022-05-03 12:19 ` Krzysztof Kozlowski 2022-05-03 12:26 ` AngeloGioacchino Del Regno 2022-05-03 17:58 ` Nícolas F. R. A. Prado 1 sibling, 2 replies; 13+ messages in thread From: Krzysztof Kozlowski @ 2022-05-03 12:19 UTC (permalink / raw) To: Nícolas F. R. A. Prado, Bjorn Andersson Cc: AngeloGioacchino Del Regno, kernel, Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger, Rob Herring, Tinghan Shen, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc On 29/04/2022 23:11, Nícolas F. R. A. Prado wrote: > The SCP has three memory regions: sram, l1tcm and cfg. Only sram is > required, the other two are optional. Fix the dt-binding so that the > optional regions can be omitted and passed in any order. No, cannot be passed in any order. > > Also add the missing minItems to the reg property and update the > description. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > .../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > index 823a236242de..ec9ddeb6ca2c 100644 > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > @@ -24,14 +24,20 @@ properties: > reg: > description: > Should contain the address ranges for memory regions SRAM, CFG, and > - L1TCM. > + L1TCM. Only SRAM is required, while CFG and L1TCM are optional. > + minItems: 1 > maxItems: 3 > > reg-names: > + minItems: 1 > items: > - const: sram > - - const: cfg > - - const: l1tcm > + - enum: > + - l1tcm > + - cfg > + - enum: > + - l1tcm > + - cfg This allows them in any combination which is not what we want. If both are optional and both can appear, then last should be a const:l1tcm. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp 2022-05-03 12:19 ` Krzysztof Kozlowski @ 2022-05-03 12:26 ` AngeloGioacchino Del Regno 2022-05-03 20:41 ` Nícolas F. R. A. Prado 2022-05-03 17:58 ` Nícolas F. R. A. Prado 1 sibling, 1 reply; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-03 12:26 UTC (permalink / raw) To: Krzysztof Kozlowski, Nícolas F. R. A. Prado, Bjorn Andersson Cc: kernel, Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger, Rob Herring, Tinghan Shen, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc Il 03/05/22 14:19, Krzysztof Kozlowski ha scritto: > On 29/04/2022 23:11, Nícolas F. R. A. Prado wrote: >> The SCP has three memory regions: sram, l1tcm and cfg. Only sram is >> required, the other two are optional. Fix the dt-binding so that the >> optional regions can be omitted and passed in any order. > > No, cannot be passed in any order. > >> >> Also add the missing minItems to the reg property and update the >> description. >> >> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >> >> --- >> >> .../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml >> index 823a236242de..ec9ddeb6ca2c 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml >> @@ -24,14 +24,20 @@ properties: >> reg: >> description: >> Should contain the address ranges for memory regions SRAM, CFG, and >> - L1TCM. >> + L1TCM. Only SRAM is required, while CFG and L1TCM are optional. >> + minItems: 1 >> maxItems: 3 >> >> reg-names: >> + minItems: 1 >> items: >> - const: sram >> - - const: cfg >> - - const: l1tcm >> + - enum: >> + - l1tcm >> + - cfg >> + - enum: >> + - l1tcm >> + - cfg > > This allows them in any combination which is not what we want. If both > are optional and both can appear, then last should be a const:l1tcm. > > Best regards, > Krzysztof Nicolas, I think that you weren't clear about what you're trying to solve with this commit in the description. I remember you had this kind of instance, but I don't really remember if it was about mtk,scp or (and?) something else.... so.... are you trying to fix issues with devicetrees declaring reg-names = "sram", "l1tcm"; ? Was this giving dtbs_check errors? Cheers, Angelo ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp 2022-05-03 12:26 ` AngeloGioacchino Del Regno @ 2022-05-03 20:41 ` Nícolas F. R. A. Prado 2022-05-04 6:22 ` Krzysztof Kozlowski 0 siblings, 1 reply; 13+ messages in thread From: Nícolas F. R. A. Prado @ 2022-05-03 20:41 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: Krzysztof Kozlowski, Bjorn Andersson, kernel, Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger, Rob Herring, Tinghan Shen, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc On Tue, May 03, 2022 at 02:26:15PM +0200, AngeloGioacchino Del Regno wrote: > Il 03/05/22 14:19, Krzysztof Kozlowski ha scritto: > > On 29/04/2022 23:11, Nícolas F. R. A. Prado wrote: > > > The SCP has three memory regions: sram, l1tcm and cfg. Only sram is > > > required, the other two are optional. Fix the dt-binding so that the > > > optional regions can be omitted and passed in any order. > > > > No, cannot be passed in any order. > > > > > > > > Also add the missing minItems to the reg property and update the > > > description. > > > > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > > > > > --- > > > > > > .../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 +++++++++--- > > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > > index 823a236242de..ec9ddeb6ca2c 100644 > > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > > @@ -24,14 +24,20 @@ properties: > > > reg: > > > description: > > > Should contain the address ranges for memory regions SRAM, CFG, and > > > - L1TCM. > > > + L1TCM. Only SRAM is required, while CFG and L1TCM are optional. > > > + minItems: 1 > > > maxItems: 3 > > > reg-names: > > > + minItems: 1 > > > items: > > > - const: sram > > > - - const: cfg > > > - - const: l1tcm > > > + - enum: > > > + - l1tcm > > > + - cfg > > > + - enum: > > > + - l1tcm > > > + - cfg > > > > This allows them in any combination which is not what we want. If both > > are optional and both can appear, then last should be a const:l1tcm. > > > > Best regards, > > Krzysztof > > Nicolas, I think that you weren't clear about what you're trying to solve with this > commit in the description. > > I remember you had this kind of instance, but I don't really remember if it was > about mtk,scp or (and?) something else.... so.... are you trying to fix issues > with devicetrees declaring > > reg-names = "sram", "l1tcm"; ? > > Was this giving dtbs_check errors? Hi Angelo, yes, some devicetrees (like mt8183) have reg-names = "sram", "cfg"; I'll include mention of this in the commit description for v3. This was also supposed to fix the warning for mt8192, where the order is different: "sram", "l1tcm", "cfg". But since Krzysztof said that we want a fixed order, then the mt8192 DT will need to be updated. (I also just noticed that it's just l1tcm that is optional, I was just being blind, so I'll also fix that in v3) Thanks, Nícolas > > Cheers, > Angelo ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp 2022-05-03 20:41 ` Nícolas F. R. A. Prado @ 2022-05-04 6:22 ` Krzysztof Kozlowski 0 siblings, 0 replies; 13+ messages in thread From: Krzysztof Kozlowski @ 2022-05-04 6:22 UTC (permalink / raw) To: Nícolas F. R. A. Prado, AngeloGioacchino Del Regno Cc: Bjorn Andersson, kernel, Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger, Rob Herring, Tinghan Shen, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc On 03/05/2022 22:41, Nícolas F. R. A. Prado wrote: > > This was also supposed to fix the warning for mt8192, where the order is > different: "sram", "l1tcm", "cfg". But since Krzysztof said that we want a fixed > order, then the mt8192 DT will need to be updated. Yes, please update DTS. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp 2022-05-03 12:19 ` Krzysztof Kozlowski 2022-05-03 12:26 ` AngeloGioacchino Del Regno @ 2022-05-03 17:58 ` Nícolas F. R. A. Prado 1 sibling, 0 replies; 13+ messages in thread From: Nícolas F. R. A. Prado @ 2022-05-03 17:58 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Bjorn Andersson, AngeloGioacchino Del Regno, kernel, Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger, Rob Herring, Tinghan Shen, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc On Tue, May 03, 2022 at 02:19:39PM +0200, Krzysztof Kozlowski wrote: > On 29/04/2022 23:11, Nícolas F. R. A. Prado wrote: > > The SCP has three memory regions: sram, l1tcm and cfg. Only sram is > > required, the other two are optional. Fix the dt-binding so that the > > optional regions can be omitted and passed in any order. > > No, cannot be passed in any order. > > > > > Also add the missing minItems to the reg property and update the > > description. > > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > > > --- > > > > .../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > index 823a236242de..ec9ddeb6ca2c 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > @@ -24,14 +24,20 @@ properties: > > reg: > > description: > > Should contain the address ranges for memory regions SRAM, CFG, and > > - L1TCM. > > + L1TCM. Only SRAM is required, while CFG and L1TCM are optional. > > + minItems: 1 > > maxItems: 3 > > > > reg-names: > > + minItems: 1 > > items: > > - const: sram > > - - const: cfg > > - - const: l1tcm > > + - enum: > > + - l1tcm > > + - cfg > > + - enum: > > + - l1tcm > > + - cfg > > This allows them in any combination which is not what we want. If both > are optional and both can appear, then last should be a const:l1tcm. Hi Krzysztof, yes, that's the case. I'll update it in v3 then. Thanks, Nícolas > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp 2022-04-29 21:11 [PATCH 0/2] Mediatek SCP dt-binding tweaks Nícolas F. R. A. Prado 2022-04-29 21:11 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp Nícolas F. R. A. Prado @ 2022-04-29 21:11 ` Nícolas F. R. A. Prado 2022-05-02 8:40 ` AngeloGioacchino Del Regno 2022-05-02 16:04 ` Rob Herring 1 sibling, 2 replies; 13+ messages in thread From: Nícolas F. R. A. Prado @ 2022-04-29 21:11 UTC (permalink / raw) To: Bjorn Andersson Cc: AngeloGioacchino Del Regno, kernel, Nícolas F. R. A. Prado, Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger, Rob Herring, Tinghan Shen, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc The SCP co-processor can optionally be passed a reserved memory region to use. Add this property in the dt-binding. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml index ec9ddeb6ca2c..64a9d2c7ed0d 100644 --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml @@ -51,6 +51,10 @@ properties: interrupts: maxItems: 1 + memory-region: + $ref: /schemas/types.yaml#/definitions/phandle + description: phandle to reserved memory region. + required: - compatible - reg -- 2.36.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp 2022-04-29 21:11 ` [PATCH 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp Nícolas F. R. A. Prado @ 2022-05-02 8:40 ` AngeloGioacchino Del Regno 2022-05-02 16:04 ` Rob Herring 1 sibling, 0 replies; 13+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-02 8:40 UTC (permalink / raw) To: Nícolas F. R. A. Prado, Bjorn Andersson Cc: kernel, Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger, Rob Herring, Tinghan Shen, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc Il 29/04/22 23:11, Nícolas F. R. A. Prado ha scritto: > The SCP co-processor can optionally be passed a reserved memory region > to use. Add this property in the dt-binding. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp 2022-04-29 21:11 ` [PATCH 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp Nícolas F. R. A. Prado 2022-05-02 8:40 ` AngeloGioacchino Del Regno @ 2022-05-02 16:04 ` Rob Herring 2022-05-02 18:35 ` Nícolas F. R. A. Prado 1 sibling, 1 reply; 13+ messages in thread From: Rob Herring @ 2022-05-02 16:04 UTC (permalink / raw) To: Nícolas F. R. A. Prado Cc: Bjorn Andersson, AngeloGioacchino Del Regno, kernel, Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger, Tinghan Shen, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc On Fri, Apr 29, 2022 at 05:11:10PM -0400, Nícolas F. R. A. Prado wrote: > The SCP co-processor can optionally be passed a reserved memory region > to use. Add this property in the dt-binding. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > index ec9ddeb6ca2c..64a9d2c7ed0d 100644 > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > @@ -51,6 +51,10 @@ properties: > interrupts: > maxItems: 1 > > + memory-region: > + $ref: /schemas/types.yaml#/definitions/phandle memory-region has a type already, so drop. What's needed is how many entries and what they are if more than 1. > + description: phandle to reserved memory region. > + > required: > - compatible > - reg > -- > 2.36.0 > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp 2022-05-02 16:04 ` Rob Herring @ 2022-05-02 18:35 ` Nícolas F. R. A. Prado 0 siblings, 0 replies; 13+ messages in thread From: Nícolas F. R. A. Prado @ 2022-05-02 18:35 UTC (permalink / raw) To: Rob Herring Cc: Bjorn Andersson, AngeloGioacchino Del Regno, kernel, Krzysztof Kozlowski, Mathieu Poirier, Matthias Brugger, Tinghan Shen, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek, linux-remoteproc On Mon, May 02, 2022 at 11:04:11AM -0500, Rob Herring wrote: > On Fri, Apr 29, 2022 at 05:11:10PM -0400, Nícolas F. R. A. Prado wrote: > > The SCP co-processor can optionally be passed a reserved memory region > > to use. Add this property in the dt-binding. > > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > > > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > index ec9ddeb6ca2c..64a9d2c7ed0d 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > @@ -51,6 +51,10 @@ properties: > > interrupts: > > maxItems: 1 > > > > + memory-region: > > + $ref: /schemas/types.yaml#/definitions/phandle > > memory-region has a type already, so drop. What's needed is how many > entries and what they are if more than 1. Hi Rob, OK, didn't notice this common property was already documented elsewhere. In that case I'll also drop the description since it's only 1. Thanks, Nícolas > > > + description: phandle to reserved memory region. > > + > > required: > > - compatible > > - reg > > -- > > 2.36.0 > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-05-04 6:23 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-04-29 21:11 [PATCH 0/2] Mediatek SCP dt-binding tweaks Nícolas F. R. A. Prado 2022-04-29 21:11 ` [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp Nícolas F. R. A. Prado 2022-05-02 15:33 ` Rob Herring 2022-05-02 18:32 ` Nícolas F. R. A. Prado 2022-05-03 12:19 ` Krzysztof Kozlowski 2022-05-03 12:26 ` AngeloGioacchino Del Regno 2022-05-03 20:41 ` Nícolas F. R. A. Prado 2022-05-04 6:22 ` Krzysztof Kozlowski 2022-05-03 17:58 ` Nícolas F. R. A. Prado 2022-04-29 21:11 ` [PATCH 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp Nícolas F. R. A. Prado 2022-05-02 8:40 ` AngeloGioacchino Del Regno 2022-05-02 16:04 ` Rob Herring 2022-05-02 18:35 ` Nícolas F. R. A. Prado
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).