* [PATCH RESEND] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files
@ 2022-05-04 7:46 Juerg Haefliger
2022-05-04 12:35 ` Marcel Holtmann
0 siblings, 1 reply; 4+ messages in thread
From: Juerg Haefliger @ 2022-05-04 7:46 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz, linux-bluetooth
Cc: linux-kernel, Juerg Haefliger
The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE
macros to povide that information via modinfo.
Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
---
RESEND:
Resend from protonmail email account to please the test bot.
---
drivers/bluetooth/ath3k.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
index 88262d3a9392..56e9a64177ae 100644
--- a/drivers/bluetooth/ath3k.c
+++ b/drivers/bluetooth/ath3k.c
@@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver");
MODULE_VERSION(VERSION);
MODULE_LICENSE("GPL");
MODULE_FIRMWARE(ATH3K_FIRMWARE);
+MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu");
+MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu");
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH RESEND] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files
2022-05-04 7:46 [PATCH RESEND] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files Juerg Haefliger
@ 2022-05-04 12:35 ` Marcel Holtmann
2022-05-05 6:07 ` Juerg Haefliger
0 siblings, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2022-05-04 12:35 UTC (permalink / raw)
To: Juerg Haefliger
Cc: Johan Hedberg, Luiz Augusto von Dentz, BlueZ, linux-kernel
Hi Juerg,
> The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE
> macros to povide that information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
> ---
> RESEND:
> Resend from protonmail email account to please the test bot.
> ---
> drivers/bluetooth/ath3k.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> index 88262d3a9392..56e9a64177ae 100644
> --- a/drivers/bluetooth/ath3k.c
> +++ b/drivers/bluetooth/ath3k.c
> @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver");
> MODULE_VERSION(VERSION);
> MODULE_LICENSE("GPL");
> MODULE_FIRMWARE(ATH3K_FIRMWARE);
> +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu");
> +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu");
I am still not convinced by the glob file matching. How would that actually work?
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH RESEND] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files
2022-05-04 12:35 ` Marcel Holtmann
@ 2022-05-05 6:07 ` Juerg Haefliger
2022-06-09 8:56 ` Juerg Haefliger
0 siblings, 1 reply; 4+ messages in thread
From: Juerg Haefliger @ 2022-05-05 6:07 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Johan Hedberg, Luiz Augusto von Dentz, BlueZ, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]
Hi Marcel,
> Hi Juerg,
>
> > The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE
> > macros to povide that information via modinfo.
> >
> > Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
> > ---
> > RESEND:
> > Resend from protonmail email account to please the test bot.
> > ---
> > drivers/bluetooth/ath3k.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> > index 88262d3a9392..56e9a64177ae 100644
> > --- a/drivers/bluetooth/ath3k.c
> > +++ b/drivers/bluetooth/ath3k.c
> > @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver");
> > MODULE_VERSION(VERSION);
> > MODULE_LICENSE("GPL");
> > MODULE_FIRMWARE(ATH3K_FIRMWARE);
> > +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu");
> > +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu");
>
> I am still not convinced by the glob file matching. How would that actually work?
In my case I need to remove firmware blobs that the kernel doesn't need to
reduce disk usage. This information helps. While it might retain unneeded
versions it's still better than nothing.
...Juerg
> Regards
>
> Marcel
>
[-- Attachment #2: attachment.sig --]
[-- Type: application/pgp-signature, Size: 849 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH RESEND] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files
2022-05-05 6:07 ` Juerg Haefliger
@ 2022-06-09 8:56 ` Juerg Haefliger
0 siblings, 0 replies; 4+ messages in thread
From: Juerg Haefliger @ 2022-06-09 8:56 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Juerg Haefliger, Johan Hedberg, Luiz Augusto von Dentz, BlueZ,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]
On Thu, 05 May 2022 06:07:52 +0000
"Juerg Haefliger" <juergh@protonmail.com> wrote:
> Hi Marcel,
>
>
> > Hi Juerg,
> >
> > > The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE
> > > macros to povide that information via modinfo.
> > >
> > > Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
> > > ---
> > > RESEND:
> > > Resend from protonmail email account to please the test bot.
> > > ---
> > > drivers/bluetooth/ath3k.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> > > index 88262d3a9392..56e9a64177ae 100644
> > > --- a/drivers/bluetooth/ath3k.c
> > > +++ b/drivers/bluetooth/ath3k.c
> > > @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver");
> > > MODULE_VERSION(VERSION);
> > > MODULE_LICENSE("GPL");
> > > MODULE_FIRMWARE(ATH3K_FIRMWARE);
> > > +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu");
> > > +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu");
> >
> > I am still not convinced by the glob file matching. How would that actually work?
>
> In my case I need to remove firmware blobs that the kernel doesn't need to
> reduce disk usage. This information helps. While it might retain unneeded
> versions it's still better than nothing.
Ping. So what do you suggest? Hard-code all filenames based on what's
currently in linux-firmware? Given the HW is quite old that might not change
very often...
...Juerg
>
> ...Juerg
>
>
> > Regards
> >
> > Marcel
> >
>
[-- Attachment #2: attachment.sig --]
[-- Type: application/pgp-signature, Size: 849 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-09 8:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-04 7:46 [PATCH RESEND] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files Juerg Haefliger
2022-05-04 12:35 ` Marcel Holtmann
2022-05-05 6:07 ` Juerg Haefliger
2022-06-09 8:56 ` Juerg Haefliger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).