From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"Andy Gross" <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
<devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
<quic_ppratap@quicinc.com>, <quic_vpulyala@quicinc.com>,
Sandeep Maheswaram <quic_c_sanm@quicinc.com>
Subject: Re: [v15 3/6] usb: dwc3: core: Host wake up support from system suspend
Date: Fri, 6 May 2022 10:44:48 +0530 [thread overview]
Message-ID: <20220506051448.GE4640@hu-pkondeti-hyd.qualcomm.com> (raw)
In-Reply-To: <a83dea08-0920-17e6-ec1c-f9d8a490a08d@quicinc.com>
On Fri, May 06, 2022 at 10:41:01AM +0530, Krishna Kurapati PSSNV wrote:
>
> On 5/6/2022 4:18 AM, Matthias Kaehlcke wrote:
> >On Thu, May 05, 2022 at 02:26:10PM +0530, Krishna Kurapati wrote:
> >>From: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> >>
> >>During suspend read the status of all port and set hs phy mode
> >>based on current speed. Use this hs phy mode to configure wakeup
> >>interrupts in qcom glue driver.
> >>
> >>Check wakeup-source property for dwc3 core node to set the
> >>wakeup capability. Drop the device_init_wakeup call from
> >>runtime suspend and resume.
> >>
> >>Also check during suspend if any wakeup capable devices are
> >>connected to the controller (directly or through hubs), if there
> >>are none set a flag to indicate that the PHY is powered
> >>down during suspend.
> >>
> >>Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> >>Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> >>---
> >> drivers/usb/dwc3/core.c | 33 ++++++++++++++++++++-------------
> >> drivers/usb/dwc3/core.h | 4 ++++
> >> drivers/usb/dwc3/host.c | 24 ++++++++++++++++++++++++
> >> 3 files changed, 48 insertions(+), 13 deletions(-)
> >>
> >>diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> >>index 950e238..cf377f5 100644
> >>--- a/drivers/usb/dwc3/core.c
> >>+++ b/drivers/usb/dwc3/core.c
> >>@@ -33,6 +33,7 @@
> >> #include <linux/usb/gadget.h>
> >> #include <linux/usb/of.h>
> >> #include <linux/usb/otg.h>
> >>+#include <linux/usb/hcd.h>
> >This is not needed anymore
> >
> >> #include "core.h"
> >> #include "gadget.h"
> >>@@ -1787,6 +1788,7 @@ static int dwc3_probe(struct platform_device *pdev)
> >> platform_set_drvdata(pdev, dwc);
> >> dwc3_cache_hwparams(dwc);
> >>+ device_init_wakeup(&pdev->dev, of_property_read_bool(dev->of_node, "wakeup-source"));
> >> spin_lock_init(&dwc->lock);
> >> mutex_init(&dwc->mutex);
> >>@@ -1936,6 +1938,7 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg)
> >> {
> >> unsigned long flags;
> >> u32 reg;
> >>+ struct usb_hcd *hcd = platform_get_drvdata(dwc->xhci);
> >This isn't used anymore, delete it
> My bad, Will fix this in next version.
> >> switch (dwc->current_dr_role) {
> >> case DWC3_GCTL_PRTCAP_DEVICE:
> >>@@ -1948,10 +1951,7 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg)
> >> dwc3_core_exit(dwc);
> >> break;
> >> case DWC3_GCTL_PRTCAP_HOST:
> >>- if (!PMSG_IS_AUTO(msg)) {
> >>- dwc3_core_exit(dwc);
> >>- break;
> >>- }
> >>+ dwc3_check_phy_speed_mode(dwc);
> >> /* Let controller to suspend HSPHY before PHY driver suspends */
> >> if (dwc->dis_u2_susphy_quirk ||
> >>@@ -1967,6 +1967,16 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg)
> >> phy_pm_runtime_put_sync(dwc->usb2_generic_phy);
> >> phy_pm_runtime_put_sync(dwc->usb3_generic_phy);
> >>+
> >>+ if (!PMSG_IS_AUTO(msg)) {
> >>+ if (device_may_wakeup(dwc->dev) &&
> >>+ device_wakeup_path(dwc->dev)) {
> >nit: the indentation is odd, align it with device_may_wakeup()?
> Sure, Will take care of it.
> >>+ dwc->phy_power_off = false;
> >>+ } else {
> >>+ dwc->phy_power_off = true;
> >>+ dwc3_core_exit(dwc);
> >As commented earlier, taking the controller and PHYs completely down causes a
> >significant power draw in some USB clients. Let's clarify what the specific
> >benefits are of doing dwc3_core_exit() vs. entering a low power mode.
> Sure, once we come to a conclusion on this, I will refresh the patches.
I think, Matthias is asking you to clarify in the commit description. we can
even quote Matthias observations.
Thanks,
Pavan
next prev parent reply other threads:[~2022-05-06 5:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 8:56 [v15 0/6] USB DWC3 host wake up support from system suspend Krishna Kurapati
2022-05-05 8:56 ` [v15 1/6] dt-bindings: usb: dwc3: Add wakeup-source property support Krishna Kurapati
2022-05-05 8:56 ` [v15 2/6] usb: host: xhci-plat: Enable wakeup based on children wakeup status Krishna Kurapati
2022-05-06 15:36 ` Matthias Kaehlcke
2022-05-09 3:38 ` Pavan Kondeti
2022-05-11 1:51 ` Pavan Kondeti
2022-05-11 15:54 ` Matthias Kaehlcke
2022-05-11 23:54 ` Pavan Kondeti
2022-05-05 8:56 ` [v15 3/6] usb: dwc3: core: Host wake up support from system suspend Krishna Kurapati
2022-05-05 22:48 ` Matthias Kaehlcke
2022-05-06 5:11 ` Krishna Kurapati PSSNV
2022-05-06 5:14 ` Pavan Kondeti [this message]
2022-05-06 15:51 ` Matthias Kaehlcke
2022-05-06 16:51 ` Matthias Kaehlcke
2022-05-05 8:56 ` [v15 4/6] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Krishna Kurapati
2022-05-05 8:56 ` [v15 5/6] usb: dwc3: qcom: Configure wakeup interrupts during suspend Krishna Kurapati
2022-05-05 8:56 ` [v15 6/6] usb: dwc3: qcom: Keep power domain on to retain controller status Krishna Kurapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506051448.GE4640@hu-pkondeti-hyd.qualcomm.com \
--to=quic_pkondeti@quicinc.com \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mka@chromium.org \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_vpulyala@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).