Re: [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032

From: Herve Codina <herve.codina@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Marek Vasut" <marek.vasut+renesas@gmail.com>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	linux-pci <linux-pci@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Sergey Shtylyov" <s.shtylyov@omp.ru>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Clement Leger" <clement.leger@bootlin.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032
Date: Fri, 6 May 2022 14:35:18 +0200	[thread overview]
Message-ID: <20220506143518.3ed9765b@bootlin.com> (raw)
In-Reply-To: <CAMuHMdVv-qCTyMQzr8ALCP-UmojZe9=NOrExPieJNV2300yzbQ@mail.gmail.com>

Hi All,

On Tue, 3 May 2022 11:37:31 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Krzysztof,
> 
> On Tue, May 3, 2022 at 11:29 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> > On 03/05/2022 08:51, Geert Uytterhoeven wrote:  
> > >>>> This should not be a reason why a property is or is not required. Either
> > >>>> this is required for device operation or not. If it is required, should
> > >>>> be in the bindings. Otherwise what are you going to do in the future?
> > >>>> Add a required property breaking the ABI?  
> > >>>
> > >>> The problem is that there are no bindings for the reset controller
> > >>> (actually the reset controller feature of the system-controller) yet.
> > >>> Yeah, we can just add #reset-cells = <1> to the system-controller
> > >>> device node, but we cannot add the actual resets properties to the
> > >>> consumers, until the actual cell values are defined.  
> > >>
> > >> Sounds like you should implement providers first. Or just live with the
> > >> warning as a reminder to implement the reset provider?  
> > >
> > > I'd go for the latter. The upstream r9a06g032.dtsi is still under active
> > > development. Until very recently, the only device supported was the
> > > serial console.  
> >
> > For clocks we use in such cases fixed-clock placeholders or empty
> > phandles. Maybe something like that would work here as well?  
> 
> I don't think that works for resets.
> Besides, the driver doesn't need or use the reset anyway.
> 

Finally, related to the "resets" property, what should I do ?
 (a) Keep the property as not required an change the commit log
 (b) Set the property as required and live with a warning (Rob's suggestion)

Regards,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com