* [PATCH] ARM: dts: qcom: msm8974-FP2: Add notification LED
@ 2022-05-05 16:30 Luca Weiss
2022-05-06 17:31 ` kernel test robot
2022-07-17 3:08 ` (subset) " Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Luca Weiss @ 2022-05-05 16:30 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
FP2 has a RGB LED connected to the TRILED and hence channels 7, 6 and
5 of the LPG. Add a node describing this.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
This patch depends on the PM8941 LPG patch:
https://lore.kernel.org/linux-arm-msm/20220504205411.1510667-1-bjorn.andersson@linaro.org/
.../dts/qcom-msm8974pro-fairphone-fp2.dts | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
index 0700a0008caa..0fad82fc9e03 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
@@ -3,6 +3,7 @@
#include "qcom-pm8841.dtsi"
#include "qcom-pm8941.dtsi"
#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
/ {
@@ -162,6 +163,35 @@ gpio_keys_pin_a: gpio-keys-active {
};
};
+&pm8941_lpg {
+ status = "okay";
+
+ qcom,power-source = <1>;
+
+ multi-led {
+ color = <LED_COLOR_ID_RGB>;
+ function = LED_FUNCTION_STATUS;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@7 {
+ reg = <7>;
+ color = <LED_COLOR_ID_RED>;
+ };
+
+ led@6 {
+ reg = <6>;
+ color = <LED_COLOR_ID_GREEN>;
+ };
+
+ led@5 {
+ reg = <5>;
+ color = <LED_COLOR_ID_BLUE>;
+ };
+ };
+};
+
&pronto {
status = "okay";
--
2.36.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: qcom: msm8974-FP2: Add notification LED
2022-05-05 16:30 [PATCH] ARM: dts: qcom: msm8974-FP2: Add notification LED Luca Weiss
@ 2022-05-06 17:31 ` kernel test robot
2022-07-17 3:08 ` (subset) " Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-05-06 17:31 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: kbuild-all, ~postmarketos/upstreaming, phone-devel, Luca Weiss,
Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
Hi Luca,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20220505]
[cannot apply to robh/for-next v5.18-rc5 v5.18-rc4 v5.18-rc3 v5.18-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Luca-Weiss/ARM-dts-qcom-msm8974-FP2-Add-notification-LED/20220506-003524
base: 632a8c88e339fe86ae6e420a24dfc641d4dd0ab5
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20220507/202205070100.8DCDwfSb-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/45445147f88f2416d7bc32c8a72c714818fe466c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Luca-Weiss/ARM-dts-qcom-msm8974-FP2-Add-notification-LED/20220506-003524
git checkout 45445147f88f2416d7bc32c8a72c714818fe466c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts:123.1-12 Label or path pm8941_lpg not found
FATAL ERROR: Syntax error parsing input tree
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH] ARM: dts: qcom: msm8974-FP2: Add notification LED
2022-05-05 16:30 [PATCH] ARM: dts: qcom: msm8974-FP2: Add notification LED Luca Weiss
2022-05-06 17:31 ` kernel test robot
@ 2022-07-17 3:08 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-07-17 3:08 UTC (permalink / raw)
To: linux-arm-msm, Luca Weiss
Cc: Krzysztof Kozlowski, ~postmarketos/upstreaming, Andy Gross,
linux-kernel, Rob Herring, phone-devel, devicetree
On Thu, 5 May 2022 18:30:29 +0200, Luca Weiss wrote:
> FP2 has a RGB LED connected to the TRILED and hence channels 7, 6 and
> 5 of the LPG. Add a node describing this.
>
>
Applied, thanks!
[1/1] ARM: dts: qcom: msm8974-FP2: Add notification LED
commit: a037fcabdbdd8615e17add98c2638df529ff2e3c
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-17 3:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05 16:30 [PATCH] ARM: dts: qcom: msm8974-FP2: Add notification LED Luca Weiss
2022-05-06 17:31 ` kernel test robot
2022-07-17 3:08 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).