From: Tyrone Ting <warp5tw@gmail.com>
To: avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, robh+dt@kernel.org,
krzysztof.kozlowski@canonical.com, wsa@kernel.org,
andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com,
semen.protsenko@linaro.org, sven@svenpeter.dev,
jie.deng@intel.com, jsd@semihalf.com, lukas.bulwahn@gmail.com,
olof@lixom.net, arnd@arndb.de, warp5tw@gmail.com,
tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com,
tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com,
kfting@nuvoton.com
Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/9] i2c: npcm: Bug fixes timeout, spurious interrupts
Date: Tue, 10 May 2022 17:16:45 +0800 [thread overview]
Message-ID: <20220510091654.8498-1-warp5tw@gmail.com> (raw)
From: Tyrone Ting <kfting@nuvoton.com>
This patchset includes the following fixes:
- Add dt-bindings description for NPCM845.
- Bug fix for timeout calculation.
- Better handling of spurious interrupts.
- Fix for event type in slave mode.
- Removal of own slave addresses [2:10].
- Support for next gen BMC (NPCM845).
The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards.
Addressed comments from:
- Krzysztof Kozlowski : https://lkml.org/lkml/2022/3/3/289
- Andy Shevchenko : https://lkml.org/lkml/2022/3/3/286
- Andy Shevchenko : https://lkml.org/lkml/2022/4/5/140
- Andy Shevchenko : https://lkml.org/lkml/2022/3/3/295
Changes since version 3:
- Correct the const format in if condition in i2c binding document.
- Add the oops message statement and register information in register
access width patch.
- Add the occurring rate of the i2c spurious interrupt issue and more
details in driver's behavior to overcome this issue.
- Address Andy's comments in the patch to support NPCM845.
Changes since version 2:
- Keep old code as fallback, if getting nuvoton,sys-mgr property fails.
- Fix the error reported by running 'make DT_CHECKER_FLAGS=-m
dt_binding_check'.
- Make nuvoton,sys-mgr required for nuvoton,npcm845-i2c.
- Correct the patch's subject about changing the way of getting GCR
regmap and add the description about keeping old code as fallback
if getting nuvoton,sys-mgr property fails.
- Correct the patch title and description about removing the unused
variable clk_regmap.
- Use the data field directly instead of the macros since macros are
not constants anymore in this patch.
Changes since version 1:
- Add nuvoton,sys-mgr property in NPCM devicetree.
- Describe the commit message in imperative mood.
- Modify the description in i2c binding document to cover NPCM series.
- Add new property in i2c binding document.
- Create a new patch for client address calculation.
- Create a new patch for updating gcr property name.
- Create a new patch for removing unused clock node.
- Explain EOB in the commit description.
- Create a new patch for correcting NPCM register access width.
- Remove some comment since the corresponding logic no longer exists.
- Remove fixes tag while the patch adds an additional feature.
- Use devicetree data field to support NPCM845.
Tali Perry (6):
i2c: npcm: Change the way of getting GCR regmap
i2c: npcm: Remove unused variable clk_regmap
i2c: npcm: Fix timeout calculation
i2c: npcm: Add tx complete counter
i2c: npcm: Handle spurious interrupts
i2c: npcm: Remove own slave addresses 2:10
Tyrone Ting (3):
dt-bindings: i2c: npcm: support NPCM845
i2c: npcm: Correct register access width
i2c: npcm: Support NPCM845
.../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 25 +-
drivers/i2c/busses/Kconfig | 8 +-
drivers/i2c/busses/Makefile | 2 +-
drivers/i2c/busses/i2c-npcm7xx.c | 277 +++++++++++-------
4 files changed, 196 insertions(+), 116 deletions(-)
--
2.17.1
next reply other threads:[~2022-05-10 9:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 9:16 Tyrone Ting [this message]
2022-05-10 9:16 ` [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
2022-05-11 15:24 ` Rob Herring
2022-05-12 1:31 ` Tyrone Ting
2022-05-13 8:26 ` Krzysztof Kozlowski
2022-05-10 9:16 ` [PATCH v4 2/9] i2c: npcm: Change the way of getting GCR regmap Tyrone Ting
2022-05-10 10:08 ` Andy Shevchenko
2022-05-11 1:34 ` Tyrone Ting
2022-05-16 19:48 ` Wolfram Sang
2022-05-17 1:05 ` Tyrone Ting
2022-05-17 6:04 ` Wolfram Sang
2022-05-17 6:09 ` Tyrone Ting
2022-05-10 9:16 ` [PATCH v4 3/9] i2c: npcm: Remove unused variable clk_regmap Tyrone Ting
2022-05-10 9:16 ` [PATCH v4 4/9] i2c: npcm: Fix timeout calculation Tyrone Ting
2022-05-10 9:16 ` [PATCH v4 5/9] i2c: npcm: Add tx complete counter Tyrone Ting
2022-05-10 9:16 ` [PATCH v4 6/9] i2c: npcm: Correct register access width Tyrone Ting
2022-05-10 9:16 ` [PATCH v4 7/9] i2c: npcm: Handle spurious interrupts Tyrone Ting
2022-05-10 10:14 ` Andy Shevchenko
2022-05-11 5:37 ` Tyrone Ting
2022-05-10 9:16 ` [PATCH v4 8/9] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting
2022-05-10 10:19 ` Andy Shevchenko
2022-05-11 1:39 ` Tyrone Ting
2022-05-16 1:23 ` Tyrone Ting
2022-05-10 9:16 ` [PATCH v4 9/9] i2c: npcm: Support NPCM845 Tyrone Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510091654.8498-1-warp5tw@gmail.com \
--to=warp5tw@gmail.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jie.deng@intel.com \
--cc=jsd@semihalf.com \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sven@svenpeter.dev \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=venture@google.com \
--cc=wsa@kernel.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).