linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tyrone Ting <warp5tw@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: sven@svenpeter.dev, JJLIU0@nuvoton.com,
	linux-kernel@vger.kernel.org, olof@lixom.net,
	lukas.bulwahn@gmail.com, jarkko.nikula@linux.intel.com,
	yuenn@google.com, arnd@arndb.de, tali.perry1@gmail.com,
	openbmc@lists.ozlabs.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux-i2c@vger.kernel.org,
	tmaimon77@gmail.com, benjaminfair@google.com,
	tomer.maimon@nuvoton.com, kfting@nuvoton.com,
	semen.protsenko@linaro.org, Avi.Fishman@nuvoton.com,
	jsd@semihalf.com, wsa@kernel.org, devicetree@vger.kernel.org,
	andriy.shevchenko@linux.intel.com, KWLIU@nuvoton.com,
	tali.perry@nuvoton.com, avifishman70@gmail.com,
	venture@google.com
Subject: Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845
Date: Thu, 12 May 2022 09:31:05 +0800	[thread overview]
Message-ID: <CACD3sJbiPYcckyLncXcVR-TFBo_-3XwSDYbmid4qwnoHX-JtUw@mail.gmail.com> (raw)
In-Reply-To: <20220511152422.GA339769-robh@kernel.org>

Hi Rob:

Thank you for your review. I would like to apply Krzysztof's comment
from the link https://www.spinics.net/lists/linux-i2c/msg56795.html
and remove the
quotes of the statement "$ref: "/schemas/types.yaml#/definitions/phandle"".

If it's okay with you, I'll come up with a new patch with
"Reviewed-by" from you and Krzysztof.

Thank you.

Rob Herring <robh@kernel.org> 於 2022年5月11日 週三 下午11:24寫道：
>
> On Tue, 10 May 2022 17:16:46 +0800, Tyrone Ting wrote:
> > From: Tyrone Ting <kfting@nuvoton.com>
> >
> > Add compatible and nuvoton,sys-mgr description for NPCM i2c module.
> >
> > Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
> > ---
> >  .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml     | 25 +++++++++++++++----
> >  1 file changed, 20 insertions(+), 5 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>

Best Regards,
Tyrone

  reply	other threads:[~2022-05-12  1:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10  9:16 [PATCH v4 0/9] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting
2022-05-10  9:16 ` [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
2022-05-11 15:24   ` Rob Herring
2022-05-12  1:31     ` Tyrone Ting [this message]
2022-05-13  8:26       ` Krzysztof Kozlowski
2022-05-10  9:16 ` [PATCH v4 2/9] i2c: npcm: Change the way of getting GCR regmap Tyrone Ting
2022-05-10 10:08   ` Andy Shevchenko
2022-05-11  1:34     ` Tyrone Ting
2022-05-16 19:48   ` Wolfram Sang
2022-05-17  1:05     ` Tyrone Ting
2022-05-17  6:04       ` Wolfram Sang
2022-05-17  6:09         ` Tyrone Ting
2022-05-10  9:16 ` [PATCH v4 3/9] i2c: npcm: Remove unused variable clk_regmap Tyrone Ting
2022-05-10  9:16 ` [PATCH v4 4/9] i2c: npcm: Fix timeout calculation Tyrone Ting
2022-05-10  9:16 ` [PATCH v4 5/9] i2c: npcm: Add tx complete counter Tyrone Ting
2022-05-10  9:16 ` [PATCH v4 6/9] i2c: npcm: Correct register access width Tyrone Ting
2022-05-10  9:16 ` [PATCH v4 7/9] i2c: npcm: Handle spurious interrupts Tyrone Ting
2022-05-10 10:14   ` Andy Shevchenko
2022-05-11  5:37     ` Tyrone Ting
2022-05-10  9:16 ` [PATCH v4 8/9] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting
2022-05-10 10:19   ` Andy Shevchenko
2022-05-11  1:39     ` Tyrone Ting
2022-05-16  1:23       ` Tyrone Ting
2022-05-10  9:16 ` [PATCH v4 9/9] i2c: npcm: Support NPCM845 Tyrone Ting
     [not found] <20220510100328.9191-1-warp5tw@gmail.com>
     [not found] ` <20220510100328.9191-2-warp5tw@gmail.com>
     [not found]   ` <28029d30-6d18-d28c-a7d2-d86b9ab9ad35@linaro.org>
     [not found]     ` <CACD3sJa6qEPDD58NqiXJ+hHHSSbB6BRqEPXuX+m49ei8HrHF+g@mail.gmail.com>
2022-05-11  0:28       ` [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACD3sJbiPYcckyLncXcVR-TFBo_-3XwSDYbmid4qwnoHX-JtUw@mail.gmail.com \
    --to=warp5tw@gmail.com \
    --cc=Avi.Fishman@nuvoton.com \
    --cc=JJLIU0@nuvoton.com \
    --cc=KWLIU@nuvoton.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=kfting@nuvoton.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=olof@lixom.net \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=sven@svenpeter.dev \
    --cc=tali.perry1@gmail.com \
    --cc=tali.perry@nuvoton.com \
    --cc=tmaimon77@gmail.com \
    --cc=tomer.maimon@nuvoton.com \
    --cc=venture@google.com \
    --cc=wsa@kernel.org \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).