[PATCH 0/2] spi: cadence-quadspi: a couple of minor cleanups

[PATCH 0/2] spi: cadence-quadspi: a couple of minor cleanups

[Ian Abbott]

Just a couple of trivial source code cleanups.

Ian Abbott (2):
  spi: cadence-quadspi: Add missing blank line in
    cqspi_request_mmap_dma()
  spi: cadence-quadspi: remove unnecessary (void *) casts

 drivers/spi/spi-cadence-quadspi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


base-commit: ab38272e99730375c5db3db1c4cebf691a0550ab
-- 
2.35.1

[PATCH 1/2] spi: cadence-quadspi: Add missing blank line in cqspi_request_mmap_dma()

[Ian Abbott]

Fix "WARNING: Missing a blank line after declarations" reported by
checkpatch.pl.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
---
 drivers/spi/spi-cadence-quadspi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index 30307392c75a..9915704eaf06 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1481,6 +1481,7 @@ static int cqspi_request_mmap_dma(struct cqspi_st *cqspi)
 	cqspi->rx_chan = dma_request_chan_by_mask(&mask);
 	if (IS_ERR(cqspi->rx_chan)) {
 		int ret = PTR_ERR(cqspi->rx_chan);
+
 		cqspi->rx_chan = NULL;
 		return dev_err_probe(&cqspi->pdev->dev, ret, "No Rx DMA available\n");
 	}
-- 
2.35.1

[PATCH 2/2] spi: cadence-quadspi: remove unnecessary (void *) casts

[Ian Abbott]

Remove a couple of unnecessary casts to `(void *)` when initializing the
`.data` members in the device ID table.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
---
 drivers/spi/spi-cadence-quadspi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index 9915704eaf06..aea6c132cbab 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1811,11 +1811,11 @@ static const struct of_device_id cqspi_dt_ids[] = {
 	},
 	{
 		.compatible = "xlnx,versal-ospi-1.0",
-		.data = (void *)&versal_ospi,
+		.data = &versal_ospi,
 	},
 	{
 		.compatible = "intel,socfpga-qspi",
-		.data = (void *)&socfpga_qspi,
+		.data = &socfpga_qspi,
 	},
 	{ /* end of table */ }
 };
-- 
2.35.1

Re: [PATCH 0/2] spi: cadence-quadspi: a couple of minor cleanups

[Mark Brown]

On Tue, 10 May 2022 12:51:39 +0100, Ian Abbott wrote:
> Just a couple of trivial source code cleanups.
> 
> Ian Abbott (2):
>   spi: cadence-quadspi: Add missing blank line in
>     cqspi_request_mmap_dma()
>   spi: cadence-quadspi: remove unnecessary (void *) casts
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: cadence-quadspi: Add missing blank line in cqspi_request_mmap_dma()
      commit: 76159e2f9a0fa29fd9fccb262687d95282985b49
[2/2] spi: cadence-quadspi: remove unnecessary (void *) casts
      commit: 0d8688298d6a43f2e187dad1e45871248123764f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark