* [PATCH] rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram
@ 2022-05-11 7:13 Yuan Can
2022-05-18 13:24 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Yuan Can @ 2022-05-11 7:13 UTC (permalink / raw)
To: linux-rtc; +Cc: linux-kernel, a.zummo, alexandre.belloni, yuancan, linkmauve
The hw_srnprot needs to be unmapped when gamecube_rtc_read_offset_from_sram returns.
Fixs: 86559400b3ef9d (rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U)
Signed-off-by: Yuan Can <yuancan@huawei.com>
---
drivers/rtc/rtc-gamecube.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-gamecube.c b/drivers/rtc/rtc-gamecube.c
index 18ca3b38b2d0..c2717bb52b2b 100644
--- a/drivers/rtc/rtc-gamecube.c
+++ b/drivers/rtc/rtc-gamecube.c
@@ -267,6 +267,7 @@ static int gamecube_rtc_read_offset_from_sram(struct priv *d)
ret = regmap_read(d->regmap, RTC_SRAM_BIAS, &d->rtc_bias);
if (ret) {
pr_err("failed to get the RTC bias\n");
+ iounmap(hw_srnprot);
return -1;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram
2022-05-11 7:13 [PATCH] rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram Yuan Can
@ 2022-05-18 13:24 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2022-05-18 13:24 UTC (permalink / raw)
To: Yuan Can, linux-rtc; +Cc: linux-kernel, a.zummo, linkmauve
On Wed, 11 May 2022 07:13:54 +0000, Yuan Can wrote:
> The hw_srnprot needs to be unmapped when gamecube_rtc_read_offset_from_sram returns.
>
>
Applied, thanks!
[1/1] rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram
commit: 6ddabcb106280db0f7344850adfce3dd6b171cbd
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-18 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11 7:13 [PATCH] rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram Yuan Can
2022-05-18 13:24 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).