From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <longman@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] locking/qrwlock: Reduce cacheline contention for rwlocks used in interrupt context
Date: Wed, 11 May 2022 10:30:36 +0200 [thread overview]
Message-ID: <20220511083036.GY76023@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220510192134.434753-2-longman@redhat.com>
On Tue, May 10, 2022 at 03:21:34PM -0400, Waiman Long wrote:
> Even though qrwlock is supposed to be a fair lock, it does allow readers
> from interrupt context to spin on the lock until it can acquire it making
> it not as fair. This exception was added due to the requirement to allow
> recursive read lock in interrupt context. This can also be achieved by
> just ignoring the writer waiting bit without spinning on the lock.
>
> By making this change, we make qrwlock a bit more fair and eliminating
> the problem of cacheline bouncing for rwlocks that are used heavily in
> interrupt context, like the networking stack. This should also reduce
> the chance of lock starvation for those interrupt context rwlocks.
> diff --git a/kernel/locking/qrwlock.c b/kernel/locking/qrwlock.c
> index 2e1600906c9f..d52d13e95600 100644
> --- a/kernel/locking/qrwlock.c
> +++ b/kernel/locking/qrwlock.c
> @@ -18,21 +18,16 @@
> * queued_read_lock_slowpath - acquire read lock of a queued rwlock
> * @lock: Pointer to queued rwlock structure
> */
> -void queued_read_lock_slowpath(struct qrwlock *lock)
> +void queued_read_lock_slowpath(struct qrwlock *lock, int cnts)
> {
> /*
> - * Readers come here when they cannot get the lock without waiting
> + * Readers come here when they cannot get the lock without waiting.
> + * Readers in interrupt context can steal the lock immediately
> + * if the writer is just waiting (not holding the lock yet).
> */
> - if (unlikely(in_interrupt())) {
> - /*
> - * Readers in interrupt context will get the lock immediately
> - * if the writer is just waiting (not holding the lock yet),
> - * so spin with ACQUIRE semantics until the lock is available
> - * without waiting in the queue.
> - */
> - atomic_cond_read_acquire(&lock->cnts, !(VAL & _QW_LOCKED));
> + if (unlikely(!(cnts & _QW_LOCKED) && in_interrupt()))
> return;
> - }
> +
> atomic_sub(_QR_BIAS, &lock->cnts);
>
> trace_contention_begin(lock, LCB_F_SPIN | LCB_F_READ);
I'm confused; prior to this change:
CPU0 CPU1
write_lock_irq(&l)
read_lock(&l)
<INRQ>
read_lock(&l)
...
was not deadlock, but now it would AFAICT.
next prev parent reply other threads:[~2022-05-11 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 19:21 [PATCH 1/2] locking/qrwlock: Change "queue rwlock" to "queued rwlock" Waiman Long
2022-05-10 19:21 ` [PATCH 2/2] locking/qrwlock: Reduce cacheline contention for rwlocks used in interrupt context Waiman Long
2022-05-11 7:20 ` Arnd Bergmann
2022-05-11 12:01 ` Waiman Long
2022-05-11 8:30 ` Peter Zijlstra [this message]
2022-05-11 12:44 ` Waiman Long
2022-05-11 13:34 ` Peter Zijlstra
2022-05-11 16:00 ` Waiman Long
2022-05-11 19:39 ` [tip: locking/core] locking/qrwlock: Change "queue rwlock" to "queued rwlock" tip-bot2 for Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511083036.GY76023@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).