* [PATCH 0/3] drivers: i2c: thunderx: Marvell thunderx i2c changes
@ 2022-05-11 13:36 Piyush Malgujar
2022-05-11 13:36 ` [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes Piyush Malgujar
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Piyush Malgujar @ 2022-05-11 13:36 UTC (permalink / raw)
To: linux-i2c, linux-kernel; +Cc: sgarapati, sbalcerak, cchavva, Piyush Malgujar
These patches includes the following changes:
- Handling clock divisor logic for Octeon SoC family using subsytem ID
- Support for high speed mode
- Setting the fwnode so that driver can work with ACPI defined TWSI
controllers.
Piyush Malgujar (3):
drivers: i2c: thunderx: octeontx2 clock divisor logic changes
drivers: i2c: thunderx: Add support for High speed mode
drivers: i2c: thunderx: Allow driver to work with ACPI defined TWSI
controllers
drivers/i2c/busses/i2c-octeon-core.c | 84 +++++++++++++++++-------
drivers/i2c/busses/i2c-octeon-core.h | 17 +++++
drivers/i2c/busses/i2c-thunderx-pcidrv.c | 8 +++
3 files changed, 85 insertions(+), 24 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes
2022-05-11 13:36 [PATCH 0/3] drivers: i2c: thunderx: Marvell thunderx i2c changes Piyush Malgujar
@ 2022-05-11 13:36 ` Piyush Malgujar
2022-05-17 1:00 ` kernel test robot
2022-05-11 13:36 ` [PATCH 2/3] drivers: i2c: thunderx: Add support for High speed mode Piyush Malgujar
2022-05-11 13:36 ` [PATCH 3/3] drivers: i2c: thunderx: Allow driver to work with ACPI defined TWSI controllers Piyush Malgujar
2 siblings, 1 reply; 7+ messages in thread
From: Piyush Malgujar @ 2022-05-11 13:36 UTC (permalink / raw)
To: linux-i2c, linux-kernel; +Cc: sgarapati, sbalcerak, cchavva, Piyush Malgujar
Handle changes to clock divisor logic for OcteonTX2 SoC family using
subsystem ID and using default reference clock source as 100MHz.
Signed-off-by: Suneel Garapati <sgarapati@marvell.com>
Signed-off-by: Piyush Malgujar <pmalgujar@marvell.com>
---
drivers/i2c/busses/i2c-octeon-core.c | 24 +++++++++++++++++++++---
drivers/i2c/busses/i2c-octeon-core.h | 14 ++++++++++++++
drivers/i2c/busses/i2c-thunderx-pcidrv.c | 6 ++++++
3 files changed, 41 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-octeon-core.c b/drivers/i2c/busses/i2c-octeon-core.c
index 845eda70b8cab52a0453c9f4cb545010fba4305d..49d07a63a01f0b0711f4fa7a5d13d684935e5cbc 100644
--- a/drivers/i2c/busses/i2c-octeon-core.c
+++ b/drivers/i2c/busses/i2c-octeon-core.c
@@ -17,6 +17,7 @@
#include <linux/interrupt.h>
#include <linux/kernel.h>
#include <linux/module.h>
+#include <linux/pci.h>
#include "i2c-octeon-core.h"
@@ -658,7 +659,16 @@ int octeon_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
void octeon_i2c_set_clock(struct octeon_i2c *i2c)
{
int tclk, thp_base, inc, thp_idx, mdiv_idx, ndiv_idx, foscl, diff;
- int thp = 0x18, mdiv = 2, ndiv = 0, delta_hz = 1000000;
+ /* starting value on search for lowest diff */
+ const int huge_delta = 1000000;
+ /*
+ * Find divisors to produce target frequency, start with large delta
+ * to cover wider range of divisors, note thp = TCLK half period.
+ */
+ int thp = 0x18, mdiv = 2, ndiv = 0, delta_hz = huge_delta;
+
+ if (octeon_i2c_is_otx2(to_pci_dev(i2c->dev)))
+ thp = 0x3;
for (ndiv_idx = 0; ndiv_idx < 8 && delta_hz != 0; ndiv_idx++) {
/*
@@ -672,17 +682,25 @@ void octeon_i2c_set_clock(struct octeon_i2c *i2c)
*/
tclk = i2c->twsi_freq * (mdiv_idx + 1) * 10;
tclk *= (1 << ndiv_idx);
- thp_base = (i2c->sys_freq / (tclk * 2)) - 1;
+ if (octeon_i2c_is_otx2(to_pci_dev(i2c->dev)))
+ thp_base = (i2c->sys_freq / tclk) - 2;
+ else
+ thp_base = (i2c->sys_freq / (tclk * 2)) - 1;
for (inc = 0; inc <= 1; inc++) {
thp_idx = thp_base + inc;
if (thp_idx < 5 || thp_idx > 0xff)
continue;
- foscl = i2c->sys_freq / (2 * (thp_idx + 1));
+ if (octeon_i2c_is_otx2(to_pci_dev(i2c->dev)))
+ foscl = i2c->sys_freq / (thp_idx + 2);
+ else
+ foscl = i2c->sys_freq /
+ (2 * (thp_idx + 1));
foscl = foscl / (1 << ndiv_idx);
foscl = foscl / (mdiv_idx + 1) / 10;
diff = abs(foscl - i2c->twsi_freq);
+ /* Use it if smaller diff from target */
if (diff < delta_hz) {
delta_hz = diff;
thp = thp_idx;
diff --git a/drivers/i2c/busses/i2c-octeon-core.h b/drivers/i2c/busses/i2c-octeon-core.h
index 9bb9f64fdda0392364638ecbaafe3fab5612baf6..15d379bf1d3cbba78378edfb6d45415a31ab4072 100644
--- a/drivers/i2c/busses/i2c-octeon-core.h
+++ b/drivers/i2c/busses/i2c-octeon-core.h
@@ -211,6 +211,20 @@ static inline void octeon_i2c_write_int(struct octeon_i2c *i2c, u64 data)
octeon_i2c_writeq_flush(data, i2c->twsi_base + TWSI_INT(i2c));
}
+#define PCI_SUBSYS_DEVID_9XXX 0xB
+/**
+ * octeon_i2c_is_otx2 - check for chip ID
+ * @pdev: PCI dev structure
+ *
+ * Returns TRUE if OcteonTX2, FALSE otherwise.
+ */
+static inline bool octeon_i2c_is_otx2(struct pci_dev *pdev)
+{
+ u32 chip_id = (pdev->subsystem_device >> 12) & 0xF;
+
+ return (chip_id == PCI_SUBSYS_DEVID_9XXX);
+}
+
/* Prototypes */
irqreturn_t octeon_i2c_isr(int irq, void *dev_id);
int octeon_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num);
diff --git a/drivers/i2c/busses/i2c-thunderx-pcidrv.c b/drivers/i2c/busses/i2c-thunderx-pcidrv.c
index 12c90aa0900e60b63e0a14215f3692c12876c9cf..9fd903196b6cf967cde321da04f8d0526d84cc2f 100644
--- a/drivers/i2c/busses/i2c-thunderx-pcidrv.c
+++ b/drivers/i2c/busses/i2c-thunderx-pcidrv.c
@@ -205,6 +205,12 @@ static int thunder_i2c_probe_pci(struct pci_dev *pdev,
if (ret)
goto error;
+ /*
+ * For OcteonTX2 chips, set reference frequency to 100MHz
+ * as refclk_src in TWSI_MODE register defaults to 100MHz.
+ */
+ if (octeon_i2c_is_otx2(pdev))
+ i2c->sys_freq = 100000000;
octeon_i2c_set_clock(i2c);
i2c->adap = thunderx_i2c_ops;
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] drivers: i2c: thunderx: Add support for High speed mode
2022-05-11 13:36 [PATCH 0/3] drivers: i2c: thunderx: Marvell thunderx i2c changes Piyush Malgujar
2022-05-11 13:36 ` [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes Piyush Malgujar
@ 2022-05-11 13:36 ` Piyush Malgujar
2022-05-11 13:36 ` [PATCH 3/3] drivers: i2c: thunderx: Allow driver to work with ACPI defined TWSI controllers Piyush Malgujar
2 siblings, 0 replies; 7+ messages in thread
From: Piyush Malgujar @ 2022-05-11 13:36 UTC (permalink / raw)
To: linux-i2c, linux-kernel; +Cc: sgarapati, sbalcerak, cchavva, Piyush Malgujar
Support High speed mode clock setup for OcteonTX2 platforms.
Signed-off-by: Suneel Garapati <sgarapati@marvell.com>
Signed-off-by: Piyush Malgujar <pmalgujar@marvell.com>
---
drivers/i2c/busses/i2c-octeon-core.c | 64 +++++++++++++++---------
drivers/i2c/busses/i2c-octeon-core.h | 3 ++
drivers/i2c/busses/i2c-thunderx-pcidrv.c | 3 +-
3 files changed, 46 insertions(+), 24 deletions(-)
diff --git a/drivers/i2c/busses/i2c-octeon-core.c b/drivers/i2c/busses/i2c-octeon-core.c
index 49d07a63a01f0b0711f4fa7a5d13d684935e5cbc..1588d9186b198bfe6ae78626829b3f221d51b8d9 100644
--- a/drivers/i2c/busses/i2c-octeon-core.c
+++ b/drivers/i2c/busses/i2c-octeon-core.c
@@ -608,25 +608,27 @@ int octeon_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
struct octeon_i2c *i2c = i2c_get_adapdata(adap);
int i, ret = 0;
- if (num == 1) {
- if (msgs[0].len > 0 && msgs[0].len <= 8) {
- if (msgs[0].flags & I2C_M_RD)
- ret = octeon_i2c_hlc_read(i2c, msgs);
- else
- ret = octeon_i2c_hlc_write(i2c, msgs);
- goto out;
- }
- } else if (num == 2) {
- if ((msgs[0].flags & I2C_M_RD) == 0 &&
- (msgs[1].flags & I2C_M_RECV_LEN) == 0 &&
- msgs[0].len > 0 && msgs[0].len <= 2 &&
- msgs[1].len > 0 && msgs[1].len <= 8 &&
- msgs[0].addr == msgs[1].addr) {
- if (msgs[1].flags & I2C_M_RD)
- ret = octeon_i2c_hlc_comp_read(i2c, msgs);
- else
- ret = octeon_i2c_hlc_comp_write(i2c, msgs);
- goto out;
+ if (IS_LS_FREQ(i2c->twsi_freq)) {
+ if (num == 1) {
+ if (msgs[0].len > 0 && msgs[0].len <= 8) {
+ if (msgs[0].flags & I2C_M_RD)
+ ret = octeon_i2c_hlc_read(i2c, msgs);
+ else
+ ret = octeon_i2c_hlc_write(i2c, msgs);
+ goto out;
+ }
+ } else if (num == 2) {
+ if ((msgs[0].flags & I2C_M_RD) == 0 &&
+ (msgs[1].flags & I2C_M_RECV_LEN) == 0 &&
+ msgs[0].len > 0 && msgs[0].len <= 2 &&
+ msgs[1].len > 0 && msgs[1].len <= 8 &&
+ msgs[0].addr == msgs[1].addr) {
+ if (msgs[1].flags & I2C_M_RD)
+ ret = octeon_i2c_hlc_comp_read(i2c, msgs);
+ else
+ ret = octeon_i2c_hlc_comp_write(i2c, msgs);
+ goto out;
+ }
}
}
@@ -665,10 +667,13 @@ void octeon_i2c_set_clock(struct octeon_i2c *i2c)
* Find divisors to produce target frequency, start with large delta
* to cover wider range of divisors, note thp = TCLK half period.
*/
- int thp = 0x18, mdiv = 2, ndiv = 0, delta_hz = huge_delta;
+ int ds = 10, thp = 0x18, mdiv = 2, ndiv = 0, delta_hz = huge_delta;
- if (octeon_i2c_is_otx2(to_pci_dev(i2c->dev)))
+ if (octeon_i2c_is_otx2(to_pci_dev(i2c->dev))) {
thp = 0x3;
+ if (!IS_LS_FREQ(i2c->twsi_freq))
+ ds = 15;
+ }
for (ndiv_idx = 0; ndiv_idx < 8 && delta_hz != 0; ndiv_idx++) {
/*
@@ -680,7 +685,7 @@ void octeon_i2c_set_clock(struct octeon_i2c *i2c)
* For given ndiv and mdiv values check the
* two closest thp values.
*/
- tclk = i2c->twsi_freq * (mdiv_idx + 1) * 10;
+ tclk = i2c->twsi_freq * (mdiv_idx + 1) * ds;
tclk *= (1 << ndiv_idx);
if (octeon_i2c_is_otx2(to_pci_dev(i2c->dev)))
thp_base = (i2c->sys_freq / tclk) - 2;
@@ -698,7 +703,9 @@ void octeon_i2c_set_clock(struct octeon_i2c *i2c)
foscl = i2c->sys_freq /
(2 * (thp_idx + 1));
foscl = foscl / (1 << ndiv_idx);
- foscl = foscl / (mdiv_idx + 1) / 10;
+ foscl = foscl / (mdiv_idx + 1) / ds;
+ if (foscl > i2c->twsi_freq)
+ continue;
diff = abs(foscl - i2c->twsi_freq);
/* Use it if smaller diff from target */
if (diff < delta_hz) {
@@ -712,6 +719,17 @@ void octeon_i2c_set_clock(struct octeon_i2c *i2c)
}
octeon_i2c_reg_write(i2c, SW_TWSI_OP_TWSI_CLK, thp);
octeon_i2c_reg_write(i2c, SW_TWSI_EOP_TWSI_CLKCTL, (mdiv << 3) | ndiv);
+ if (octeon_i2c_is_otx2(to_pci_dev(i2c->dev))) {
+ u64 mode;
+
+ mode = __raw_readq(i2c->twsi_base + MODE(i2c));
+ /* Set REFCLK_SRC and HS_MODE in TWSX_MODE register */
+ if (!IS_LS_FREQ(i2c->twsi_freq))
+ mode |= BIT(4) | BIT(0);
+ else
+ mode &= ~(BIT(4) | BIT(0));
+ octeon_i2c_writeq_flush(mode, i2c->twsi_base + MODE(i2c));
+ }
}
int octeon_i2c_init_lowlevel(struct octeon_i2c *i2c)
diff --git a/drivers/i2c/busses/i2c-octeon-core.h b/drivers/i2c/busses/i2c-octeon-core.h
index 15d379bf1d3cbba78378edfb6d45415a31ab4072..6a6c7c22c8bace850b9716a96a7d66827268f469 100644
--- a/drivers/i2c/busses/i2c-octeon-core.h
+++ b/drivers/i2c/busses/i2c-octeon-core.h
@@ -92,11 +92,13 @@ struct octeon_i2c_reg_offset {
unsigned int sw_twsi;
unsigned int twsi_int;
unsigned int sw_twsi_ext;
+ unsigned int mode;
};
#define SW_TWSI(x) (x->roff.sw_twsi)
#define TWSI_INT(x) (x->roff.twsi_int)
#define SW_TWSI_EXT(x) (x->roff.sw_twsi_ext)
+#define MODE(x) (x->roff.mode)
struct octeon_i2c {
wait_queue_head_t queue;
@@ -211,6 +213,7 @@ static inline void octeon_i2c_write_int(struct octeon_i2c *i2c, u64 data)
octeon_i2c_writeq_flush(data, i2c->twsi_base + TWSI_INT(i2c));
}
+#define IS_LS_FREQ(twsi_freq) ((twsi_freq) <= 400000)
#define PCI_SUBSYS_DEVID_9XXX 0xB
/**
* octeon_i2c_is_otx2 - check for chip ID
diff --git a/drivers/i2c/busses/i2c-thunderx-pcidrv.c b/drivers/i2c/busses/i2c-thunderx-pcidrv.c
index 9fd903196b6cf967cde321da04f8d0526d84cc2f..5621e983406b0bebf9c5c9e30921e45f3f15909b 100644
--- a/drivers/i2c/busses/i2c-thunderx-pcidrv.c
+++ b/drivers/i2c/busses/i2c-thunderx-pcidrv.c
@@ -165,6 +165,7 @@ static int thunder_i2c_probe_pci(struct pci_dev *pdev,
i2c->roff.sw_twsi = 0x1000;
i2c->roff.twsi_int = 0x1010;
i2c->roff.sw_twsi_ext = 0x1018;
+ i2c->roff.mode = 0x1038;
i2c->dev = dev;
pci_set_drvdata(pdev, i2c);
@@ -209,7 +210,7 @@ static int thunder_i2c_probe_pci(struct pci_dev *pdev,
* For OcteonTX2 chips, set reference frequency to 100MHz
* as refclk_src in TWSI_MODE register defaults to 100MHz.
*/
- if (octeon_i2c_is_otx2(pdev))
+ if (octeon_i2c_is_otx2(pdev) && IS_LS_FREQ(i2c->twsi_freq))
i2c->sys_freq = 100000000;
octeon_i2c_set_clock(i2c);
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] drivers: i2c: thunderx: Allow driver to work with ACPI defined TWSI controllers
2022-05-11 13:36 [PATCH 0/3] drivers: i2c: thunderx: Marvell thunderx i2c changes Piyush Malgujar
2022-05-11 13:36 ` [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes Piyush Malgujar
2022-05-11 13:36 ` [PATCH 2/3] drivers: i2c: thunderx: Add support for High speed mode Piyush Malgujar
@ 2022-05-11 13:36 ` Piyush Malgujar
2022-05-21 11:40 ` Wolfram Sang
2 siblings, 1 reply; 7+ messages in thread
From: Piyush Malgujar @ 2022-05-11 13:36 UTC (permalink / raw)
To: linux-i2c, linux-kernel; +Cc: sgarapati, sbalcerak, cchavva, Piyush Malgujar
Due to i2c->adap.dev.fwnode not being set, ACPI_COMPANION() wasn't properly
found for TWSI controllers.
Signed-off-by: Szymon Balcerak <sbalcerak@marvell.com>
Signed-off-by: Piyush Malgujar <pmalgujar@marvell.com>
---
drivers/i2c/busses/i2c-thunderx-pcidrv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-thunderx-pcidrv.c b/drivers/i2c/busses/i2c-thunderx-pcidrv.c
index 5621e983406b0bebf9c5c9e30921e45f3f15909b..3dd5a4d798f99e9b5282360cf9d5840042fc8dcc 100644
--- a/drivers/i2c/busses/i2c-thunderx-pcidrv.c
+++ b/drivers/i2c/busses/i2c-thunderx-pcidrv.c
@@ -220,6 +220,7 @@ static int thunder_i2c_probe_pci(struct pci_dev *pdev,
i2c->adap.bus_recovery_info = &octeon_i2c_recovery_info;
i2c->adap.dev.parent = dev;
i2c->adap.dev.of_node = pdev->dev.of_node;
+ i2c->adap.dev.fwnode = dev->fwnode;
snprintf(i2c->adap.name, sizeof(i2c->adap.name),
"Cavium ThunderX i2c adapter at %s", dev_name(dev));
i2c_set_adapdata(&i2c->adap, i2c);
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes
2022-05-11 13:36 ` [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes Piyush Malgujar
@ 2022-05-17 1:00 ` kernel test robot
2022-05-21 11:44 ` Wolfram Sang
0 siblings, 1 reply; 7+ messages in thread
From: kernel test robot @ 2022-05-17 1:00 UTC (permalink / raw)
To: Piyush Malgujar, linux-i2c, linux-kernel
Cc: llvm, kbuild-all, sgarapati, sbalcerak, cchavva, Piyush Malgujar
Hi Piyush,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on linux/master linus/master v5.18-rc7 next-20220516]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Piyush-Malgujar/drivers-i2c-thunderx-Marvell-thunderx-i2c-changes/20220511-213853
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: mips-randconfig-r025-20220516 (https://download.01.org/0day-ci/archive/20220517/202205170856.ko6UxqWi-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 853fa8ee225edf2d0de94b0dcbd31bea916e825e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/56654d280f7c130d4f1d78eb8a3fa57fedc86b7b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Piyush-Malgujar/drivers-i2c-thunderx-Marvell-thunderx-i2c-changes/20220511-213853
git checkout 56654d280f7c130d4f1d78eb8a3fa57fedc86b7b
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/i2c/busses/i2c-octeon-platdrv.c:27:
>> drivers/i2c/busses/i2c-octeon-core.h:223:21: error: incomplete definition of type 'struct pci_dev'
u32 chip_id = (pdev->subsystem_device >> 12) & 0xF;
~~~~^
include/asm-generic/pci_iomap.h:10:8: note: forward declaration of 'struct pci_dev'
struct pci_dev;
^
1 error generated.
vim +223 drivers/i2c/busses/i2c-octeon-core.h
213
214 #define PCI_SUBSYS_DEVID_9XXX 0xB
215 /**
216 * octeon_i2c_is_otx2 - check for chip ID
217 * @pdev: PCI dev structure
218 *
219 * Returns TRUE if OcteonTX2, FALSE otherwise.
220 */
221 static inline bool octeon_i2c_is_otx2(struct pci_dev *pdev)
222 {
> 223 u32 chip_id = (pdev->subsystem_device >> 12) & 0xF;
224
225 return (chip_id == PCI_SUBSYS_DEVID_9XXX);
226 }
227
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] drivers: i2c: thunderx: Allow driver to work with ACPI defined TWSI controllers
2022-05-11 13:36 ` [PATCH 3/3] drivers: i2c: thunderx: Allow driver to work with ACPI defined TWSI controllers Piyush Malgujar
@ 2022-05-21 11:40 ` Wolfram Sang
0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2022-05-21 11:40 UTC (permalink / raw)
To: Piyush Malgujar; +Cc: linux-i2c, linux-kernel, sgarapati, sbalcerak, cchavva
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
On Wed, May 11, 2022 at 06:36:59AM -0700, Piyush Malgujar wrote:
> Due to i2c->adap.dev.fwnode not being set, ACPI_COMPANION() wasn't properly
> found for TWSI controllers.
>
> Signed-off-by: Szymon Balcerak <sbalcerak@marvell.com>
> Signed-off-by: Piyush Malgujar <pmalgujar@marvell.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes
2022-05-17 1:00 ` kernel test robot
@ 2022-05-21 11:44 ` Wolfram Sang
0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2022-05-21 11:44 UTC (permalink / raw)
To: kernel test robot
Cc: Piyush Malgujar, linux-i2c, linux-kernel, llvm, kbuild-all,
sgarapati, sbalcerak, cchavva
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
> In file included from drivers/i2c/busses/i2c-octeon-platdrv.c:27:
> >> drivers/i2c/busses/i2c-octeon-core.h:223:21: error: incomplete definition of type 'struct pci_dev'
> u32 chip_id = (pdev->subsystem_device >> 12) & 0xF;
I guess this needs some fixing?
Other than that, you should really add Robert Richter to CC when
resending. He is at least mentioned for 'Odd fixes' in MAINTAINERS.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-05-21 11:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11 13:36 [PATCH 0/3] drivers: i2c: thunderx: Marvell thunderx i2c changes Piyush Malgujar
2022-05-11 13:36 ` [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes Piyush Malgujar
2022-05-17 1:00 ` kernel test robot
2022-05-21 11:44 ` Wolfram Sang
2022-05-11 13:36 ` [PATCH 2/3] drivers: i2c: thunderx: Add support for High speed mode Piyush Malgujar
2022-05-11 13:36 ` [PATCH 3/3] drivers: i2c: thunderx: Allow driver to work with ACPI defined TWSI controllers Piyush Malgujar
2022-05-21 11:40 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).