* [PATCH 0/2] Add GPCDMA support for Tegra234
@ 2022-05-12 9:00 Akhil R
2022-05-12 9:00 ` [PATCH 1/2] dt-bindings: Add headers for Tegra234 GPCDMA Akhil R
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Akhil R @ 2022-05-12 9:00 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, thierry.reding, jonathanh,
devicetree, linux-tegra, linux-kernel
Cc: akhilrajeev
Add headers and device tree node to support GPCDMA in Tegra234
Akhil R (2):
dt-bindings: Add headers for Tegra234 GPCDMA
arm64: tegra: Add Tegra234 GPCDMA device tree node
arch/arm64/boot/dts/nvidia/tegra234.dtsi | 43 ++++++++++++++++++++++
include/dt-bindings/memory/tegra234-mc.h | 1 +
include/dt-bindings/reset/tegra234-reset.h | 1 +
3 files changed, 45 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] dt-bindings: Add headers for Tegra234 GPCDMA
2022-05-12 9:00 [PATCH 0/2] Add GPCDMA support for Tegra234 Akhil R
@ 2022-05-12 9:00 ` Akhil R
2022-05-13 8:32 ` Krzysztof Kozlowski
2022-05-12 9:00 ` [PATCH 2/2] arm64: tegra: Add Tegra234 GPCDMA device tree node Akhil R
2022-05-12 9:09 ` [PATCH 0/2] Add GPCDMA support for Tegra234 Jon Hunter
2 siblings, 1 reply; 9+ messages in thread
From: Akhil R @ 2022-05-12 9:00 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, thierry.reding, jonathanh,
devicetree, linux-tegra, linux-kernel
Cc: akhilrajeev
Add reset and IOMMU header for Tegra234 GPCDMA
Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
---
include/dt-bindings/memory/tegra234-mc.h | 1 +
include/dt-bindings/reset/tegra234-reset.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/dt-bindings/memory/tegra234-mc.h b/include/dt-bindings/memory/tegra234-mc.h
index e3b0e9da295d..4bc84a312ad6 100644
--- a/include/dt-bindings/memory/tegra234-mc.h
+++ b/include/dt-bindings/memory/tegra234-mc.h
@@ -11,6 +11,7 @@
/* NISO0 stream IDs */
#define TEGRA234_SID_APE 0x02
#define TEGRA234_SID_HDA 0x03
+#define TEGRA234_SID_GPCDMA 0x04
#define TEGRA234_SID_PCIE0 0x12
#define TEGRA234_SID_PCIE4 0x13
#define TEGRA234_SID_PCIE5 0x14
diff --git a/include/dt-bindings/reset/tegra234-reset.h b/include/dt-bindings/reset/tegra234-reset.h
index 547ca3b60caa..5809245e4e21 100644
--- a/include/dt-bindings/reset/tegra234-reset.h
+++ b/include/dt-bindings/reset/tegra234-reset.h
@@ -15,6 +15,7 @@
#define TEGRA234_RESET_PEX1_COMMON_APB 13U
#define TEGRA234_RESET_PEX2_CORE_7 14U
#define TEGRA234_RESET_PEX2_CORE_7_APB 15U
+#define TEGRA234_RESET_GPCDMA 18U
#define TEGRA234_RESET_HDA 20U
#define TEGRA234_RESET_HDACODEC 21U
#define TEGRA234_RESET_I2C1 24U
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: tegra: Add Tegra234 GPCDMA device tree node
2022-05-12 9:00 [PATCH 0/2] Add GPCDMA support for Tegra234 Akhil R
2022-05-12 9:00 ` [PATCH 1/2] dt-bindings: Add headers for Tegra234 GPCDMA Akhil R
@ 2022-05-12 9:00 ` Akhil R
2022-05-13 8:32 ` Krzysztof Kozlowski
2022-05-12 9:09 ` [PATCH 0/2] Add GPCDMA support for Tegra234 Jon Hunter
2 siblings, 1 reply; 9+ messages in thread
From: Akhil R @ 2022-05-12 9:00 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, thierry.reding, jonathanh,
devicetree, linux-tegra, linux-kernel
Cc: akhilrajeev
Add device tree nodes for Tegra234 GPCDMA
Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
---
arch/arm64/boot/dts/nvidia/tegra234.dtsi | 43 ++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
index cb3af539e477..860c3cc68cea 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
@@ -21,6 +21,49 @@
ranges = <0x0 0x0 0x0 0x40000000>;
+ gpcdma: dma-controller@2600000 {
+ compatible = "nvidia,tegra194-gpcdma",
+ "nvidia,tegra186-gpcdma";
+ reg = <0x2600000 0x210000>;
+ resets = <&bpmp TEGRA234_RESET_GPCDMA>;
+ reset-names = "gpcdma";
+ interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ iommus = <&smmu_niso0 TEGRA234_SID_GPCDMA>;
+ dma-coherent;
+ status = "okay";
+ };
+
aconnect@2900000 {
compatible = "nvidia,tegra234-aconnect",
"nvidia,tegra210-aconnect";
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] Add GPCDMA support for Tegra234
2022-05-12 9:00 [PATCH 0/2] Add GPCDMA support for Tegra234 Akhil R
2022-05-12 9:00 ` [PATCH 1/2] dt-bindings: Add headers for Tegra234 GPCDMA Akhil R
2022-05-12 9:00 ` [PATCH 2/2] arm64: tegra: Add Tegra234 GPCDMA device tree node Akhil R
@ 2022-05-12 9:09 ` Jon Hunter
2022-05-12 9:21 ` Jon Hunter
2 siblings, 1 reply; 9+ messages in thread
From: Jon Hunter @ 2022-05-12 9:09 UTC (permalink / raw)
To: Akhil R, robh+dt, krzysztof.kozlowski+dt, thierry.reding,
devicetree, linux-tegra, linux-kernel
On 12/05/2022 10:00, Akhil R wrote:
> Add headers and device tree node to support GPCDMA in Tegra234
>
> Akhil R (2):
> dt-bindings: Add headers for Tegra234 GPCDMA
> arm64: tegra: Add Tegra234 GPCDMA device tree node
>
> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 43 ++++++++++++++++++++++
> include/dt-bindings/memory/tegra234-mc.h | 1 +
> include/dt-bindings/reset/tegra234-reset.h | 1 +
> 3 files changed, 45 insertions(+)
>
This should be V2 right? Otherwise looks good to me.
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Jon
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] Add GPCDMA support for Tegra234
2022-05-12 9:09 ` [PATCH 0/2] Add GPCDMA support for Tegra234 Jon Hunter
@ 2022-05-12 9:21 ` Jon Hunter
0 siblings, 0 replies; 9+ messages in thread
From: Jon Hunter @ 2022-05-12 9:21 UTC (permalink / raw)
To: Akhil R, robh+dt, krzysztof.kozlowski+dt, thierry.reding,
devicetree, linux-tegra, linux-kernel
On 12/05/2022 10:09, Jon Hunter wrote:
>
>
> On 12/05/2022 10:00, Akhil R wrote:
>> Add headers and device tree node to support GPCDMA in Tegra234
>>
>> Akhil R (2):
>> dt-bindings: Add headers for Tegra234 GPCDMA
>> arm64: tegra: Add Tegra234 GPCDMA device tree node
>>
>> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 43 ++++++++++++++++++++++
>> include/dt-bindings/memory/tegra234-mc.h | 1 +
>> include/dt-bindings/reset/tegra234-reset.h | 1 +
>> 3 files changed, 45 insertions(+)
>>
>
> This should be V2 right? Otherwise looks good to me.
Ah sorry, I forgot the initial version you sent me was not published to
the external mailing list so this is V1.
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: Add headers for Tegra234 GPCDMA
2022-05-12 9:00 ` [PATCH 1/2] dt-bindings: Add headers for Tegra234 GPCDMA Akhil R
@ 2022-05-13 8:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-13 8:32 UTC (permalink / raw)
To: Akhil R, robh+dt, krzysztof.kozlowski+dt, thierry.reding,
jonathanh, devicetree, linux-tegra, linux-kernel
On 12/05/2022 11:00, Akhil R wrote:
> Add reset and IOMMU header for Tegra234 GPCDMA
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: tegra: Add Tegra234 GPCDMA device tree node
2022-05-12 9:00 ` [PATCH 2/2] arm64: tegra: Add Tegra234 GPCDMA device tree node Akhil R
@ 2022-05-13 8:32 ` Krzysztof Kozlowski
2022-05-13 8:39 ` Jon Hunter
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-13 8:32 UTC (permalink / raw)
To: Akhil R, robh+dt, krzysztof.kozlowski+dt, thierry.reding,
jonathanh, devicetree, linux-tegra, linux-kernel
On 12/05/2022 11:00, Akhil R wrote:
> Add device tree nodes for Tegra234 GPCDMA
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 43 ++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index cb3af539e477..860c3cc68cea 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -21,6 +21,49 @@
>
> ranges = <0x0 0x0 0x0 0x40000000>;
>
> + gpcdma: dma-controller@2600000 {
> + compatible = "nvidia,tegra194-gpcdma",
> + "nvidia,tegra186-gpcdma";
> + reg = <0x2600000 0x210000>;
> + resets = <&bpmp TEGRA234_RESET_GPCDMA>;
> + reset-names = "gpcdma";
> + interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + iommus = <&smmu_niso0 TEGRA234_SID_GPCDMA>;
> + dma-coherent;
> + status = "okay";
okay is by default for new nodes.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: tegra: Add Tegra234 GPCDMA device tree node
2022-05-13 8:32 ` Krzysztof Kozlowski
@ 2022-05-13 8:39 ` Jon Hunter
2022-05-13 9:14 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Jon Hunter @ 2022-05-13 8:39 UTC (permalink / raw)
To: Krzysztof Kozlowski, Akhil R, robh+dt, krzysztof.kozlowski+dt,
thierry.reding, devicetree, linux-tegra, linux-kernel
On 13/05/2022 09:32, Krzysztof Kozlowski wrote:
> On 12/05/2022 11:00, Akhil R wrote:
>> Add device tree nodes for Tegra234 GPCDMA
>>
>> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
>> ---
>> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 43 ++++++++++++++++++++++++
>> 1 file changed, 43 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> index cb3af539e477..860c3cc68cea 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> @@ -21,6 +21,49 @@
>>
>> ranges = <0x0 0x0 0x0 0x40000000>;
>>
>> + gpcdma: dma-controller@2600000 {
>> + compatible = "nvidia,tegra194-gpcdma",
>> + "nvidia,tegra186-gpcdma";
>> + reg = <0x2600000 0x210000>;
>> + resets = <&bpmp TEGRA234_RESET_GPCDMA>;
>> + reset-names = "gpcdma";
>> + interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
>> + #dma-cells = <1>;
>> + iommus = <&smmu_niso0 TEGRA234_SID_GPCDMA>;
>> + dma-coherent;
>> + status = "okay";
>
> okay is by default for new nodes.
Just so I know, is it recommended then to drop the status in this case
or is it OK to leave as is?
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: tegra: Add Tegra234 GPCDMA device tree node
2022-05-13 8:39 ` Jon Hunter
@ 2022-05-13 9:14 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-13 9:14 UTC (permalink / raw)
To: Jon Hunter, Akhil R, robh+dt, krzysztof.kozlowski+dt,
thierry.reding, devicetree, linux-tegra, linux-kernel
On 13/05/2022 10:39, Jon Hunter wrote:
>
> On 13/05/2022 09:32, Krzysztof Kozlowski wrote:
>> On 12/05/2022 11:00, Akhil R wrote:
>>> Add device tree nodes for Tegra234 GPCDMA
>>>
>>> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
>>> ---
>>> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 43 ++++++++++++++++++++++++
>>> 1 file changed, 43 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>>> index cb3af539e477..860c3cc68cea 100644
>>> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>>> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>>> @@ -21,6 +21,49 @@
>>>
>>> ranges = <0x0 0x0 0x0 0x40000000>;
>>>
>>> + gpcdma: dma-controller@2600000 {
>>> + compatible = "nvidia,tegra194-gpcdma",
>>> + "nvidia,tegra186-gpcdma";
>>> + reg = <0x2600000 0x210000>;
>>> + resets = <&bpmp TEGRA234_RESET_GPCDMA>;
>>> + reset-names = "gpcdma";
>>> + interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
>>> + #dma-cells = <1>;
>>> + iommus = <&smmu_niso0 TEGRA234_SID_GPCDMA>;
>>> + dma-coherent;
>>> + status = "okay";
>>
>> okay is by default for new nodes.
>
> Just so I know, is it recommended then to drop the status in this case
> or is it OK to leave as is?
If this is a new node, then please drop it. Less code.
Of course it would be entirely different if this was overriding an
existing node with status=disabled.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-05-13 9:14 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 9:00 [PATCH 0/2] Add GPCDMA support for Tegra234 Akhil R
2022-05-12 9:00 ` [PATCH 1/2] dt-bindings: Add headers for Tegra234 GPCDMA Akhil R
2022-05-13 8:32 ` Krzysztof Kozlowski
2022-05-12 9:00 ` [PATCH 2/2] arm64: tegra: Add Tegra234 GPCDMA device tree node Akhil R
2022-05-13 8:32 ` Krzysztof Kozlowski
2022-05-13 8:39 ` Jon Hunter
2022-05-13 9:14 ` Krzysztof Kozlowski
2022-05-12 9:09 ` [PATCH 0/2] Add GPCDMA support for Tegra234 Jon Hunter
2022-05-12 9:21 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).