From: Maxime Ripard <maxime@cerno.tech>
To: qianfan <qianfanguijin@163.com>
Cc: linux-sunxi@lists.linux.dev, Rob Herring <robh+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ARM: dts: sun8i-r40: Add "cpu-supply" node for sun8i-r40 based board
Date: Mon, 16 May 2022 09:53:26 +0200 [thread overview]
Message-ID: <20220516075326.hccburhu743t7p6r@houat> (raw)
In-Reply-To: <666ead08-af1e-81f5-6fe1-e5e3370e6d6f@163.com>
On Fri, May 13, 2022 at 04:23:20PM +0800, qianfan wrote:
> > > > There's a similar issue for all the boards that don't have a regulator
> > > > in the first place.
> > > >
> > > > The way we worked around this for the other SoCs is to have a DTSI with
> > > > the OPPs with a frequency higher than what U-Boot boots with (1008MHz?),
> > > > and only include that DTSI on boards that have a CPU regulator hooked in.
> > > Is this really necessary? It seems like every board based on sun8i-r40
> > > have a cpu regulator.
> > This probably won't be the case whenever someone starts a new design,
> > and then they'll face random crashes for no apparent reason, and waste a
> > lot of time in the process.
> >
> > Whereas the alternative is that you would be missing some OPPs,
> > something that is fairly easy to figure out.
>
> How about remove the OPPs which greate that 1.08G in sun8i-r40.dtsi,
> If some boards want to run at a higher frequency, can add them byself
> in the board's file.
You did all the work to support and test them already. It's a bit of a
waste to do that and not include it.
Just do a DTSI like we did for the A64 for example.
Maxime
next prev parent reply other threads:[~2022-05-16 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 7:18 [PATCH v3 1/2] ARM: dts: sun8i-r40: add opp table for cpu qianfanguijin
2022-05-12 7:18 ` [PATCH v3 2/2] ARM: dts: sun8i-r40: Add "cpu-supply" node for sun8i-r40 based board qianfanguijin
2022-05-13 7:38 ` Maxime Ripard
2022-05-13 7:48 ` qianfan
2022-05-13 8:15 ` Maxime Ripard
2022-05-13 8:23 ` qianfan
2022-05-16 7:53 ` Maxime Ripard [this message]
2022-05-16 15:39 ` Chen-Yu Tsai
2022-05-12 7:29 ` [PATCH v3 1/2] ARM: dts: sun8i-r40: add opp table for cpu Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516075326.hccburhu743t7p6r@houat \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=qianfanguijin@163.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).