* [PATCH] scripts: kconfig: nconf: make nconfig accept jk keybindings
@ 2022-05-16 9:24 Isak Ellmer
2022-05-23 17:14 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: Isak Ellmer @ 2022-05-16 9:24 UTC (permalink / raw)
To: masahiroy; +Cc: linux-kbuild, linux-kernel, Isak Ellmer
Make nconfig accept jk keybindings for movement in addition to arrow keys.
Signed-off-by: Isak Ellmer <isak01@gmail.com>
---
scripts/kconfig/nconf.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
index 7b371bd7fb36..ded40e5aabf8 100644
--- a/scripts/kconfig/nconf.c
+++ b/scripts/kconfig/nconf.c
@@ -1105,9 +1105,11 @@ static void conf(struct menu *menu)
break;
switch (res) {
case KEY_DOWN:
+ case 'j':
menu_driver(curses_menu, REQ_DOWN_ITEM);
break;
case KEY_UP:
+ case 'k':
menu_driver(curses_menu, REQ_UP_ITEM);
break;
case KEY_NPAGE:
@@ -1287,9 +1289,11 @@ static void conf_choice(struct menu *menu)
break;
switch (res) {
case KEY_DOWN:
+ case 'j':
menu_driver(curses_menu, REQ_DOWN_ITEM);
break;
case KEY_UP:
+ case 'k':
menu_driver(curses_menu, REQ_UP_ITEM);
break;
case KEY_NPAGE:
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts: kconfig: nconf: make nconfig accept jk keybindings
2022-05-16 9:24 [PATCH] scripts: kconfig: nconf: make nconfig accept jk keybindings Isak Ellmer
@ 2022-05-23 17:14 ` Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2022-05-23 17:14 UTC (permalink / raw)
To: Isak Ellmer; +Cc: Linux Kbuild mailing list, Linux Kernel Mailing List
On Mon, May 16, 2022 at 6:24 PM Isak Ellmer <isak01@gmail.com> wrote:
>
> Make nconfig accept jk keybindings for movement in addition to arrow keys.
>
> Signed-off-by: Isak Ellmer <isak01@gmail.com>
> ---
I am fine with this.
Can you update the help message?
Around line 55:
"Linewise up <Up>\n"
"Linewise down <Down>\n"
> scripts/kconfig/nconf.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index 7b371bd7fb36..ded40e5aabf8 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -1105,9 +1105,11 @@ static void conf(struct menu *menu)
> break;
> switch (res) {
> case KEY_DOWN:
> + case 'j':
> menu_driver(curses_menu, REQ_DOWN_ITEM);
> break;
> case KEY_UP:
> + case 'k':
> menu_driver(curses_menu, REQ_UP_ITEM);
> break;
> case KEY_NPAGE:
> @@ -1287,9 +1289,11 @@ static void conf_choice(struct menu *menu)
> break;
> switch (res) {
> case KEY_DOWN:
> + case 'j':
> menu_driver(curses_menu, REQ_DOWN_ITEM);
> break;
> case KEY_UP:
> + case 'k':
> menu_driver(curses_menu, REQ_UP_ITEM);
> break;
> case KEY_NPAGE:
> --
> 2.35.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts: kconfig: nconf: make nconfig accept jk keybindings
2022-06-01 13:08 Isak Ellmer
@ 2022-06-01 13:52 ` Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2022-06-01 13:52 UTC (permalink / raw)
To: Isak Ellmer; +Cc: Linux Kbuild mailing list, Linux Kernel Mailing List
On Wed, Jun 1, 2022 at 10:08 PM Isak Ellmer <isak01@gmail.com> wrote:
>
> Make nconfig accept jk keybindings for movement in addition to arrow
> keys.
>
> Signed-off-by: Isak Ellmer <isak01@gmail.com>
> ---
Applied to linux-kbuild.
Thanks.
> scripts/kconfig/nconf.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index 7b371bd7fb36..3ba8b1af390f 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -52,8 +52,8 @@ static const char nconf_global_help[] =
> "\n"
> "Menu navigation keys\n"
> "----------------------------------------------------------------------\n"
> -"Linewise up <Up>\n"
> -"Linewise down <Down>\n"
> +"Linewise up <Up> <k>\n"
> +"Linewise down <Down> <j>\n"
> "Pagewise up <Page Up>\n"
> "Pagewise down <Page Down>\n"
> "First entry <Home>\n"
> @@ -1105,9 +1105,11 @@ static void conf(struct menu *menu)
> break;
> switch (res) {
> case KEY_DOWN:
> + case 'j':
> menu_driver(curses_menu, REQ_DOWN_ITEM);
> break;
> case KEY_UP:
> + case 'k':
> menu_driver(curses_menu, REQ_UP_ITEM);
> break;
> case KEY_NPAGE:
> @@ -1287,9 +1289,11 @@ static void conf_choice(struct menu *menu)
> break;
> switch (res) {
> case KEY_DOWN:
> + case 'j':
> menu_driver(curses_menu, REQ_DOWN_ITEM);
> break;
> case KEY_UP:
> + case 'k':
> menu_driver(curses_menu, REQ_UP_ITEM);
> break;
> case KEY_NPAGE:
> --
> 2.35.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] scripts: kconfig: nconf: make nconfig accept jk keybindings
@ 2022-06-01 13:08 Isak Ellmer
2022-06-01 13:52 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: Isak Ellmer @ 2022-06-01 13:08 UTC (permalink / raw)
To: masahiroy; +Cc: linux-kbuild, linux-kernel, Isak Ellmer
Make nconfig accept jk keybindings for movement in addition to arrow
keys.
Signed-off-by: Isak Ellmer <isak01@gmail.com>
---
scripts/kconfig/nconf.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
index 7b371bd7fb36..3ba8b1af390f 100644
--- a/scripts/kconfig/nconf.c
+++ b/scripts/kconfig/nconf.c
@@ -52,8 +52,8 @@ static const char nconf_global_help[] =
"\n"
"Menu navigation keys\n"
"----------------------------------------------------------------------\n"
-"Linewise up <Up>\n"
-"Linewise down <Down>\n"
+"Linewise up <Up> <k>\n"
+"Linewise down <Down> <j>\n"
"Pagewise up <Page Up>\n"
"Pagewise down <Page Down>\n"
"First entry <Home>\n"
@@ -1105,9 +1105,11 @@ static void conf(struct menu *menu)
break;
switch (res) {
case KEY_DOWN:
+ case 'j':
menu_driver(curses_menu, REQ_DOWN_ITEM);
break;
case KEY_UP:
+ case 'k':
menu_driver(curses_menu, REQ_UP_ITEM);
break;
case KEY_NPAGE:
@@ -1287,9 +1289,11 @@ static void conf_choice(struct menu *menu)
break;
switch (res) {
case KEY_DOWN:
+ case 'j':
menu_driver(curses_menu, REQ_DOWN_ITEM);
break;
case KEY_UP:
+ case 'k':
menu_driver(curses_menu, REQ_UP_ITEM);
break;
case KEY_NPAGE:
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-01 14:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 9:24 [PATCH] scripts: kconfig: nconf: make nconfig accept jk keybindings Isak Ellmer
2022-05-23 17:14 ` Masahiro Yamada
2022-06-01 13:08 Isak Ellmer
2022-06-01 13:52 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).