linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tyrone Ting <warp5tw@gmail.com>
To: avifishman70@gmail.com, tmaimon77@gmail.com,
	tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
	benjaminfair@google.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, wsa@kernel.org,
	andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com,
	semen.protsenko@linaro.org, rafal@milecki.pl, sven@svenpeter.dev,
	jsd@semihalf.com, jie.deng@intel.com, lukas.bulwahn@gmail.com,
	arnd@arndb.de, olof@lixom.net, warp5tw@gmail.com,
	tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com,
	tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com,
	kfting@nuvoton.com
Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 04/10] i2c: npcm: Fix timeout calculation
Date: Tue, 17 May 2022 18:11:36 +0800	[thread overview]
Message-ID: <20220517101142.28421-5-warp5tw@gmail.com> (raw)
In-Reply-To: <20220517101142.28421-1-warp5tw@gmail.com>

From: Tali Perry <tali.perry1@gmail.com>

Use adap.timeout for timeout calculation instead of hard-coded
value of 35ms.

Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
Signed-off-by: Tali Perry <tali.perry1@gmail.com>
Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
Reported-by: kernel test robot <lkp@intel.com>
---
 drivers/i2c/busses/i2c-npcm7xx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c
index 550e4a4d1e01..489b4c8ad0ee 100644
--- a/drivers/i2c/busses/i2c-npcm7xx.c
+++ b/drivers/i2c/busses/i2c-npcm7xx.c
@@ -2047,7 +2047,7 @@ static int npcm_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
 	u16 nwrite, nread;
 	u8 *write_data, *read_data;
 	u8 slave_addr;
-	int timeout;
+	unsigned long timeout;
 	int ret = 0;
 	bool read_block = false;
 	bool read_PEC = false;
@@ -2099,13 +2099,13 @@ static int npcm_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
 	 * 9: bits per transaction (including the ack/nack)
 	 */
 	timeout_usec = (2 * 9 * USEC_PER_SEC / bus->bus_freq) * (2 + nread + nwrite);
-	timeout = max(msecs_to_jiffies(35), usecs_to_jiffies(timeout_usec));
+	timeout = max_t(unsigned long, bus->adap.timeout, usecs_to_jiffies(timeout_usec));
 	if (nwrite >= 32 * 1024 || nread >= 32 * 1024) {
 		dev_err(bus->dev, "i2c%d buffer too big\n", bus->num);
 		return -EINVAL;
 	}
 
-	time_left = jiffies + msecs_to_jiffies(DEFAULT_STALL_COUNT) + 1;
+	time_left = jiffies + timeout + 1;
 	do {
 		/*
 		 * we must clear slave address immediately when the bus is not
@@ -2268,7 +2268,7 @@ static int npcm_i2c_probe_bus(struct platform_device *pdev)
 	adap = &bus->adap;
 	adap->owner = THIS_MODULE;
 	adap->retries = 3;
-	adap->timeout = HZ;
+	adap->timeout = msecs_to_jiffies(35);
 	adap->algo = &npcm_i2c_algo;
 	adap->quirks = &npcm_i2c_quirks;
 	adap->algo_data = bus;
-- 
2.17.1


  parent reply	other threads:[~2022-05-17 10:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 10:11 [PATCH v5 00/10] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 01/10] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
2022-05-21  6:03   ` Wolfram Sang
2022-05-21 12:30     ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 02/10] i2c: npcm: Change the way of getting GCR regmap Tyrone Ting
2022-05-21  5:51   ` Wolfram Sang
2022-05-21 12:36     ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 03/10] i2c: npcm: Remove unused variable clk_regmap Tyrone Ting
2022-05-21  5:51   ` Wolfram Sang
2022-05-21 12:53     ` Tyrone Ting
2022-05-17 10:11 ` Tyrone Ting [this message]
2022-05-21  5:52   ` [PATCH v5 04/10] i2c: npcm: Fix timeout calculation Wolfram Sang
2022-05-21 12:55     ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 05/10] i2c: npcm: Add tx complete counter Tyrone Ting
2022-05-21  5:52   ` Wolfram Sang
2022-05-21 12:57     ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 06/10] i2c: npcm: Correct register access width Tyrone Ting
2022-05-21  5:53   ` Wolfram Sang
2022-05-21 12:58     ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 07/10] i2c: npcm: Handle spurious interrupts Tyrone Ting
2022-05-21  5:53   ` Wolfram Sang
2022-05-21 13:00     ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 08/10] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting
2022-05-21  5:58   ` Wolfram Sang
2022-05-22  6:56     ` Tali Perry
2022-05-22 20:09       ` Wolfram Sang
2022-05-17 10:11 ` [PATCH v5 09/10] i2c: npcm: Support NPCM845 Tyrone Ting
2022-05-21  6:00   ` Wolfram Sang
2022-05-21 13:10     ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 10/10] i2c: npcm: Capitalize the one-line comment Tyrone Ting
2022-05-21  6:03   ` Wolfram Sang
2022-05-21 13:22     ` Tyrone Ting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517101142.28421-5-warp5tw@gmail.com \
    --to=warp5tw@gmail.com \
    --cc=Avi.Fishman@nuvoton.com \
    --cc=JJLIU0@nuvoton.com \
    --cc=KWLIU@nuvoton.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jie.deng@intel.com \
    --cc=jsd@semihalf.com \
    --cc=kfting@nuvoton.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=olof@lixom.net \
    --cc=openbmc@lists.ozlabs.org \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=sven@svenpeter.dev \
    --cc=tali.perry1@gmail.com \
    --cc=tali.perry@nuvoton.com \
    --cc=tmaimon77@gmail.com \
    --cc=tomer.maimon@nuvoton.com \
    --cc=venture@google.com \
    --cc=wsa@kernel.org \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).