From: Wolfram Sang <wsa@kernel.org>
To: Tali Perry <tali.perry1@gmail.com>
Cc: Tyrone Ting <warp5tw@gmail.com>,
avifishman70@gmail.com, Tomer Maimon <tmaimon77@gmail.com>,
Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Rob Herring <robh+dt@kernel.org>,
krzysztof.kozlowski+dt@linaro.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org,
rafal@milecki.pl, sven@svenpeter.dev, jsd@semihalf.com,
jie.deng@intel.com, lukas.bulwahn@gmail.com, arnd@arndb.de,
olof@lixom.net, Tali Perry <tali.perry@nuvoton.com>,
Avi Fishman <Avi.Fishman@nuvoton.com>,
tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com,
kfting@nuvoton.com, OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux I2C <linux-i2c@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 08/10] i2c: npcm: Remove own slave addresses 2:10
Date: Sun, 22 May 2022 22:09:35 +0200 [thread overview]
Message-ID: <YoqYf0KdNEabT7Mu@shikoro> (raw)
In-Reply-To: <CAHb3i=uKwe1RdvzQA=oO6zNmEvyA_awx09+C2w8kbRq_NGi54w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]
Hi Tali,
> So when we encounter a deadlock with this spinlock we decided to get rid of this
> unused feature and get both a stable fix for the issue + performance benefits.
> We work closely with all our customers so we know that this HW
> feature is useless to them.
Okay, fair enough. Thanks for the detailed explanation!
> > Why do we keep this array if we drop the support?
> >
> This array represents the HW so we left it as-is. But I agree it can
> be shortened to one\two.
Would be nice, I think.
> OK, we will move the last two to a separate patch. BTW, this change
> appears in the title as well.
Yes, but I still think it should be a seperate change.
> But now I'm not sure: if you already apply for-next patches [1:7], and
> we change patch [8:10]
> do we need to re-submit [1:7]?
Nope, they are already in linux-next. They seemed like good fixes even
without the support for the new SoC, so I applied them right away. I
hope this was okay.
> Thanks, Wolfram, for your review!
> Much appreciated
You are welcome :)
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-22 20:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 10:11 [PATCH v5 00/10] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 01/10] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
2022-05-21 6:03 ` Wolfram Sang
2022-05-21 12:30 ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 02/10] i2c: npcm: Change the way of getting GCR regmap Tyrone Ting
2022-05-21 5:51 ` Wolfram Sang
2022-05-21 12:36 ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 03/10] i2c: npcm: Remove unused variable clk_regmap Tyrone Ting
2022-05-21 5:51 ` Wolfram Sang
2022-05-21 12:53 ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 04/10] i2c: npcm: Fix timeout calculation Tyrone Ting
2022-05-21 5:52 ` Wolfram Sang
2022-05-21 12:55 ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 05/10] i2c: npcm: Add tx complete counter Tyrone Ting
2022-05-21 5:52 ` Wolfram Sang
2022-05-21 12:57 ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 06/10] i2c: npcm: Correct register access width Tyrone Ting
2022-05-21 5:53 ` Wolfram Sang
2022-05-21 12:58 ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 07/10] i2c: npcm: Handle spurious interrupts Tyrone Ting
2022-05-21 5:53 ` Wolfram Sang
2022-05-21 13:00 ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 08/10] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting
2022-05-21 5:58 ` Wolfram Sang
2022-05-22 6:56 ` Tali Perry
2022-05-22 20:09 ` Wolfram Sang [this message]
2022-05-17 10:11 ` [PATCH v5 09/10] i2c: npcm: Support NPCM845 Tyrone Ting
2022-05-21 6:00 ` Wolfram Sang
2022-05-21 13:10 ` Tyrone Ting
2022-05-17 10:11 ` [PATCH v5 10/10] i2c: npcm: Capitalize the one-line comment Tyrone Ting
2022-05-21 6:03 ` Wolfram Sang
2022-05-21 13:22 ` Tyrone Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoqYf0KdNEabT7Mu@shikoro \
--to=wsa@kernel.org \
--cc=Avi.Fishman@nuvoton.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jie.deng@intel.com \
--cc=jsd@semihalf.com \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sven@svenpeter.dev \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=venture@google.com \
--cc=warp5tw@gmail.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).